Re: [FFmpeg-devel] [PATCH] avfilter/formats: fix wrong function name in error message

2017-12-12 Thread Michael Niedermayer
On Tue, Dec 12, 2017 at 01:59:18PM +0800, Jun Zhao wrote: > > > On 2017/12/7 8:49, Jun Zhao wrote: > > > > On 2017/12/5 17:25, Hendrik Leppkes wrote: > >> On Tue, Dec 5, 2017 at 6:42 AM, Jun Zhao wrote: > >>> On 2017/12/5 2:32, Michael Niedermayer wrote: > On Mon, Dec

Re: [FFmpeg-devel] [PATCH] avfilter/formats: fix wrong function name in error message

2017-12-11 Thread Jun Zhao
On 2017/12/7 8:49, Jun Zhao wrote: > > On 2017/12/5 17:25, Hendrik Leppkes wrote: >> On Tue, Dec 5, 2017 at 6:42 AM, Jun Zhao wrote: >>> On 2017/12/5 2:32, Michael Niedermayer wrote: On Mon, Dec 04, 2017 at 11:07:11AM +0100, Hendrik Leppkes wrote: > On Mon, Dec 4,

Re: [FFmpeg-devel] [PATCH] avfilter/formats: fix wrong function name in error message

2017-12-06 Thread Jun Zhao
On 2017/12/5 17:25, Hendrik Leppkes wrote: > On Tue, Dec 5, 2017 at 6:42 AM, Jun Zhao wrote: >> >> On 2017/12/5 2:32, Michael Niedermayer wrote: >>> On Mon, Dec 04, 2017 at 11:07:11AM +0100, Hendrik Leppkes wrote: On Mon, Dec 4, 2017 at 10:53 AM, Moritz Barsnick

Re: [FFmpeg-devel] [PATCH] avfilter/formats: fix wrong function name in error message

2017-12-05 Thread Hendrik Leppkes
On Tue, Dec 5, 2017 at 6:42 AM, Jun Zhao wrote: > > > On 2017/12/5 2:32, Michael Niedermayer wrote: >> On Mon, Dec 04, 2017 at 11:07:11AM +0100, Hendrik Leppkes wrote: >>> On Mon, Dec 4, 2017 at 10:53 AM, Moritz Barsnick wrote: On Mon, Dec 04, 2017 at

Re: [FFmpeg-devel] [PATCH] avfilter/formats: fix wrong function name in error message

2017-12-05 Thread Bang He
I prefer option 1). and microsoft vc++ uspport __FUNCTION__ On Tue, Dec 5, 2017 at 1:42 PM, Jun Zhao wrote: > > > On 2017/12/5 2:32, Michael Niedermayer wrote: > > On Mon, Dec 04, 2017 at 11:07:11AM +0100, Hendrik Leppkes wrote: > >> On Mon, Dec 4, 2017 at 10:53 AM, Moritz

Re: [FFmpeg-devel] [PATCH] avfilter/formats: fix wrong function name in error message

2017-12-04 Thread Jun Zhao
On 2017/12/5 2:32, Michael Niedermayer wrote: > On Mon, Dec 04, 2017 at 11:07:11AM +0100, Hendrik Leppkes wrote: >> On Mon, Dec 4, 2017 at 10:53 AM, Moritz Barsnick wrote: >>> On Mon, Dec 04, 2017 at 13:02:20 +0800, Jun Zhao wrote: Use perdefined micro __FUNCTION__ rather

Re: [FFmpeg-devel] [PATCH] avfilter/formats: fix wrong function name in error message

2017-12-04 Thread Michael Niedermayer
On Mon, Dec 04, 2017 at 11:07:11AM +0100, Hendrik Leppkes wrote: > On Mon, Dec 4, 2017 at 10:53 AM, Moritz Barsnick wrote: > > On Mon, Dec 04, 2017 at 13:02:20 +0800, Jun Zhao wrote: > >> Use perdefined micro __FUNCTION__ rather than hard coding function name > >> to fix wrong

Re: [FFmpeg-devel] [PATCH] avfilter/formats: fix wrong function name in error message

2017-12-04 Thread Hendrik Leppkes
On Mon, Dec 4, 2017 at 10:53 AM, Moritz Barsnick wrote: > On Mon, Dec 04, 2017 at 13:02:20 +0800, Jun Zhao wrote: >> Use perdefined micro __FUNCTION__ rather than hard coding function name >> to fix wrong function name in error message. > > AFAICT, "__FUNCTION__" is a C99

Re: [FFmpeg-devel] [PATCH] avfilter/formats: fix wrong function name in error message

2017-12-04 Thread Moritz Barsnick
On Mon, Dec 04, 2017 at 13:02:20 +0800, Jun Zhao wrote: > Use perdefined micro __FUNCTION__ rather than hard coding function name > to fix wrong function name in error message. AFAICT, "__FUNCTION__" is a C99 feature and thereby not supported by ffmpeg style. Or should it be? (It might be