Re: [FFmpeg-devel] [PATCH] avfilter/vf_stereo3d: implement auto detection by using frame side data

2017-12-10 Thread Nicolas George
Michael Niedermayer (2017-12-03): > I think i may be missing something here > > The way i remember this, is that all the changes do never get > triggered unless the user application passes frames with changing > parameters into the filter graph. > That is something not supported before these

Re: [FFmpeg-devel] [PATCH] avfilter/vf_stereo3d: implement auto detection by using frame side data

2017-12-03 Thread Michael Niedermayer
On Sun, Dec 03, 2017 at 08:21:50PM +0100, Nicolas George wrote: > Michael Niedermayer (2017-12-01): > > Do you think this comment will fix any issue or improve anything ? > > This comment had one goal: prevent somebody from pushing incorrect > changes before I had time to make my point. > > >

Re: [FFmpeg-devel] [PATCH] avfilter/vf_stereo3d: implement auto detection by using frame side data

2017-12-03 Thread Nicolas George
Michael Niedermayer (2017-12-01): > Do you think this comment will fix any issue or improve anything ? This comment had one goal: prevent somebody from pushing incorrect changes before I had time to make my point. > First i do not even know what you speak of exactly and as this is I posted the

Re: [FFmpeg-devel] [PATCH] avfilter/vf_stereo3d: implement auto detection by using frame side data

2017-12-01 Thread Michael Niedermayer
On Fri, Dec 01, 2017 at 07:23:00PM +0100, Nicolas George wrote: > Michael Niedermayer (2017-12-01): > > As the one who tried implementing changing frame parameters like > > dimension long time ago, the only real problem i encountered was > > bikeshedding, i dont rememer a technical problem. > >

Re: [FFmpeg-devel] [PATCH] avfilter/vf_stereo3d: implement auto detection by using frame side data

2017-12-01 Thread Paul B Mahol
On 12/1/17, Nicolas George wrote: > Michael Niedermayer (2017-12-01): >> As the one who tried implementing changing frame parameters like >> dimension long time ago, the only real problem i encountered was >> bikeshedding, i dont rememer a technical problem. > > "not easy" !=

Re: [FFmpeg-devel] [PATCH] avfilter/vf_stereo3d: implement auto detection by using frame side data

2017-12-01 Thread Nicolas George
Michael Niedermayer (2017-12-01): > As the one who tried implementing changing frame parameters like > dimension long time ago, the only real problem i encountered was > bikeshedding, i dont rememer a technical problem. "not easy" != "tremendously hard". I said it would not be easy, i.e. it will

Re: [FFmpeg-devel] [PATCH] avfilter/vf_stereo3d: implement auto detection by using frame side data

2017-12-01 Thread Michael Niedermayer
On Fri, Dec 01, 2017 at 06:10:02PM +0100, wm4 wrote: > On Fri, 1 Dec 2017 18:02:52 +0100 > Michael Niedermayer wrote: > > > On Fri, Dec 01, 2017 at 10:01:42AM +0100, Nicolas George wrote: > > > Paul B Mahol (2017-11-30): > > > > +static int reset_links(AVFilterContext

Re: [FFmpeg-devel] [PATCH] avfilter/vf_stereo3d: implement auto detection by using frame side data

2017-12-01 Thread Paul B Mahol
On 12/1/17, wm4 wrote: > On Fri, 1 Dec 2017 18:02:52 +0100 > Michael Niedermayer wrote: > >> On Fri, Dec 01, 2017 at 10:01:42AM +0100, Nicolas George wrote: >> > Paul B Mahol (2017-11-30): >> > > +static int reset_links(AVFilterContext *filter) >> >

Re: [FFmpeg-devel] [PATCH] avfilter/vf_stereo3d: implement auto detection by using frame side data

2017-12-01 Thread wm4
On Fri, 1 Dec 2017 18:02:52 +0100 Michael Niedermayer wrote: > On Fri, Dec 01, 2017 at 10:01:42AM +0100, Nicolas George wrote: > > Paul B Mahol (2017-11-30): > > > +static int reset_links(AVFilterContext *filter) > > > +{ > > > +int i, ret; > > > + > > > +if

Re: [FFmpeg-devel] [PATCH] avfilter/vf_stereo3d: implement auto detection by using frame side data

2017-12-01 Thread Michael Niedermayer
On Fri, Dec 01, 2017 at 10:01:42AM +0100, Nicolas George wrote: > Paul B Mahol (2017-11-30): > > +static int reset_links(AVFilterContext *filter) > > +{ > > +int i, ret; > > + > > +if (!filter) > > +return 0; > > + > > +for (i = 0; i < filter->nb_outputs; i++) { > > +

Re: [FFmpeg-devel] [PATCH] avfilter/vf_stereo3d: implement auto detection by using frame side data

2017-12-01 Thread wm4
On Fri, 1 Dec 2017 10:35:34 +0100 Paul B Mahol wrote: > On 12/1/17, Nicolas George wrote: > > Paul B Mahol (2017-11-30): > >> +static int reset_links(AVFilterContext *filter) > >> +{ > >> +int i, ret; > >> + > >> +if (!filter) > >> +return 0;

Re: [FFmpeg-devel] [PATCH] avfilter/vf_stereo3d: implement auto detection by using frame side data

2017-12-01 Thread Paul B Mahol
On 12/1/17, Nicolas George wrote: > Paul B Mahol (2017-11-30): >> +static int reset_links(AVFilterContext *filter) >> +{ >> +int i, ret; >> + >> +if (!filter) >> +return 0; >> + >> +for (i = 0; i < filter->nb_outputs; i++) { >> +AVFilterLink *link =

Re: [FFmpeg-devel] [PATCH] avfilter/vf_stereo3d: implement auto detection by using frame side data

2017-12-01 Thread Nicolas George
Paul B Mahol (2017-11-30): > +static int reset_links(AVFilterContext *filter) > +{ > +int i, ret; > + > +if (!filter) > +return 0; > + > +for (i = 0; i < filter->nb_outputs; i++) { > +AVFilterLink *link = filter->outputs[i]; > + > +link->init_state =

Re: [FFmpeg-devel] [PATCH] avfilter/vf_stereo3d: implement auto detection by using frame side data

2017-11-30 Thread Paul B Mahol
On 11/30/17, wm4 wrote: > On Wed, 29 Nov 2017 23:15:44 +0100 > Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol >> --- >> doc/filters.texi | 4 >> libavfilter/vf_stereo3d.c | 35 --- >>

Re: [FFmpeg-devel] [PATCH] avfilter/vf_stereo3d: implement auto detection by using frame side data

2017-11-29 Thread wm4
On Wed, 29 Nov 2017 23:15:44 +0100 Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 4 > libavfilter/vf_stereo3d.c | 35 --- > 2 files changed, 36 insertions(+), 3 deletions(-) > >

Re: [FFmpeg-devel] [PATCH] avfilter/vf_stereo3d: implement auto detection by using frame side data

2017-11-29 Thread Carl Eugen Hoyos
2017-11-29 23:46 GMT+01:00 Paul B Mahol : > On 11/29/17, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> doc/filters.texi | 4 >> libavfilter/vf_stereo3d.c | 35 --- >> 2 files

Re: [FFmpeg-devel] [PATCH] avfilter/vf_stereo3d: implement auto detection by using frame side data

2017-11-29 Thread Paul B Mahol
On 11/29/17, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 4 > libavfilter/vf_stereo3d.c | 35 --- > 2 files changed, 36 insertions(+), 3 deletions(-) > This breaks if one uses