Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-11-02 Thread Nicolas George 
Le decadi 10 brumaire, an CCXXVI, Paul B Mahol a écrit :
> Signed-off-by: Paul B Mahol 
> ---
>  libavfilter/vf_tile.c | 17 +
>  1 file changed, 13 insertions(+), 4 deletions(-)
> 
> diff --git a/libavfilter/vf_tile.c b/libavfilter/vf_tile.c
> index 87e0b940cf..8eb0dc2097 100644
> --- a/libavfilter/vf_tile.c
> +++ b/libavfilter/vf_tile.c
> @@ -23,6 +23,7 @@
>   * tile video filter
>   */
>  
> +#include "libavutil/imgutils.h"
>  #include "libavutil/opt.h"
>  #include "libavutil/pixdesc.h"
>  #include "avfilter.h"
> @@ -44,8 +45,6 @@ typedef struct TileContext {
>  uint8_t rgba_color[4];
>  } TileContext;
>  
> -#define REASONABLE_SIZE 1024
> -
>  #define OFFSET(x) offsetof(TileContext, x)
>  #define FLAGS AV_OPT_FLAG_VIDEO_PARAM|AV_OPT_FLAG_FILTERING_PARAM
>  
> @@ -68,12 +67,21 @@ static av_cold int init(AVFilterContext *ctx)
>  {
>  TileContext *tile = ctx->priv;
>  
> -if (tile->w > REASONABLE_SIZE || tile->h > REASONABLE_SIZE) {

> +if (tile->w > UINT32_MAX / tile->h) {

All the variables are of type unsigned, not uint32_t; therefore, the
correct limit would be UINT_MAX.

>  av_log(ctx, AV_LOG_ERROR, "Tile size %ux%u is insane.\n",
> tile->w, tile->h);
>  return AVERROR(EINVAL);
>  }
>  
> +if (tile->padding) {
> +if ((tile->w - 1 > (UINT32_MAX - 2 * tile->margin) / tile->padding) 
> ||
> +(tile->h - 1 > (UINT32_MAX - 2 * tile->margin) / tile->padding)) 
> {
> +av_log(ctx, AV_LOG_ERROR, "Combination of Tile size %ux%u, 
> padding %d and margin %d overflows.\n",
> +   tile->w, tile->h, tile->padding, tile->margin);
> +return AVERROR(EINVAL);
> +}
> +}
> +
>  if (tile->nb_frames == 0) {
>  tile->nb_frames = tile->w * tile->h;
>  } else if (tile->nb_frames > tile->w * tile->h) {
> @@ -116,7 +124,7 @@ static int config_props(AVFilterLink *outlink)
>  ff_draw_init(>draw, inlink->format, 0);
>  ff_draw_color(>draw, >blank, tile->rgba_color);
>  

> -return 0;
> +return av_image_check_size2(outlink->w, outlink->h, INT64_MAX, 
> inlink->format, 0, ctx);

This is no longer necessary now it is done for all filters.

>  }
>  
>  static void get_current_tile_pos(AVFilterContext *ctx, unsigned *x, unsigned 
> *y)
> @@ -142,6 +150,7 @@ static void draw_blank_frame(AVFilterContext *ctx, 
> AVFrame *out_buf)
>x0, y0, inlink->w, inlink->h);
>  tile->current++;
>  }
> +
>  static int end_last_frame(AVFilterContext *ctx)
>  {
>  TileContext *tile = ctx->priv;

LGTM now. Thanks for your efforts.

Regards,

-- 
  Nicolas George


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-31 Thread Nicolas George 
Nack.

Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a écrit :
> Signed-off-by: Paul B Mahol 
> ---
>  libavfilter/vf_tile.c | 12 +++-
>  1 file changed, 3 insertions(+), 9 deletions(-)
> 
> diff --git a/libavfilter/vf_tile.c b/libavfilter/vf_tile.c
> index 87e0b940cf..5752ca080e 100644
> --- a/libavfilter/vf_tile.c
> +++ b/libavfilter/vf_tile.c
> @@ -23,6 +23,7 @@
>   * tile video filter
>   */
>  
> +#include "libavutil/imgutils.h"
>  #include "libavutil/opt.h"
>  #include "libavutil/pixdesc.h"
>  #include "avfilter.h"
> @@ -44,8 +45,6 @@ typedef struct TileContext {
>  uint8_t rgba_color[4];
>  } TileContext;
>  
> -#define REASONABLE_SIZE 1024
> -
>  #define OFFSET(x) offsetof(TileContext, x)
>  #define FLAGS AV_OPT_FLAG_VIDEO_PARAM|AV_OPT_FLAG_FILTERING_PARAM
>  
> @@ -68,12 +67,6 @@ static av_cold int init(AVFilterContext *ctx)
>  {
>  TileContext *tile = ctx->priv;
>  
> -if (tile->w > REASONABLE_SIZE || tile->h > REASONABLE_SIZE) {
> -av_log(ctx, AV_LOG_ERROR, "Tile size %ux%u is insane.\n",
> -   tile->w, tile->h);
> -return AVERROR(EINVAL);
> -}
> -

>  if (tile->nb_frames == 0) {
>  tile->nb_frames = tile->w * tile->h;

This multiplication still overflows. The problem is caught later because
a tile size that results in an overflow will also result in a too large
image, but this is fragile design, since the values that are being
tested has no direct relation with the value that is being invalid.

And that is not all:

const unsigned total_margin_w = (tile->w - 1) * tile->padding + 
2*tile->margin;
const unsigned total_margin_h = (tile->h - 1) * tile->padding + 
2*tile->margin;

These computations will also overflow with a large tile size. This would
result in tile happily drawing beyond the boundaries of the image. It
does not actually happens because the frame pool is inited using
av_image_check_size() rather than av_image_check_size2() and thus uses a
stride that is larger than necessary and causes the image to seem too
large. But once this is fixed, it will happen.

I will not accept bugs added just because they are hidden by other bugs.
That would be a highway to catastrophe. If you want this change to be
accepted, you need to perform all the overflow check correctly (or prove
that they are not needed), not throw random checks around in the hope
they catch problems.

>  } else if (tile->nb_frames > tile->w * tile->h) {
> @@ -116,7 +109,7 @@ static int config_props(AVFilterLink *outlink)
>  ff_draw_init(>draw, inlink->format, 0);
>  ff_draw_color(>draw, >blank, tile->rgba_color);
>  
> -return 0;
> +return av_image_check_size2(outlink->w, outlink->h, INT64_MAX, 
> inlink->format, 0, ctx);
>  }
>  
>  static void get_current_tile_pos(AVFilterContext *ctx, unsigned *x, unsigned 
> *y)
> @@ -142,6 +135,7 @@ static void draw_blank_frame(AVFilterContext *ctx, 
> AVFrame *out_buf)
>x0, y0, inlink->w, inlink->h);
>  tile->current++;
>  }
> +
>  static int end_last_frame(AVFilterContext *ctx)
>  {
>  TileContext *tile = ctx->priv;

-- 
  Nicolas George


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Nicolas George 
Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a écrit :
> No it doesn't work like that any more.
> 
> Some folks commit to maintained code by someone else without prior review.
> 
> Why I should not be one of them?

Are you trying to derail the project on purpose?

Now, please behave like a civilized member of a multi-user community. I
want to review the patch to make sure it is now correct (remember it is
the third iteration, the first two were wrong), because I care about
code quality. I need time and good access to the source code for that. I
am sorry, you will have to wait. Fortunately, this patch is not about
security or a regression, it is about a harmless limitation that have
been around for years, it can wait a few days more. I am sure you have
plenty better to do with your time.

This will probably the last mail I will have time to write this
week-end; I would have preferred to spend it on something more
interesting. When I come back, I expect to find things as is, or
possibly an even better version on the patch waiting on the mailing
list. Anything else would be a declaration of open hostility.

-- 
  Nicolas George


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Paul B Mahol 
On 10/28/17, Paul B Mahol  wrote:
> On 10/28/17, Nicolas George  wrote:
>> Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a ecrit :
>>> I already posted another version which I will push shortly.
>>
>> No, you will wait until I approve the patch, since it is code that I
>> maintain. That is how it works.
>
> No it doesn't work like that any more.
>
> Some folks commit to maintained code by someone else without prior review.
>
> Why I should not be one of them?
>

And remmember, you are bad guy here.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Paul B Mahol 
On 10/28/17, Nicolas George  wrote:
> Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a ecrit :
>> I already posted another version which I will push shortly.
>
> No, you will wait until I approve the patch, since it is code that I
> maintain. That is how it works.

No it doesn't work like that any more.

Some folks commit to maintained code by someone else without prior review.

Why I should not be one of them?
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Nicolas George 
Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a écrit :
> I already posted another version which I will push shortly.

No, you will wait until I approve the patch, since it is code that I
maintain. That is how it works.

Regards,

-- 
  Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Paul B Mahol 
On 10/28/17, Nicolas George  wrote:
> Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a ecrit :
>> You still have not provided valid reason to block it.
>
> Your first patch was wrong. I have observed a possible flaw in the
> second one. I thought I had a test case to show it, maybe I was wrong. I
> need to check and test.
>
> Now, I might add, if you were not so antagonistic all the time, I might
> have wasted less time in these useless exchanges and had more time to
> actually examine the patch. Right now I do not have time. So you will
> just have to wait.
>
> But do not dare push the patch as is.

I already posted another version which I will push shortly.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Nicolas George 
Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a écrit :
> You still have not provided valid reason to block it.

Your first patch was wrong. I have observed a possible flaw in the
second one. I thought I had a test case to show it, maybe I was wrong. I
need to check and test.

Now, I might add, if you were not so antagonistic all the time, I might
have wasted less time in these useless exchanges and had more time to
actually examine the patch. Right now I do not have time. So you will
just have to wait.

But do not dare push the patch as is.

-- 
  Nicolas George


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Paul B Mahol 
On 10/28/17, Nicolas George  wrote:
> Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a ecrit :
>> Gonna apply this patch soonTM because of no valid reasons to block it.
>
> No, you will not.

You still have not provided valid reason to block it.

testsrc2 filter hang is unrelated to my change.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Nicolas George 
Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a écrit :
> Gonna apply this patch soonTM because of no valid reasons to block it.

No, you will not.

-- 
  Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Paul B Mahol 
On 10/28/17, Paul B Mahol  wrote:
> On 10/28/17, Clement Boesch  wrote:
>> On Sat, Oct 28, 2017 at 02:42:26PM +0200, Paul B Mahol wrote:
>>> On 10/28/17, Clement Boesch  wrote:
>>> > On Fri, Oct 27, 2017 at 10:38:11PM +0200, Nicolas George wrote:
>>> >> Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a ecrit :
>>> >> > Signed-off-by: Paul B Mahol 
>>> >> > ---
>>> >> >  libavfilter/vf_tile.c | 8 
>>> >> >  1 file changed, 8 deletions(-)
>>> >>
>>> >> Nack.
>>> >>
>>> >> ./ffmpeg_g -lavfi testsrc2=s=2x2,tile=65536x65536,scale=1024x1024 -f
>>> >> framecrc -
>>> >>
>>> >> hangs instead of returning a proper error.
>>> >>
>>> >
>>> > In case there is confusion with what Paul said: `ffmpeg -lavfi
>>> > testsrc2=s=2x2 -f framecrc -` hangs with current git/master, so the
>>> > hang
>>> > you're reporting is likely unrelated to this patch. Instead, it looks
>>> > like
>>> > a
>>> > problem related to the 2x2 size being too small for testsrc2 (testsrc
>>> > supports 2x2, testsrc2 doesn't).
>>> >
>>> > (Not saying the current patch is correct though)
>>>
>>> I don't remmember I hired lawyer. Did I?
>>
>> I'm not defending you, I'm explaining a potential misunderstanding
>> between
>> Nicolas and you, giving information you should probably have provided
>> yourself to ease the communication to prevent pointless escalation.
>
> I already provided it. The problem is people forgot to read.
>

Gonna apply this patch soonTM because of no valid reasons to block it.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Paul B Mahol 
On 10/28/17, Clement Boesch  wrote:
> On Sat, Oct 28, 2017 at 02:42:26PM +0200, Paul B Mahol wrote:
>> On 10/28/17, Clement Boesch  wrote:
>> > On Fri, Oct 27, 2017 at 10:38:11PM +0200, Nicolas George wrote:
>> >> Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a ecrit :
>> >> > Signed-off-by: Paul B Mahol 
>> >> > ---
>> >> >  libavfilter/vf_tile.c | 8 
>> >> >  1 file changed, 8 deletions(-)
>> >>
>> >> Nack.
>> >>
>> >> ./ffmpeg_g -lavfi testsrc2=s=2x2,tile=65536x65536,scale=1024x1024 -f
>> >> framecrc -
>> >>
>> >> hangs instead of returning a proper error.
>> >>
>> >
>> > In case there is confusion with what Paul said: `ffmpeg -lavfi
>> > testsrc2=s=2x2 -f framecrc -` hangs with current git/master, so the
>> > hang
>> > you're reporting is likely unrelated to this patch. Instead, it looks
>> > like
>> > a
>> > problem related to the 2x2 size being too small for testsrc2 (testsrc
>> > supports 2x2, testsrc2 doesn't).
>> >
>> > (Not saying the current patch is correct though)
>>
>> I don't remmember I hired lawyer. Did I?
>
> I'm not defending you, I'm explaining a potential misunderstanding between
> Nicolas and you, giving information you should probably have provided
> yourself to ease the communication to prevent pointless escalation.

I already provided it. The problem is people forgot to read.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Clément Bœsch 
On Sat, Oct 28, 2017 at 02:42:26PM +0200, Paul B Mahol wrote:
> On 10/28/17, Clement Boesch  wrote:
> > On Fri, Oct 27, 2017 at 10:38:11PM +0200, Nicolas George wrote:
> >> Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a ecrit :
> >> > Signed-off-by: Paul B Mahol 
> >> > ---
> >> >  libavfilter/vf_tile.c | 8 
> >> >  1 file changed, 8 deletions(-)
> >>
> >> Nack.
> >>
> >> ./ffmpeg_g -lavfi testsrc2=s=2x2,tile=65536x65536,scale=1024x1024 -f
> >> framecrc -
> >>
> >> hangs instead of returning a proper error.
> >>
> >
> > In case there is confusion with what Paul said: `ffmpeg -lavfi
> > testsrc2=s=2x2 -f framecrc -` hangs with current git/master, so the hang
> > you're reporting is likely unrelated to this patch. Instead, it looks like
> > a
> > problem related to the 2x2 size being too small for testsrc2 (testsrc
> > supports 2x2, testsrc2 doesn't).
> >
> > (Not saying the current patch is correct though)
> 
> I don't remmember I hired lawyer. Did I?

I'm not defending you, I'm explaining a potential misunderstanding between
Nicolas and you, giving information you should probably have provided
yourself to ease the communication to prevent pointless escalation.

Regards,

-- 
Clément B.


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Paul B Mahol 
On 10/28/17, Clement Boesch  wrote:
> On Fri, Oct 27, 2017 at 10:38:11PM +0200, Nicolas George wrote:
>> Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a ecrit :
>> > Signed-off-by: Paul B Mahol 
>> > ---
>> >  libavfilter/vf_tile.c | 8 
>> >  1 file changed, 8 deletions(-)
>>
>> Nack.
>>
>> ./ffmpeg_g -lavfi testsrc2=s=2x2,tile=65536x65536,scale=1024x1024 -f
>> framecrc -
>>
>> hangs instead of returning a proper error.
>>
>
> In case there is confusion with what Paul said: `ffmpeg -lavfi
> testsrc2=s=2x2 -f framecrc -` hangs with current git/master, so the hang
> you're reporting is likely unrelated to this patch. Instead, it looks like
> a
> problem related to the 2x2 size being too small for testsrc2 (testsrc
> supports 2x2, testsrc2 doesn't).
>
> (Not saying the current patch is correct though)

I don't remmember I hired lawyer. Did I?
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Clément Bœsch 
On Fri, Oct 27, 2017 at 10:38:11PM +0200, Nicolas George wrote:
> Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a écrit :
> > Signed-off-by: Paul B Mahol 
> > ---
> >  libavfilter/vf_tile.c | 8 
> >  1 file changed, 8 deletions(-)
> 
> Nack.
> 
> ./ffmpeg_g -lavfi testsrc2=s=2x2,tile=65536x65536,scale=1024x1024 -f framecrc 
> -
> 
> hangs instead of returning a proper error.
> 

In case there is confusion with what Paul said: `ffmpeg -lavfi
testsrc2=s=2x2 -f framecrc -` hangs with current git/master, so the hang
you're reporting is likely unrelated to this patch. Instead, it looks like a
problem related to the 2x2 size being too small for testsrc2 (testsrc
supports 2x2, testsrc2 doesn't).

(Not saying the current patch is correct though)

-- 
Clément B.


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Paul B Mahol 
On 10/28/17, Nicolas George  wrote:
> Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a ecrit :
>> Why?
>
> Because it is wrong. I wrote the test case by looking at your changes
> and finding a flaw in them.

No, your test is flawed. I have no longer obligations to communicate with you.

Simply said, testsrc2 hangs on its own, and its not tile flaw, or my patch.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Nicolas George 
Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a écrit :
> Why?

Because it is wrong. I wrote the test case by looking at your changes
and finding a flaw in them.

-- 
  Nicolas George


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Paul B Mahol 
On 10/28/17, Nicolas George  wrote:
> Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a ecrit :
>> testsrc2 hangs here.
>
> So please rework your patch.

Why? When it hangs without using tile filter at all.

Do I need to write things out of blue moon now?
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Nicolas George 
Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a écrit :
> testsrc2 hangs here.

So please rework your patch.

Regards,

-- 
  Nicolas George


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Paul B Mahol 
On 10/27/17, Nicolas George  wrote:
> Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a ecrit :
>> Signed-off-by: Paul B Mahol 
>> ---
>>  libavfilter/vf_tile.c | 8 
>>  1 file changed, 8 deletions(-)
>
> Nack.
>
> ./ffmpeg_g -lavfi testsrc2=s=2x2,tile=65536x65536,scale=1024x1024 -f
> framecrc -
>
> hangs instead of returning a proper error.

testsrc2 hangs here.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-27 Thread Nicolas George 
Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a écrit :
> Signed-off-by: Paul B Mahol 
> ---
>  libavfilter/vf_tile.c | 8 
>  1 file changed, 8 deletions(-)

Nack.

./ffmpeg_g -lavfi testsrc2=s=2x2,tile=65536x65536,scale=1024x1024 -f framecrc -

hangs instead of returning a proper error.

Regards,

-- 
  Nicolas George


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-27 Thread Paul B Mahol 
On 10/27/17, Nicolas George  wrote:
> Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a ecrit :
>> Signed-off-by: Paul B Mahol 
>> ---
>>  libavfilter/vf_tile.c | 12 ++--
>>  1 file changed, 2 insertions(+), 10 deletions(-)
>
> Nack.
>
> This:
>
> ./ffmpeg_g -lavfi testsrc2=s=1024x32,tile=layout=65x1 -f framecrc -
>
> used to work, and no longer does with: "Total width 65x1024 is too
> much."

That is insane.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-27 Thread Nicolas George 
Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a écrit :
> Signed-off-by: Paul B Mahol 
> ---
>  libavfilter/vf_tile.c | 12 ++--
>  1 file changed, 2 insertions(+), 10 deletions(-)

Nack.

This:

./ffmpeg_g -lavfi testsrc2=s=1024x32,tile=layout=65x1 -f framecrc -

used to work, and no longer does with: "Total width 65x1024 is too
much."

Regards,

-- 
  Nicolas George


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel