Re: [FFmpeg-devel] [PATCH] avfilter/video: pick sar from link

2017-12-10 Thread Paul B Mahol
On 12/10/17, Nicolas George wrote: > Paul B Mahol (2017-12-10): >> See vf_aspect.c, it changes inlink parameters. >> >> This patch is required for example if one change sar of first input >> and that value is not propagated to next links. > > I had not noticed that. The code in

Re: [FFmpeg-devel] [PATCH] avfilter/video: pick sar from link

2017-12-10 Thread Nicolas George
Paul B Mahol (2017-12-10): > See vf_aspect.c, it changes inlink parameters. > > This patch is required for example if one change sar of first input > and that value is not propagated to next links. I had not noticed that. The code in vf_aspect.c looks invalid to me, I think the change should be

Re: [FFmpeg-devel] [PATCH] avfilter/video: pick sar from link

2017-12-10 Thread Paul B Mahol
On 12/10/17, Nicolas George wrote: > Paul B Mahol (2017-12-10): >> > "May need" is not always a good way of designing changes. It would be >> > much better if you actually changed these filters at the same time to >> > use it. That way you can be more sure that you did not mess

Re: [FFmpeg-devel] [PATCH] avfilter/video: pick sar from link

2017-12-10 Thread Nicolas George
Paul B Mahol (2017-12-10): > > "May need" is not always a good way of designing changes. It would be > > much better if you actually changed these filters at the same time to > > use it. That way you can be more sure that you did not mess things up in > > a subtle way. > Is changing inlink

Re: [FFmpeg-devel] [PATCH] avfilter/video: pick sar from link

2017-12-10 Thread Paul B Mahol
On 12/10/17, Nicolas George wrote: > Paul B Mahol (2017-12-09): >> No new patches require it, it is for case such stereo3d and setsar and >> bunch >> of others that may need to explicitly set sample aspect ratio to each >> frame. > > "May need" is not always a good way of

Re: [FFmpeg-devel] [PATCH] avfilter/video: pick sar from link

2017-12-10 Thread Nicolas George
Paul B Mahol (2017-12-09): > No new patches require it, it is for case such stereo3d and setsar and bunch > of others that may need to explicitly set sample aspect ratio to each frame. "May need" is not always a good way of designing changes. It would be much better if you actually changed these

Re: [FFmpeg-devel] [PATCH] avfilter/video: pick sar from link

2017-12-09 Thread Paul B Mahol
On 12/9/17, Nicolas George wrote: > Paul B Mahol (2017-12-09): >> >> It should not be needed for each filter that sets sample aspect ratio >> >> to set it explicitly also for each and every frame, instead that is >> >> automatically done in get_buffer call. >> > Is this message

Re: [FFmpeg-devel] [PATCH] avfilter/video: pick sar from link

2017-12-09 Thread Nicolas George
Paul B Mahol (2017-12-09): > >> It should not be needed for each filter that sets sample aspect ratio > >> to set it explicitly also for each and every frame, instead that is > >> automatically done in get_buffer call. > > Is this message ok? If yes then I will push this patch shortly. Ok,

Re: [FFmpeg-devel] [PATCH] avfilter/video: pick sar from link

2017-12-09 Thread Paul B Mahol
On 12/8/17, Paul B Mahol wrote: > On 12/7/17, Paul B Mahol wrote: >> On 12/7/17, Nicolas George wrote: >>> Paul B Mahol (2017-12-07): Signed-off-by: Paul B Mahol --- libavfilter/video.c | 9 - 1

Re: [FFmpeg-devel] [PATCH] avfilter/video: pick sar from link

2017-12-08 Thread Paul B Mahol
On 12/7/17, Paul B Mahol wrote: > On 12/7/17, Nicolas George wrote: >> Paul B Mahol (2017-12-07): >>> Signed-off-by: Paul B Mahol >>> --- >>> libavfilter/video.c | 9 - >>> 1 file changed, 8 insertions(+), 1 deletion(-) >> >> Please

Re: [FFmpeg-devel] [PATCH] avfilter/video: pick sar from link

2017-12-07 Thread Paul B Mahol
On 12/7/17, Nicolas George wrote: > Paul B Mahol (2017-12-07): >> Signed-off-by: Paul B Mahol >> --- >> libavfilter/video.c | 9 - >> 1 file changed, 8 insertions(+), 1 deletion(-) > > Please explain (in the commit message) why you think this patch is

Re: [FFmpeg-devel] [PATCH] avfilter/video: pick sar from link

2017-12-07 Thread Nicolas George
Paul B Mahol (2017-12-07): > Signed-off-by: Paul B Mahol > --- > libavfilter/video.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) Please explain (in the commit message) why you think this patch is needed. Regards, -- Nicolas George signature.asc