Re: [FFmpeg-devel] [PATCH] avfilter: add ssim filter

2015-06-24 Thread Ronald S. Bultje
Hi, On Wed, Jun 24, 2015 at 9:21 AM, Paul B Mahol one...@gmail.com wrote: Signed-off-by: Paul B Mahol one...@gmail.com --- Changelog| 1 + doc/filters.texi | 58 +++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_ssim.c

Re: [FFmpeg-devel] [PATCH] avfilter: add ssim filter

2015-06-23 Thread Paul B Mahol
On 6/23/15, Nicolas George geo...@nsup.org wrote: Le quintidi 5 messidor, an CCXXIII, Paul B Mahol a ecrit : Looks like there are no new comments so I can safely assume current state as is is good enough. If you want to be really safe, you can observe that there is an unanswered question and

Re: [FFmpeg-devel] [PATCH] avfilter: add ssim filter

2015-06-23 Thread Ronald S. Bultje
Hi, On Tue, Jun 23, 2015 at 10:42 AM, Paul B Mahol one...@gmail.com wrote: On 6/22/15, Paul B Mahol one...@gmail.com wrote: On 6/22/15, Nicolas George geo...@nsup.org wrote: Le quartidi 4 messidor, an CCXXIII, Paul B Mahol a ecrit : Signed-off-by: Paul B Mahol one...@gmail.com ---

Re: [FFmpeg-devel] [PATCH] avfilter: add ssim filter

2015-06-23 Thread Nicolas George
Le quintidi 5 messidor, an CCXXIII, Paul B Mahol a écrit : Looks like there are no new comments so I can safely assume current state as is is good enough. If you want to be really safe, you can observe that there is an unanswered question and assume that 20 hours is not enough to be sure there

Re: [FFmpeg-devel] [PATCH] avfilter: add ssim filter

2015-06-23 Thread Ronald S. Bultje
Hi, On Tue, Jun 23, 2015 at 10:45 AM, Ronald S. Bultje rsbul...@gmail.com wrote: On Tue, Jun 23, 2015 at 10:42 AM, Paul B Mahol one...@gmail.com wrote: On 6/22/15, Paul B Mahol one...@gmail.com wrote: On 6/22/15, Nicolas George geo...@nsup.org wrote: Le quartidi 4 messidor, an CCXXIII,

Re: [FFmpeg-devel] [PATCH] avfilter: add ssim filter

2015-06-23 Thread Nicolas George
Le quintidi 5 messidor, an CCXXIII, Paul B Mahol a écrit : Well tiny_ssim computes PSNR from SSIM but numbers do not match other implementations. I'm sure that our MSE(and PSNR) calculations in vf_psnr.c matches numbers from some page linked from wikipedia. Computations of PSNR and SSIM

Re: [FFmpeg-devel] [PATCH] avfilter: add ssim filter

2015-06-23 Thread Paul B Mahol
On 6/22/15, Paul B Mahol one...@gmail.com wrote: On 6/22/15, Nicolas George geo...@nsup.org wrote: Le quartidi 4 messidor, an CCXXIII, Paul B Mahol a ecrit : Signed-off-by: Paul B Mahol one...@gmail.com --- Changelog| 1 + doc/filters.texi | 53

Re: [FFmpeg-devel] [PATCH] avfilter: add ssim filter

2015-06-23 Thread Paul B Mahol
On 6/23/15, Ronald S. Bultje rsbul...@gmail.com wrote: Hi, On Tue, Jun 23, 2015 at 10:45 AM, Ronald S. Bultje rsbul...@gmail.com wrote: On Tue, Jun 23, 2015 at 10:42 AM, Paul B Mahol one...@gmail.com wrote: On 6/22/15, Paul B Mahol one...@gmail.com wrote: On 6/22/15, Nicolas George

Re: [FFmpeg-devel] [PATCH] avfilter: add ssim filter

2015-06-22 Thread Ronald S. Bultje
Hi, On Mon, Jun 22, 2015 at 12:23 PM, Paul B Mahol one...@gmail.com wrote: +c[0] = ssim(main-data[0], main-linesize[0], +ref-data[0], ref-linesize[0], +s-planewidth[0], s-planeheight[0]); + +c[1] = ssim(main-data[1], main-linesize[1], +

Re: [FFmpeg-devel] [PATCH] avfilter: add ssim filter

2015-06-22 Thread Paul B Mahol
On 6/22/15, Nicolas George geo...@nsup.org wrote: Le quartidi 4 messidor, an CCXXIII, Paul B Mahol a ecrit : Signed-off-by: Paul B Mahol one...@gmail.com --- Changelog| 1 + doc/filters.texi | 53 libavfilter/Makefile | 1 +

Re: [FFmpeg-devel] [PATCH] avfilter: add ssim filter

2015-06-22 Thread Paul B Mahol
On 6/22/15, Ronald S. Bultje rsbul...@gmail.com wrote: Hi, On Mon, Jun 22, 2015 at 12:23 PM, Paul B Mahol one...@gmail.com wrote: +c[0] = ssim(main-data[0], main-linesize[0], +ref-data[0], ref-linesize[0], +s-planewidth[0], s-planeheight[0]); + +

Re: [FFmpeg-devel] [PATCH] avfilter: add ssim filter

2015-06-22 Thread Nicolas George
Le quartidi 4 messidor, an CCXXIII, Paul B Mahol a écrit : Signed-off-by: Paul B Mahol one...@gmail.com --- Changelog| 1 + doc/filters.texi | 53 libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_ssim.c| 340