Re: [FFmpeg-devel] [PATCH] avfilter: slice processing for geq

2018-01-04 Thread Michael Niedermayer
On Thu, Jan 04, 2018 at 07:52:17AM +, Marc-Antoine ARNAUD wrote:
> Sorry, I have upgrade and re-generate patches.

will apply
thanks

[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 1
"Used only once"- "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH] avfilter: slice processing for geq

2018-01-03 Thread Marc-Antoine ARNAUD
Sorry, I have upgrade and re-generate patches.


Le mer. 3 janv. 2018 à 23:47, Moritz Barsnick  a écrit :

> On Wed, Jan 03, 2018 at 12:51:06 +, Marc-Antoine ARNAUD wrote:
> >  Changelog   |   10 +
> >  MAINTAINERS |9 +-
> >  Makefile|9 +-
> >  compat/cuda/dynlink_loader.h|   18 +-
> >  compat/nvenc/nvEncodeAPI.h  |2 +-
> >  compat/tms470/math.h|   30 -
> >  compat/w32dlfcn.h   |1 +
> >  compat/windows/makedef  |   41 +-
> >  configure   |  649 ++-
> >  doc/APIchanges  |3 +
> >  doc/codecs.texi |8 -
> >  doc/encoders.texi   |2 +
> >  doc/ffmpeg.texi |4 +-
> >  doc/filters.texi|   73 +-
> >  doc/general.texi|5 +
> >  doc/indevs.texi |2 +
> >  doc/libav-merge.txt |1 +
> >  doc/muxers.texi |   72 +-
> >  doc/protocols.texi  |9 +
> >  ffbuild/common.mak  |3 +-
> >  ffbuild/library.mak |   14 +-
> >  fftools/cmdutils.h  |1 +
> >  fftools/ffmpeg.c|   56 +-
> >  fftools/ffmpeg.h|1 +
> >  fftools/ffmpeg_filter.c |1 +
> >  fftools/ffmpeg_opt.c|   27 +-
> >  fftools/ffplay.c|  102 +-
> >  fftools/ffprobe.c   |2 +-
> >  libavcodec/Makefile |   24 +-
> >  libavcodec/aacdec_fixed.c   |2 +-
> >  libavcodec/aacenc.c |   87 +-
> >  libavcodec/aacenc.h |  286 +-
> >  libavcodec/aacenctab.h  |   13 +-
> >  libavcodec/aacpsdsp_template.c  |8 +-
> >  libavcodec/aacsbr_fixed.c   |1 +
> >  libavcodec/aarch64/mpegaudiodsp_neon.S  |4 +-
> >  libavcodec/ac3tab.h |3 +-
>
> No, this looks totally wrong. You didn't provide a patch of your
> commit, but a diff against a very much old version of the tree.
>
> Moritz
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>


0002-avfilter-slice-processing-for-geq.patch
Description: Binary data


0003-avfilter-rename-variables-in-geq.patch
Description: Binary data


0001-avfilter-reorder-variable-definition-in-geq.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH] avfilter: slice processing for geq

2018-01-03 Thread Moritz Barsnick
On Wed, Jan 03, 2018 at 12:51:06 +, Marc-Antoine ARNAUD wrote:
>  Changelog   |   10 +
>  MAINTAINERS |9 +-
>  Makefile|9 +-
>  compat/cuda/dynlink_loader.h|   18 +-
>  compat/nvenc/nvEncodeAPI.h  |2 +-
>  compat/tms470/math.h|   30 -
>  compat/w32dlfcn.h   |1 +
>  compat/windows/makedef  |   41 +-
>  configure   |  649 ++-
>  doc/APIchanges  |3 +
>  doc/codecs.texi |8 -
>  doc/encoders.texi   |2 +
>  doc/ffmpeg.texi |4 +-
>  doc/filters.texi|   73 +-
>  doc/general.texi|5 +
>  doc/indevs.texi |2 +
>  doc/libav-merge.txt |1 +
>  doc/muxers.texi |   72 +-
>  doc/protocols.texi  |9 +
>  ffbuild/common.mak  |3 +-
>  ffbuild/library.mak |   14 +-
>  fftools/cmdutils.h  |1 +
>  fftools/ffmpeg.c|   56 +-
>  fftools/ffmpeg.h|1 +
>  fftools/ffmpeg_filter.c |1 +
>  fftools/ffmpeg_opt.c|   27 +-
>  fftools/ffplay.c|  102 +-
>  fftools/ffprobe.c   |2 +-
>  libavcodec/Makefile |   24 +-
>  libavcodec/aacdec_fixed.c   |2 +-
>  libavcodec/aacenc.c |   87 +-
>  libavcodec/aacenc.h |  286 +-
>  libavcodec/aacenctab.h  |   13 +-
>  libavcodec/aacpsdsp_template.c  |8 +-
>  libavcodec/aacsbr_fixed.c   |1 +
>  libavcodec/aarch64/mpegaudiodsp_neon.S  |4 +-
>  libavcodec/ac3tab.h |3 +-

No, this looks totally wrong. You didn't provide a patch of your
commit, but a diff against a very much old version of the tree.

Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH] avfilter: slice processing for geq

2017-11-30 Thread Michael Niedermayer
On Thu, Nov 30, 2017 at 01:35:52PM +, Marc-Antoine ARNAUD wrote:
> Le jeu. 30 nov. 2017 à 01:51, Michael Niedermayer 
> a écrit :
> 
> > On Wed, Nov 29, 2017 at 11:28:40AM +, Marc-Antoine ARNAUD wrote:
> > > Le mer. 22 nov. 2017 à 17:54, Michael Niedermayer  > >
> > > a écrit :
> > >
> > > > On Wed, Nov 22, 2017 at 10:24:30AM +, Marc-Antoine ARNAUD wrote:
> > > > > New patch version which fixe the last remark.
> > > > >
> > > > >
> > > > > Le ven. 10 nov. 2017 à 00:47, Michael Niedermayer
> >  > > > >
> > > > > a écrit :
> > > > >
> > > > > > On Thu, Nov 09, 2017 at 10:22:23AM +, Marc-Antoine ARNAUD
> > wrote:
> > > > > > > Please find the merged patch in attachement.
> > > > > > >
> > > > > > > Thanks
> > > > > > >
> > > > > > > Le mer. 8 nov. 2017 à 17:12, Paul B Mahol  a
> > > > écrit :
> > > > > > >
> > > > > > > > On 11/8/17, Marc-Antoine ARNAUD 
> > > > wrote:
> > > > > > > > > This patch will fix the stride issue.
> > > > > > > > > Is it valid for you ?
> > > > > > > > >
> > > > > > > > > Does it required to merge these 2 patches ? (and remove
> > base64
> > > > > > encoding
> > > > > > > > on
> > > > > > > > > the first one)
> > > > > > > >
> > > > > > > > Please merge those two patches, base64 encoding should not be
> > > > needed
> > > > > > > > (it helps to faster review patches if they are not encoded).
> > > > > > > > ___
> > > > > > > > ffmpeg-devel mailing list
> > > > > > > > ffmpeg-devel@ffmpeg.org
> > > > > > > > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > > > > > > >
> > > > > >
> > > > > > >  vf_geq.c |  124
> > > > > > +--
> > > > > > >  1 file changed, 90 insertions(+), 34 deletions(-)
> > > > > > > b41a90fffb5ddef553661007a38659c602f7ce56
> > > > > > 0001-avfilter-slice-processing-for-geq.patch
> > > > > > > From ac2a6322fa96835e02a24c31f014fb360e26561f Mon Sep 17 00:00:00
> > > > 2001
> > > > > > > From: Marc-Antoine Arnaud 
> > > > > > > Date: Thu, 9 Nov 2017 11:19:43 +0100
> > > > > > > Subject: [PATCH] avfilter: slice processing for geq
> > > > > > > Content-Type: text/x-patch; charset="utf-8"
> > > > > >
> > > > > > crashes:
> > > > > > ./ffmpeg_g -f lavfi -i
> > > > > >
> > > >
> > 'nullsrc=s=200x200,format=yuv444p16,geq=X*Y/10:sin(X/10)*255:cos(Y/10)*255'
> > > > > > -vframes 5 -y blah.avi
> > > > > >
> > > > > > ==24616== Thread 7:
> > > > > > ==24616== Invalid write of size 2
> > > > > > ==24616==at 0x4F3AAF: slice_geq_filter (vf_geq.c:289)
> > > > > > ==24616==by 0x48E4C9: worker_func (pthread.c:50)
> > > > > > ==24616==by 0x11DB932: run_jobs (slicethread.c:61)
> > > > > > ==24616==by 0x11DBA04: thread_worker (slicethread.c:85)
> > > > > > ==24616==by 0xC45D183: start_thread (pthread_create.c:312)
> > > > > > ==24616==by 0xC770FFC: clone (clone.S:111)
> > > > > > ==24616==  Address 0x1177143e is 93,214 bytes inside a block of
> > size
> > > > > > 93,215 alloc'd
> > > > > > ==24616==at 0x4C2A6C5: memalign (vg_replace_malloc.c:727)
> > > > > > ==24616==by 0x4C2A760: posix_memalign (vg_replace_malloc.c:876)
> > > > > > ==24616==by 0x11B0C43: av_malloc (mem.c:87)
> > > > > > ==24616==by 0x11987CC: av_buffer_alloc (buffer.c:72)
> > > > > > ==24616==by 0x1198831: av_buffer_allocz (buffer.c:85)
> > > > > > ==24616==by 0x1198F29: pool_alloc_buffer (buffer.c:312)
> > > > > > ==24616==by 0x1199057: av_buffer_pool_get (buffer.c:349)
> > > > > > ==24616==by 0x489D6D: ff_frame_pool_get (framepool.c:222)
> > > > > > ==24616==by 0x58F6EB: ff_default_get_video_buffer (video.c:89)
> > > > > > ==24616==by 0x58F768: ff_get_video_buffer (video.c:102)
> > > > > > ==24616==by 0x4F3BF3: geq_filter_frame (vf_geq.c:312)
> > > > > > ==24616==by 0x472FD0: ff_filter_frame_framed (avfilter.c:1104)
> > > > > > ==24616==by 0x473800: ff_filter_frame_to_filter
> > (avfilter.c:1252)
> > > > > > ==24616==by 0x4739F8: ff_filter_activate_default
> > (avfilter.c:1301)
> > > > > > ==24616==by 0x473C12: ff_filter_activate (avfilter.c:1462)
> > > > > > ==24616==by 0x478A4F: ff_filter_graph_run_once
> > > > (avfiltergraph.c:1456)
> > > > > > ==24616==by 0x478C72: get_frame_internal (buffersink.c:110)
> > > > > > ==24616==by 0x478CCF: av_buffersink_get_frame_flags
> > > > (buffersink.c:121)
> > > > > > ==24616==by 0x441808: lavfi_read_packet (lavfi.c:410)
> > > > > > ==24616==by 0x7AC315: ff_read_packet (utils.c:822)
> > > > > > ==24616==
> > > > > > --24616-- VALGRIND INTERNAL ERROR: Valgrind received a signal 11
> > > > (SIGSEGV)
> > > > > > - exiting
> > > > > > --24616-- si_code=80;  Faulting address: 0x0;  sp: 0x40a075db0
> > > > > >
> > > > > > [...]
> > > > > >
> > > > > > --
> > > > > > Michael GnuPG fingerprint:
> > 

Re: [FFmpeg-devel] [PATCH] avfilter: slice processing for geq

2017-11-30 Thread Marc-Antoine ARNAUD
Le jeu. 30 nov. 2017 à 01:51, Michael Niedermayer 
a écrit :

> On Wed, Nov 29, 2017 at 11:28:40AM +, Marc-Antoine ARNAUD wrote:
> > Le mer. 22 nov. 2017 à 17:54, Michael Niedermayer  >
> > a écrit :
> >
> > > On Wed, Nov 22, 2017 at 10:24:30AM +, Marc-Antoine ARNAUD wrote:
> > > > New patch version which fixe the last remark.
> > > >
> > > >
> > > > Le ven. 10 nov. 2017 à 00:47, Michael Niedermayer
>  > > >
> > > > a écrit :
> > > >
> > > > > On Thu, Nov 09, 2017 at 10:22:23AM +, Marc-Antoine ARNAUD
> wrote:
> > > > > > Please find the merged patch in attachement.
> > > > > >
> > > > > > Thanks
> > > > > >
> > > > > > Le mer. 8 nov. 2017 à 17:12, Paul B Mahol  a
> > > écrit :
> > > > > >
> > > > > > > On 11/8/17, Marc-Antoine ARNAUD 
> > > wrote:
> > > > > > > > This patch will fix the stride issue.
> > > > > > > > Is it valid for you ?
> > > > > > > >
> > > > > > > > Does it required to merge these 2 patches ? (and remove
> base64
> > > > > encoding
> > > > > > > on
> > > > > > > > the first one)
> > > > > > >
> > > > > > > Please merge those two patches, base64 encoding should not be
> > > needed
> > > > > > > (it helps to faster review patches if they are not encoded).
> > > > > > > ___
> > > > > > > ffmpeg-devel mailing list
> > > > > > > ffmpeg-devel@ffmpeg.org
> > > > > > > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > > > > > >
> > > > >
> > > > > >  vf_geq.c |  124
> > > > > +--
> > > > > >  1 file changed, 90 insertions(+), 34 deletions(-)
> > > > > > b41a90fffb5ddef553661007a38659c602f7ce56
> > > > > 0001-avfilter-slice-processing-for-geq.patch
> > > > > > From ac2a6322fa96835e02a24c31f014fb360e26561f Mon Sep 17 00:00:00
> > > 2001
> > > > > > From: Marc-Antoine Arnaud 
> > > > > > Date: Thu, 9 Nov 2017 11:19:43 +0100
> > > > > > Subject: [PATCH] avfilter: slice processing for geq
> > > > > > Content-Type: text/x-patch; charset="utf-8"
> > > > >
> > > > > crashes:
> > > > > ./ffmpeg_g -f lavfi -i
> > > > >
> > >
> 'nullsrc=s=200x200,format=yuv444p16,geq=X*Y/10:sin(X/10)*255:cos(Y/10)*255'
> > > > > -vframes 5 -y blah.avi
> > > > >
> > > > > ==24616== Thread 7:
> > > > > ==24616== Invalid write of size 2
> > > > > ==24616==at 0x4F3AAF: slice_geq_filter (vf_geq.c:289)
> > > > > ==24616==by 0x48E4C9: worker_func (pthread.c:50)
> > > > > ==24616==by 0x11DB932: run_jobs (slicethread.c:61)
> > > > > ==24616==by 0x11DBA04: thread_worker (slicethread.c:85)
> > > > > ==24616==by 0xC45D183: start_thread (pthread_create.c:312)
> > > > > ==24616==by 0xC770FFC: clone (clone.S:111)
> > > > > ==24616==  Address 0x1177143e is 93,214 bytes inside a block of
> size
> > > > > 93,215 alloc'd
> > > > > ==24616==at 0x4C2A6C5: memalign (vg_replace_malloc.c:727)
> > > > > ==24616==by 0x4C2A760: posix_memalign (vg_replace_malloc.c:876)
> > > > > ==24616==by 0x11B0C43: av_malloc (mem.c:87)
> > > > > ==24616==by 0x11987CC: av_buffer_alloc (buffer.c:72)
> > > > > ==24616==by 0x1198831: av_buffer_allocz (buffer.c:85)
> > > > > ==24616==by 0x1198F29: pool_alloc_buffer (buffer.c:312)
> > > > > ==24616==by 0x1199057: av_buffer_pool_get (buffer.c:349)
> > > > > ==24616==by 0x489D6D: ff_frame_pool_get (framepool.c:222)
> > > > > ==24616==by 0x58F6EB: ff_default_get_video_buffer (video.c:89)
> > > > > ==24616==by 0x58F768: ff_get_video_buffer (video.c:102)
> > > > > ==24616==by 0x4F3BF3: geq_filter_frame (vf_geq.c:312)
> > > > > ==24616==by 0x472FD0: ff_filter_frame_framed (avfilter.c:1104)
> > > > > ==24616==by 0x473800: ff_filter_frame_to_filter
> (avfilter.c:1252)
> > > > > ==24616==by 0x4739F8: ff_filter_activate_default
> (avfilter.c:1301)
> > > > > ==24616==by 0x473C12: ff_filter_activate (avfilter.c:1462)
> > > > > ==24616==by 0x478A4F: ff_filter_graph_run_once
> > > (avfiltergraph.c:1456)
> > > > > ==24616==by 0x478C72: get_frame_internal (buffersink.c:110)
> > > > > ==24616==by 0x478CCF: av_buffersink_get_frame_flags
> > > (buffersink.c:121)
> > > > > ==24616==by 0x441808: lavfi_read_packet (lavfi.c:410)
> > > > > ==24616==by 0x7AC315: ff_read_packet (utils.c:822)
> > > > > ==24616==
> > > > > --24616-- VALGRIND INTERNAL ERROR: Valgrind received a signal 11
> > > (SIGSEGV)
> > > > > - exiting
> > > > > --24616-- si_code=80;  Faulting address: 0x0;  sp: 0x40a075db0
> > > > >
> > > > > [...]
> > > > >
> > > > > --
> > > > > Michael GnuPG fingerprint:
> 9FF2128B147EF6730BADF133611EC787040B0FAB
> > > > >
> > > > > While the State exists there can be no freedom; when there is
> freedom
> > > there
> > > > > will be no State. -- Vladimir Lenin
> > > > > ___
> > > > > ffmpeg-devel mailing list
> > > > > 

Re: [FFmpeg-devel] [PATCH] avfilter: slice processing for geq

2017-11-29 Thread Michael Niedermayer
On Wed, Nov 29, 2017 at 11:28:40AM +, Marc-Antoine ARNAUD wrote:
> Le mer. 22 nov. 2017 à 17:54, Michael Niedermayer 
> a écrit :
> 
> > On Wed, Nov 22, 2017 at 10:24:30AM +, Marc-Antoine ARNAUD wrote:
> > > New patch version which fixe the last remark.
> > >
> > >
> > > Le ven. 10 nov. 2017 à 00:47, Michael Niedermayer  > >
> > > a écrit :
> > >
> > > > On Thu, Nov 09, 2017 at 10:22:23AM +, Marc-Antoine ARNAUD wrote:
> > > > > Please find the merged patch in attachement.
> > > > >
> > > > > Thanks
> > > > >
> > > > > Le mer. 8 nov. 2017 à 17:12, Paul B Mahol  a
> > écrit :
> > > > >
> > > > > > On 11/8/17, Marc-Antoine ARNAUD 
> > wrote:
> > > > > > > This patch will fix the stride issue.
> > > > > > > Is it valid for you ?
> > > > > > >
> > > > > > > Does it required to merge these 2 patches ? (and remove base64
> > > > encoding
> > > > > > on
> > > > > > > the first one)
> > > > > >
> > > > > > Please merge those two patches, base64 encoding should not be
> > needed
> > > > > > (it helps to faster review patches if they are not encoded).
> > > > > > ___
> > > > > > ffmpeg-devel mailing list
> > > > > > ffmpeg-devel@ffmpeg.org
> > > > > > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > > > > >
> > > >
> > > > >  vf_geq.c |  124
> > > > +--
> > > > >  1 file changed, 90 insertions(+), 34 deletions(-)
> > > > > b41a90fffb5ddef553661007a38659c602f7ce56
> > > > 0001-avfilter-slice-processing-for-geq.patch
> > > > > From ac2a6322fa96835e02a24c31f014fb360e26561f Mon Sep 17 00:00:00
> > 2001
> > > > > From: Marc-Antoine Arnaud 
> > > > > Date: Thu, 9 Nov 2017 11:19:43 +0100
> > > > > Subject: [PATCH] avfilter: slice processing for geq
> > > > > Content-Type: text/x-patch; charset="utf-8"
> > > >
> > > > crashes:
> > > > ./ffmpeg_g -f lavfi -i
> > > >
> > 'nullsrc=s=200x200,format=yuv444p16,geq=X*Y/10:sin(X/10)*255:cos(Y/10)*255'
> > > > -vframes 5 -y blah.avi
> > > >
> > > > ==24616== Thread 7:
> > > > ==24616== Invalid write of size 2
> > > > ==24616==at 0x4F3AAF: slice_geq_filter (vf_geq.c:289)
> > > > ==24616==by 0x48E4C9: worker_func (pthread.c:50)
> > > > ==24616==by 0x11DB932: run_jobs (slicethread.c:61)
> > > > ==24616==by 0x11DBA04: thread_worker (slicethread.c:85)
> > > > ==24616==by 0xC45D183: start_thread (pthread_create.c:312)
> > > > ==24616==by 0xC770FFC: clone (clone.S:111)
> > > > ==24616==  Address 0x1177143e is 93,214 bytes inside a block of size
> > > > 93,215 alloc'd
> > > > ==24616==at 0x4C2A6C5: memalign (vg_replace_malloc.c:727)
> > > > ==24616==by 0x4C2A760: posix_memalign (vg_replace_malloc.c:876)
> > > > ==24616==by 0x11B0C43: av_malloc (mem.c:87)
> > > > ==24616==by 0x11987CC: av_buffer_alloc (buffer.c:72)
> > > > ==24616==by 0x1198831: av_buffer_allocz (buffer.c:85)
> > > > ==24616==by 0x1198F29: pool_alloc_buffer (buffer.c:312)
> > > > ==24616==by 0x1199057: av_buffer_pool_get (buffer.c:349)
> > > > ==24616==by 0x489D6D: ff_frame_pool_get (framepool.c:222)
> > > > ==24616==by 0x58F6EB: ff_default_get_video_buffer (video.c:89)
> > > > ==24616==by 0x58F768: ff_get_video_buffer (video.c:102)
> > > > ==24616==by 0x4F3BF3: geq_filter_frame (vf_geq.c:312)
> > > > ==24616==by 0x472FD0: ff_filter_frame_framed (avfilter.c:1104)
> > > > ==24616==by 0x473800: ff_filter_frame_to_filter (avfilter.c:1252)
> > > > ==24616==by 0x4739F8: ff_filter_activate_default (avfilter.c:1301)
> > > > ==24616==by 0x473C12: ff_filter_activate (avfilter.c:1462)
> > > > ==24616==by 0x478A4F: ff_filter_graph_run_once
> > (avfiltergraph.c:1456)
> > > > ==24616==by 0x478C72: get_frame_internal (buffersink.c:110)
> > > > ==24616==by 0x478CCF: av_buffersink_get_frame_flags
> > (buffersink.c:121)
> > > > ==24616==by 0x441808: lavfi_read_packet (lavfi.c:410)
> > > > ==24616==by 0x7AC315: ff_read_packet (utils.c:822)
> > > > ==24616==
> > > > --24616-- VALGRIND INTERNAL ERROR: Valgrind received a signal 11
> > (SIGSEGV)
> > > > - exiting
> > > > --24616-- si_code=80;  Faulting address: 0x0;  sp: 0x40a075db0
> > > >
> > > > [...]
> > > >
> > > > --
> > > > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> > > >
> > > > While the State exists there can be no freedom; when there is freedom
> > there
> > > > will be no State. -- Vladimir Lenin
> > > > ___
> > > > ffmpeg-devel mailing list
> > > > ffmpeg-devel@ffmpeg.org
> > > > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > > >
> >
> > >  vf_geq.c |  130
> > +++
> > >  1 file changed, 90 insertions(+), 40 deletions(-)
> > > abe75c0a0cf89605006905c0c58c0600d26fadb6
> > 

Re: [FFmpeg-devel] [PATCH] avfilter: slice processing for geq

2017-11-29 Thread Marc-Antoine ARNAUD
Le mer. 22 nov. 2017 à 17:54, Michael Niedermayer 
a écrit :

> On Wed, Nov 22, 2017 at 10:24:30AM +, Marc-Antoine ARNAUD wrote:
> > New patch version which fixe the last remark.
> >
> >
> > Le ven. 10 nov. 2017 à 00:47, Michael Niedermayer  >
> > a écrit :
> >
> > > On Thu, Nov 09, 2017 at 10:22:23AM +, Marc-Antoine ARNAUD wrote:
> > > > Please find the merged patch in attachement.
> > > >
> > > > Thanks
> > > >
> > > > Le mer. 8 nov. 2017 à 17:12, Paul B Mahol  a
> écrit :
> > > >
> > > > > On 11/8/17, Marc-Antoine ARNAUD 
> wrote:
> > > > > > This patch will fix the stride issue.
> > > > > > Is it valid for you ?
> > > > > >
> > > > > > Does it required to merge these 2 patches ? (and remove base64
> > > encoding
> > > > > on
> > > > > > the first one)
> > > > >
> > > > > Please merge those two patches, base64 encoding should not be
> needed
> > > > > (it helps to faster review patches if they are not encoded).
> > > > > ___
> > > > > ffmpeg-devel mailing list
> > > > > ffmpeg-devel@ffmpeg.org
> > > > > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > > > >
> > >
> > > >  vf_geq.c |  124
> > > +--
> > > >  1 file changed, 90 insertions(+), 34 deletions(-)
> > > > b41a90fffb5ddef553661007a38659c602f7ce56
> > > 0001-avfilter-slice-processing-for-geq.patch
> > > > From ac2a6322fa96835e02a24c31f014fb360e26561f Mon Sep 17 00:00:00
> 2001
> > > > From: Marc-Antoine Arnaud 
> > > > Date: Thu, 9 Nov 2017 11:19:43 +0100
> > > > Subject: [PATCH] avfilter: slice processing for geq
> > > > Content-Type: text/x-patch; charset="utf-8"
> > >
> > > crashes:
> > > ./ffmpeg_g -f lavfi -i
> > >
> 'nullsrc=s=200x200,format=yuv444p16,geq=X*Y/10:sin(X/10)*255:cos(Y/10)*255'
> > > -vframes 5 -y blah.avi
> > >
> > > ==24616== Thread 7:
> > > ==24616== Invalid write of size 2
> > > ==24616==at 0x4F3AAF: slice_geq_filter (vf_geq.c:289)
> > > ==24616==by 0x48E4C9: worker_func (pthread.c:50)
> > > ==24616==by 0x11DB932: run_jobs (slicethread.c:61)
> > > ==24616==by 0x11DBA04: thread_worker (slicethread.c:85)
> > > ==24616==by 0xC45D183: start_thread (pthread_create.c:312)
> > > ==24616==by 0xC770FFC: clone (clone.S:111)
> > > ==24616==  Address 0x1177143e is 93,214 bytes inside a block of size
> > > 93,215 alloc'd
> > > ==24616==at 0x4C2A6C5: memalign (vg_replace_malloc.c:727)
> > > ==24616==by 0x4C2A760: posix_memalign (vg_replace_malloc.c:876)
> > > ==24616==by 0x11B0C43: av_malloc (mem.c:87)
> > > ==24616==by 0x11987CC: av_buffer_alloc (buffer.c:72)
> > > ==24616==by 0x1198831: av_buffer_allocz (buffer.c:85)
> > > ==24616==by 0x1198F29: pool_alloc_buffer (buffer.c:312)
> > > ==24616==by 0x1199057: av_buffer_pool_get (buffer.c:349)
> > > ==24616==by 0x489D6D: ff_frame_pool_get (framepool.c:222)
> > > ==24616==by 0x58F6EB: ff_default_get_video_buffer (video.c:89)
> > > ==24616==by 0x58F768: ff_get_video_buffer (video.c:102)
> > > ==24616==by 0x4F3BF3: geq_filter_frame (vf_geq.c:312)
> > > ==24616==by 0x472FD0: ff_filter_frame_framed (avfilter.c:1104)
> > > ==24616==by 0x473800: ff_filter_frame_to_filter (avfilter.c:1252)
> > > ==24616==by 0x4739F8: ff_filter_activate_default (avfilter.c:1301)
> > > ==24616==by 0x473C12: ff_filter_activate (avfilter.c:1462)
> > > ==24616==by 0x478A4F: ff_filter_graph_run_once
> (avfiltergraph.c:1456)
> > > ==24616==by 0x478C72: get_frame_internal (buffersink.c:110)
> > > ==24616==by 0x478CCF: av_buffersink_get_frame_flags
> (buffersink.c:121)
> > > ==24616==by 0x441808: lavfi_read_packet (lavfi.c:410)
> > > ==24616==by 0x7AC315: ff_read_packet (utils.c:822)
> > > ==24616==
> > > --24616-- VALGRIND INTERNAL ERROR: Valgrind received a signal 11
> (SIGSEGV)
> > > - exiting
> > > --24616-- si_code=80;  Faulting address: 0x0;  sp: 0x40a075db0
> > >
> > > [...]
> > >
> > > --
> > > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> > >
> > > While the State exists there can be no freedom; when there is freedom
> there
> > > will be no State. -- Vladimir Lenin
> > > ___
> > > ffmpeg-devel mailing list
> > > ffmpeg-devel@ffmpeg.org
> > > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > >
>
> >  vf_geq.c |  130
> +++
> >  1 file changed, 90 insertions(+), 40 deletions(-)
> > abe75c0a0cf89605006905c0c58c0600d26fadb6
> 0001-avfilter-slice-processing-for-geq.patch
> > From 7ac2a8c41aaf69ec6cacf7460fa170fd4ca52d8f Mon Sep 17 00:00:00 2001
> > From: Marc-Antoine Arnaud 
> > Date: Wed, 22 Nov 2017 11:21:35 +0100
> > Subject: [PATCH 1/1] avfilter: slice processing for geq
> > Content-Type: text/x-patch; 

Re: [FFmpeg-devel] [PATCH] avfilter: slice processing for geq

2017-11-22 Thread Michael Niedermayer
On Wed, Nov 22, 2017 at 10:24:30AM +, Marc-Antoine ARNAUD wrote:
> New patch version which fixe the last remark.
> 
> 
> Le ven. 10 nov. 2017 à 00:47, Michael Niedermayer 
> a écrit :
> 
> > On Thu, Nov 09, 2017 at 10:22:23AM +, Marc-Antoine ARNAUD wrote:
> > > Please find the merged patch in attachement.
> > >
> > > Thanks
> > >
> > > Le mer. 8 nov. 2017 à 17:12, Paul B Mahol  a écrit :
> > >
> > > > On 11/8/17, Marc-Antoine ARNAUD  wrote:
> > > > > This patch will fix the stride issue.
> > > > > Is it valid for you ?
> > > > >
> > > > > Does it required to merge these 2 patches ? (and remove base64
> > encoding
> > > > on
> > > > > the first one)
> > > >
> > > > Please merge those two patches, base64 encoding should not be needed
> > > > (it helps to faster review patches if they are not encoded).
> > > > ___
> > > > ffmpeg-devel mailing list
> > > > ffmpeg-devel@ffmpeg.org
> > > > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > > >
> >
> > >  vf_geq.c |  124
> > +--
> > >  1 file changed, 90 insertions(+), 34 deletions(-)
> > > b41a90fffb5ddef553661007a38659c602f7ce56
> > 0001-avfilter-slice-processing-for-geq.patch
> > > From ac2a6322fa96835e02a24c31f014fb360e26561f Mon Sep 17 00:00:00 2001
> > > From: Marc-Antoine Arnaud 
> > > Date: Thu, 9 Nov 2017 11:19:43 +0100
> > > Subject: [PATCH] avfilter: slice processing for geq
> > > Content-Type: text/x-patch; charset="utf-8"
> >
> > crashes:
> > ./ffmpeg_g -f lavfi -i
> > 'nullsrc=s=200x200,format=yuv444p16,geq=X*Y/10:sin(X/10)*255:cos(Y/10)*255'
> > -vframes 5 -y blah.avi
> >
> > ==24616== Thread 7:
> > ==24616== Invalid write of size 2
> > ==24616==at 0x4F3AAF: slice_geq_filter (vf_geq.c:289)
> > ==24616==by 0x48E4C9: worker_func (pthread.c:50)
> > ==24616==by 0x11DB932: run_jobs (slicethread.c:61)
> > ==24616==by 0x11DBA04: thread_worker (slicethread.c:85)
> > ==24616==by 0xC45D183: start_thread (pthread_create.c:312)
> > ==24616==by 0xC770FFC: clone (clone.S:111)
> > ==24616==  Address 0x1177143e is 93,214 bytes inside a block of size
> > 93,215 alloc'd
> > ==24616==at 0x4C2A6C5: memalign (vg_replace_malloc.c:727)
> > ==24616==by 0x4C2A760: posix_memalign (vg_replace_malloc.c:876)
> > ==24616==by 0x11B0C43: av_malloc (mem.c:87)
> > ==24616==by 0x11987CC: av_buffer_alloc (buffer.c:72)
> > ==24616==by 0x1198831: av_buffer_allocz (buffer.c:85)
> > ==24616==by 0x1198F29: pool_alloc_buffer (buffer.c:312)
> > ==24616==by 0x1199057: av_buffer_pool_get (buffer.c:349)
> > ==24616==by 0x489D6D: ff_frame_pool_get (framepool.c:222)
> > ==24616==by 0x58F6EB: ff_default_get_video_buffer (video.c:89)
> > ==24616==by 0x58F768: ff_get_video_buffer (video.c:102)
> > ==24616==by 0x4F3BF3: geq_filter_frame (vf_geq.c:312)
> > ==24616==by 0x472FD0: ff_filter_frame_framed (avfilter.c:1104)
> > ==24616==by 0x473800: ff_filter_frame_to_filter (avfilter.c:1252)
> > ==24616==by 0x4739F8: ff_filter_activate_default (avfilter.c:1301)
> > ==24616==by 0x473C12: ff_filter_activate (avfilter.c:1462)
> > ==24616==by 0x478A4F: ff_filter_graph_run_once (avfiltergraph.c:1456)
> > ==24616==by 0x478C72: get_frame_internal (buffersink.c:110)
> > ==24616==by 0x478CCF: av_buffersink_get_frame_flags (buffersink.c:121)
> > ==24616==by 0x441808: lavfi_read_packet (lavfi.c:410)
> > ==24616==by 0x7AC315: ff_read_packet (utils.c:822)
> > ==24616==
> > --24616-- VALGRIND INTERNAL ERROR: Valgrind received a signal 11 (SIGSEGV)
> > - exiting
> > --24616-- si_code=80;  Faulting address: 0x0;  sp: 0x40a075db0
> >
> > [...]
> >
> > --
> > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> >
> > While the State exists there can be no freedom; when there is freedom there
> > will be no State. -- Vladimir Lenin
> > ___
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >

>  vf_geq.c |  130 
> +++
>  1 file changed, 90 insertions(+), 40 deletions(-)
> abe75c0a0cf89605006905c0c58c0600d26fadb6  
> 0001-avfilter-slice-processing-for-geq.patch
> From 7ac2a8c41aaf69ec6cacf7460fa170fd4ca52d8f Mon Sep 17 00:00:00 2001
> From: Marc-Antoine Arnaud 
> Date: Wed, 22 Nov 2017 11:21:35 +0100
> Subject: [PATCH 1/1] avfilter: slice processing for geq
> Content-Type: text/x-patch; charset="utf-8"
> 
> ---
>  libavfilter/vf_geq.c | 130 
> +++
>  1 file changed, 90 insertions(+), 40 deletions(-)
> 
> diff --git a/libavfilter/vf_geq.c b/libavfilter/vf_geq.c
> index 36dbd421ce..09bc3d546e 100644
> --- a/libavfilter/vf_geq.c
> +++ 

Re: [FFmpeg-devel] [PATCH] avfilter: slice processing for geq

2017-11-22 Thread Derek Buitenhuis
On 11/22/2017 2:38 PM, Marc-Antoine ARNAUD wrote:
> It made sense, but this commit don't touch this part of the code.
> It can made more sense to add an another path to "prevent bad memory
> allocation in geq filter". What do you think ?

Ah, you are correct. A 2nd patch would be nice, yes, but don't consider
it a blocker for your current patch.

Sorry 'bout that!

- Derek
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH] avfilter: slice processing for geq

2017-11-22 Thread Marc-Antoine ARNAUD
It made sense, but this commit don't touch this part of the code.
It can made more sense to add an another path to "prevent bad memory
allocation in geq filter". What do you think ?

Regards,

Le mer. 22 nov. 2017 à 15:19, Derek Buitenhuis 
a écrit :

> On 11/22/2017 10:24 AM, Marc-Antoine ARNAUD wrote:
> > New patch version which fixe the last remark.
>
> [...]
>
> > +char depth_string[8];
> > +snprintf(depth_string, sizeof(depth_string), "%d",
> (1 > +geq->expr_str[A] = av_strdup(depth_string);
>
> Missing return value check for av_strdup.
>
> - Derek
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH] avfilter: slice processing for geq

2017-11-22 Thread Derek Buitenhuis
On 11/22/2017 10:24 AM, Marc-Antoine ARNAUD wrote:
> New patch version which fixe the last remark.

[...]

> +char depth_string[8];
> +snprintf(depth_string, sizeof(depth_string), "%d", (1 1);
> +geq->expr_str[A] = av_strdup(depth_string);

Missing return value check for av_strdup.

- Derek
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH] avfilter: slice processing for geq

2017-11-22 Thread Marc-Antoine ARNAUD
New patch version which fixe the last remark.


Le ven. 10 nov. 2017 à 00:47, Michael Niedermayer 
a écrit :

> On Thu, Nov 09, 2017 at 10:22:23AM +, Marc-Antoine ARNAUD wrote:
> > Please find the merged patch in attachement.
> >
> > Thanks
> >
> > Le mer. 8 nov. 2017 à 17:12, Paul B Mahol  a écrit :
> >
> > > On 11/8/17, Marc-Antoine ARNAUD  wrote:
> > > > This patch will fix the stride issue.
> > > > Is it valid for you ?
> > > >
> > > > Does it required to merge these 2 patches ? (and remove base64
> encoding
> > > on
> > > > the first one)
> > >
> > > Please merge those two patches, base64 encoding should not be needed
> > > (it helps to faster review patches if they are not encoded).
> > > ___
> > > ffmpeg-devel mailing list
> > > ffmpeg-devel@ffmpeg.org
> > > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > >
>
> >  vf_geq.c |  124
> +--
> >  1 file changed, 90 insertions(+), 34 deletions(-)
> > b41a90fffb5ddef553661007a38659c602f7ce56
> 0001-avfilter-slice-processing-for-geq.patch
> > From ac2a6322fa96835e02a24c31f014fb360e26561f Mon Sep 17 00:00:00 2001
> > From: Marc-Antoine Arnaud 
> > Date: Thu, 9 Nov 2017 11:19:43 +0100
> > Subject: [PATCH] avfilter: slice processing for geq
> > Content-Type: text/x-patch; charset="utf-8"
>
> crashes:
> ./ffmpeg_g -f lavfi -i
> 'nullsrc=s=200x200,format=yuv444p16,geq=X*Y/10:sin(X/10)*255:cos(Y/10)*255'
> -vframes 5 -y blah.avi
>
> ==24616== Thread 7:
> ==24616== Invalid write of size 2
> ==24616==at 0x4F3AAF: slice_geq_filter (vf_geq.c:289)
> ==24616==by 0x48E4C9: worker_func (pthread.c:50)
> ==24616==by 0x11DB932: run_jobs (slicethread.c:61)
> ==24616==by 0x11DBA04: thread_worker (slicethread.c:85)
> ==24616==by 0xC45D183: start_thread (pthread_create.c:312)
> ==24616==by 0xC770FFC: clone (clone.S:111)
> ==24616==  Address 0x1177143e is 93,214 bytes inside a block of size
> 93,215 alloc'd
> ==24616==at 0x4C2A6C5: memalign (vg_replace_malloc.c:727)
> ==24616==by 0x4C2A760: posix_memalign (vg_replace_malloc.c:876)
> ==24616==by 0x11B0C43: av_malloc (mem.c:87)
> ==24616==by 0x11987CC: av_buffer_alloc (buffer.c:72)
> ==24616==by 0x1198831: av_buffer_allocz (buffer.c:85)
> ==24616==by 0x1198F29: pool_alloc_buffer (buffer.c:312)
> ==24616==by 0x1199057: av_buffer_pool_get (buffer.c:349)
> ==24616==by 0x489D6D: ff_frame_pool_get (framepool.c:222)
> ==24616==by 0x58F6EB: ff_default_get_video_buffer (video.c:89)
> ==24616==by 0x58F768: ff_get_video_buffer (video.c:102)
> ==24616==by 0x4F3BF3: geq_filter_frame (vf_geq.c:312)
> ==24616==by 0x472FD0: ff_filter_frame_framed (avfilter.c:1104)
> ==24616==by 0x473800: ff_filter_frame_to_filter (avfilter.c:1252)
> ==24616==by 0x4739F8: ff_filter_activate_default (avfilter.c:1301)
> ==24616==by 0x473C12: ff_filter_activate (avfilter.c:1462)
> ==24616==by 0x478A4F: ff_filter_graph_run_once (avfiltergraph.c:1456)
> ==24616==by 0x478C72: get_frame_internal (buffersink.c:110)
> ==24616==by 0x478CCF: av_buffersink_get_frame_flags (buffersink.c:121)
> ==24616==by 0x441808: lavfi_read_packet (lavfi.c:410)
> ==24616==by 0x7AC315: ff_read_packet (utils.c:822)
> ==24616==
> --24616-- VALGRIND INTERNAL ERROR: Valgrind received a signal 11 (SIGSEGV)
> - exiting
> --24616-- si_code=80;  Faulting address: 0x0;  sp: 0x40a075db0
>
> [...]
>
> --
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> While the State exists there can be no freedom; when there is freedom there
> will be no State. -- Vladimir Lenin
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>


0001-avfilter-slice-processing-for-geq.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH] avfilter: slice processing for geq

2017-11-09 Thread Michael Niedermayer
On Thu, Nov 09, 2017 at 10:22:23AM +, Marc-Antoine ARNAUD wrote:
> Please find the merged patch in attachement.
> 
> Thanks
> 
> Le mer. 8 nov. 2017 à 17:12, Paul B Mahol  a écrit :
> 
> > On 11/8/17, Marc-Antoine ARNAUD  wrote:
> > > This patch will fix the stride issue.
> > > Is it valid for you ?
> > >
> > > Does it required to merge these 2 patches ? (and remove base64 encoding
> > on
> > > the first one)
> >
> > Please merge those two patches, base64 encoding should not be needed
> > (it helps to faster review patches if they are not encoded).
> > ___
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >

>  vf_geq.c |  124 
> +--
>  1 file changed, 90 insertions(+), 34 deletions(-)
> b41a90fffb5ddef553661007a38659c602f7ce56  
> 0001-avfilter-slice-processing-for-geq.patch
> From ac2a6322fa96835e02a24c31f014fb360e26561f Mon Sep 17 00:00:00 2001
> From: Marc-Antoine Arnaud 
> Date: Thu, 9 Nov 2017 11:19:43 +0100
> Subject: [PATCH] avfilter: slice processing for geq
> Content-Type: text/x-patch; charset="utf-8"

crashes:
./ffmpeg_g -f lavfi -i 
'nullsrc=s=200x200,format=yuv444p16,geq=X*Y/10:sin(X/10)*255:cos(Y/10)*255' 
-vframes 5 -y blah.avi

==24616== Thread 7:
==24616== Invalid write of size 2
==24616==at 0x4F3AAF: slice_geq_filter (vf_geq.c:289)
==24616==by 0x48E4C9: worker_func (pthread.c:50)
==24616==by 0x11DB932: run_jobs (slicethread.c:61)
==24616==by 0x11DBA04: thread_worker (slicethread.c:85)
==24616==by 0xC45D183: start_thread (pthread_create.c:312)
==24616==by 0xC770FFC: clone (clone.S:111)
==24616==  Address 0x1177143e is 93,214 bytes inside a block of size 93,215 
alloc'd
==24616==at 0x4C2A6C5: memalign (vg_replace_malloc.c:727)
==24616==by 0x4C2A760: posix_memalign (vg_replace_malloc.c:876)
==24616==by 0x11B0C43: av_malloc (mem.c:87)
==24616==by 0x11987CC: av_buffer_alloc (buffer.c:72)
==24616==by 0x1198831: av_buffer_allocz (buffer.c:85)
==24616==by 0x1198F29: pool_alloc_buffer (buffer.c:312)
==24616==by 0x1199057: av_buffer_pool_get (buffer.c:349)
==24616==by 0x489D6D: ff_frame_pool_get (framepool.c:222)
==24616==by 0x58F6EB: ff_default_get_video_buffer (video.c:89)
==24616==by 0x58F768: ff_get_video_buffer (video.c:102)
==24616==by 0x4F3BF3: geq_filter_frame (vf_geq.c:312)
==24616==by 0x472FD0: ff_filter_frame_framed (avfilter.c:1104)
==24616==by 0x473800: ff_filter_frame_to_filter (avfilter.c:1252)
==24616==by 0x4739F8: ff_filter_activate_default (avfilter.c:1301)
==24616==by 0x473C12: ff_filter_activate (avfilter.c:1462)
==24616==by 0x478A4F: ff_filter_graph_run_once (avfiltergraph.c:1456)
==24616==by 0x478C72: get_frame_internal (buffersink.c:110)
==24616==by 0x478CCF: av_buffersink_get_frame_flags (buffersink.c:121)
==24616==by 0x441808: lavfi_read_packet (lavfi.c:410)
==24616==by 0x7AC315: ff_read_packet (utils.c:822)
==24616==
--24616-- VALGRIND INTERNAL ERROR: Valgrind received a signal 11 (SIGSEGV) - 
exiting
--24616-- si_code=80;  Faulting address: 0x0;  sp: 0x40a075db0

[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH] avfilter: slice processing for geq

2017-11-09 Thread Marc-Antoine ARNAUD
Please find the merged patch in attachement.

Thanks

Le mer. 8 nov. 2017 à 17:12, Paul B Mahol  a écrit :

> On 11/8/17, Marc-Antoine ARNAUD  wrote:
> > This patch will fix the stride issue.
> > Is it valid for you ?
> >
> > Does it required to merge these 2 patches ? (and remove base64 encoding
> on
> > the first one)
>
> Please merge those two patches, base64 encoding should not be needed
> (it helps to faster review patches if they are not encoded).
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>


0001-avfilter-slice-processing-for-geq.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH] avfilter: slice processing for geq

2017-11-08 Thread Paul B Mahol
On 11/8/17, Marc-Antoine ARNAUD  wrote:
> This patch will fix the stride issue.
> Is it valid for you ?
>
> Does it required to merge these 2 patches ? (and remove base64 encoding on
> the first one)

Please merge those two patches, base64 encoding should not be needed
(it helps to faster review patches if they are not encoded).
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH] avfilter: slice processing for geq

2017-11-08 Thread Marc-Antoine ARNAUD
This patch will fix the stride issue.
Is it valid for you ?

Does it required to merge these 2 patches ? (and remove base64 encoding on
the first one)

Thx
Marc-Antoine

Le ven. 3 nov. 2017 à 03:13, Michael Niedermayer  a
écrit :

> On Thu, Nov 02, 2017 at 02:04:33PM +, Marc-Antoine ARNAUD wrote:
> >
>
> >  vf_geq.c |  126
> ---
> >  1 file changed, 89 insertions(+), 37 deletions(-)
> > b0379f3d7f1d9660e209fe491f48fd7f70113615
> 0001-avfilter-slice-processing-for-geq.patch
> > From c4bdf956e7f8b91b03f16bdf80b30058a117aae2 Mon Sep 17 00:00:00 2001
> > From: Marc-Antoine Arnaud 
> > Date: Thu, 2 Nov 2017 12:25:46 +0100
> > Subject: [PATCH] avfilter: slice processing for geq
>
> > Content-Type: text/x-patch; charset="utf-8"
> > Content-Transfer-Encoding: base64
>
> hmm
>
>
> >
> > ---
> >  libavfilter/vf_geq.c | 126
> ---
> >  1 file changed, 89 insertions(+), 37 deletions(-)
>
> breaks:
> ./ffplay  matrixbench_mpeg2.mpg  -vf 'geq=b=b(X\,Y)-r(X\,Y)'
>
> looks like possibly something related to strides
>
> [...]
> --
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Its not that you shouldnt use gotos but rather that you should write
> readable code and code with gotos often but not always is less readable
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>


0001-avfilter-fix-stride-for-g_eq.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH] avfilter: slice processing for geq

2017-11-02 Thread Michael Niedermayer
On Thu, Nov 02, 2017 at 02:04:33PM +, Marc-Antoine ARNAUD wrote:
> 

>  vf_geq.c |  126 
> ---
>  1 file changed, 89 insertions(+), 37 deletions(-)
> b0379f3d7f1d9660e209fe491f48fd7f70113615  
> 0001-avfilter-slice-processing-for-geq.patch
> From c4bdf956e7f8b91b03f16bdf80b30058a117aae2 Mon Sep 17 00:00:00 2001
> From: Marc-Antoine Arnaud 
> Date: Thu, 2 Nov 2017 12:25:46 +0100
> Subject: [PATCH] avfilter: slice processing for geq

> Content-Type: text/x-patch; charset="utf-8"
> Content-Transfer-Encoding: base64

hmm


> 
> ---
>  libavfilter/vf_geq.c | 126 
> ---
>  1 file changed, 89 insertions(+), 37 deletions(-)

breaks:
./ffplay  matrixbench_mpeg2.mpg  -vf 'geq=b=b(X\,Y)-r(X\,Y)'

looks like possibly something related to strides

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel