Re: [FFmpeg-devel] [PATCH] avfilter:vf_libvmaf: fix errors while running with psnr=1 and improve docs

2017-11-06 Thread Carl Eugen Hoyos
2017-11-06 21:27 GMT+01:00 Ronald S. Bultje : > Hi, > > On Mon, Nov 6, 2017 at 1:58 PM, Carl Eugen Hoyos wrote: > >> It is one thing to know that within FFmpeg, we do not modify >> a pointer target and therefore decide to cast, but isn't it >> another (bad)

Re: [FFmpeg-devel] [PATCH] avfilter:vf_libvmaf: fix errors while running with psnr=1 and improve docs

2017-11-06 Thread Ronald S. Bultje
Hi, On Mon, Nov 6, 2017 at 1:58 PM, Carl Eugen Hoyos wrote: > It is one thing to know that within FFmpeg, we do not modify > a pointer target and therefore decide to cast, but isn't it > another (bad) thing to assume this for an external library? I'm guessing that what you

Re: [FFmpeg-devel] [PATCH] avfilter:vf_libvmaf: fix errors while running with psnr=1 and improve docs

2017-11-06 Thread Carl Eugen Hoyos
2017-11-06 15:09 GMT+01:00 Ronald S. Bultje : > Hi, > > On Mon, Nov 6, 2017 at 8:21 AM, Carl Eugen Hoyos wrote: > >> 2017-11-06 13:52 GMT+01:00 Ronald S. Bultje : >> > Split, and pushed. >> >> +format = (char *) s->desc->name; >> >>

Re: [FFmpeg-devel] [PATCH] avfilter:vf_libvmaf: fix errors while running with psnr=1 and improve docs

2017-11-06 Thread Ashish Pratap Singh
Hi, On Nov 6, 2017 18:22, "Ronald S. Bultje" wrote: Hi, On Thu, Oct 12, 2017 at 4:43 PM, Carl Eugen Hoyos wrote: > 2017-10-11 15:53 GMT+02:00 Ashish Pratap Singh : > > > Hi, this patch fixes the seg fault which ocuured while

Re: [FFmpeg-devel] [PATCH] avfilter:vf_libvmaf: fix errors while running with psnr=1 and improve docs

2017-11-06 Thread Ronald S. Bultje
Hi, On Mon, Nov 6, 2017 at 8:21 AM, Carl Eugen Hoyos wrote: > 2017-11-06 13:52 GMT+01:00 Ronald S. Bultje : > > Hi, > > > > On Thu, Oct 12, 2017 at 4:43 PM, Carl Eugen Hoyos > > wrote: > > > >> 2017-10-11 15:53 GMT+02:00 Ashish Pratap

Re: [FFmpeg-devel] [PATCH] avfilter:vf_libvmaf: fix errors while running with psnr=1 and improve docs

2017-11-06 Thread Carl Eugen Hoyos
2017-11-06 13:52 GMT+01:00 Ronald S. Bultje : > Hi, > > On Thu, Oct 12, 2017 at 4:43 PM, Carl Eugen Hoyos > wrote: > >> 2017-10-11 15:53 GMT+02:00 Ashish Pratap Singh : >> >> > Hi, this patch fixes the seg fault which ocuured while

Re: [FFmpeg-devel] [PATCH] avfilter:vf_libvmaf: fix errors while running with psnr=1 and improve docs

2017-11-06 Thread Ronald S. Bultje
Hi, On Thu, Oct 12, 2017 at 4:43 PM, Carl Eugen Hoyos wrote: > 2017-10-11 15:53 GMT+02:00 Ashish Pratap Singh : > > > Hi, this patch fixes the seg fault which ocuured while running libvmaf > filter > > with option psnr=1. This also improves libvmaf doc a