Re: [FFmpeg-devel] [PATCH] avfilter:vf_libvmaf: fix errors while running with psnr=1 and improve docs

[Carl Eugen Hoyos]

2017-11-06 21:27 GMT+01:00 Ronald S. Bultje :
> Hi,
>
> On Mon, Nov 6, 2017 at 1:58 PM, Carl Eugen Hoyos  wrote:
>
>> It is one thing to know that within FFmpeg, we do not modify
>> a pointer target and therefore decide to cast, but isn't it
>> another (bad) thing to assume this for an external library?
>
> I'm guessing that what you mean is "libvmaf may not touch it right now, but
> the API doesn't guarantee that such an implementation detail doesn't change
> in the future", right?
>
> Yes, you're right. Potential solutions are to make libvmaf const-correct or
> to strdup in our implementation.

> I'm fine with both

Me too.

Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter:vf_libvmaf: fix errors while running with psnr=1 and improve docs

[Ronald S. Bultje]

Hi,

On Mon, Nov 6, 2017 at 1:58 PM, Carl Eugen Hoyos  wrote:

> It is one thing to know that within FFmpeg, we do not modify
> a pointer target and therefore decide to cast, but isn't it
> another (bad) thing to assume this for an external library?


I'm guessing that what you mean is "libvmaf may not touch it right now, but
the API doesn't guarantee that such an implementation detail doesn't change
in the future", right?

Yes, you're right. Potential solutions are to make libvmaf const-correct or
to strdup in our implementation. I'm fine with both, although I'd prefer if
we didn't strdup every frame, i.e. move it to some global init/uninit
function.

Ronald
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter:vf_libvmaf: fix errors while running with psnr=1 and improve docs

[Carl Eugen Hoyos]

2017-11-06 15:09 GMT+01:00 Ronald S. Bultje :
> Hi,
>
> On Mon, Nov 6, 2017 at 8:21 AM, Carl Eugen Hoyos  wrote:
>
>> 2017-11-06 13:52 GMT+01:00 Ronald S. Bultje :

>> > Split, and pushed.
>>
>> +format = (char *) s->desc->name;
>>
>> Isn't this cast a bad idea?
>
> It's an API thing. We can either strdup(), or use a cast, or have a
> compiler warning.

Yes.

> libvmaf does not modify the argument even if it doesn't
> use const here.

I hoped (and assumed) so.

What I meant was:
It is one thing to know that within FFmpeg, we do not modify
a pointer target and therefore decide to cast, but isn't it
another (bad) thing to assume this for an external library?

Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter:vf_libvmaf: fix errors while running with psnr=1 and improve docs

[Ashish Pratap Singh]

Hi,

On Nov 6, 2017 18:22, "Ronald S. Bultje"  wrote:

Hi,

On Thu, Oct 12, 2017 at 4:43 PM, Carl Eugen Hoyos 
wrote:

> 2017-10-11 15:53 GMT+02:00 Ashish Pratap Singh :
>
> > Hi, this patch fixes the seg fault which ocuured while running libvmaf
> filter
> > with option psnr=1. This also improves libvmaf doc a bit.
>
> Please split in two patches.


Split, and pushed.

Ronald

Thanks.

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter:vf_libvmaf: fix errors while running with psnr=1 and improve docs

[Ronald S. Bultje]

Hi,

On Mon, Nov 6, 2017 at 8:21 AM, Carl Eugen Hoyos  wrote:

> 2017-11-06 13:52 GMT+01:00 Ronald S. Bultje :
> > Hi,
> >
> > On Thu, Oct 12, 2017 at 4:43 PM, Carl Eugen Hoyos 
> > wrote:
> >
> >> 2017-10-11 15:53 GMT+02:00 Ashish Pratap Singh :
> >>
> >> > Hi, this patch fixes the seg fault which ocuured while running libvmaf
> >> > filter with option psnr=1. This also improves libvmaf doc a bit.
> >>
> >> Please split in two patches.
> >
> > Split, and pushed.
>
> +format = (char *) s->desc->name;
>
> Isn't this cast a bad idea?


It's an API thing. We can either strdup(), or use a cast, or have a
compiler warning. libvmaf does not modify the argument even if it doesn't
use const here.

Ronald
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter:vf_libvmaf: fix errors while running with psnr=1 and improve docs

[Carl Eugen Hoyos]

2017-11-06 13:52 GMT+01:00 Ronald S. Bultje :
> Hi,
>
> On Thu, Oct 12, 2017 at 4:43 PM, Carl Eugen Hoyos 
> wrote:
>
>> 2017-10-11 15:53 GMT+02:00 Ashish Pratap Singh :
>>
>> > Hi, this patch fixes the seg fault which ocuured while running libvmaf
>> > filter with option psnr=1. This also improves libvmaf doc a bit.
>>
>> Please split in two patches.
>
> Split, and pushed.

+format = (char *) s->desc->name;

Isn't this cast a bad idea?

Thank you for reviving this, Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter:vf_libvmaf: fix errors while running with psnr=1 and improve docs

[Ronald S. Bultje]

Hi,

On Thu, Oct 12, 2017 at 4:43 PM, Carl Eugen Hoyos 
wrote:

> 2017-10-11 15:53 GMT+02:00 Ashish Pratap Singh :
>
> > Hi, this patch fixes the seg fault which ocuured while running libvmaf
> filter
> > with option psnr=1. This also improves libvmaf doc a bit.
>
> Please split in two patches.


Split, and pushed.

Ronald
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel