Re: [FFmpeg-devel] [PATCH] avformat/mov: Enable stream parsing for VP9.
Hi, On Wed, Sep 7, 2016 at 7:37 AM, Ronald S. Bultjewrote: > Hi, > > On Tue, Sep 6, 2016 at 10:39 PM, Matthew Gregan wrote: > >> At 2016-09-06T22:18:18-0400, Ronald S. Bultje wrote: >> > I think the patch is fine, but I wonder if it should set it to _FULL >> (the >> > parser ignores the option, but it is semantically more correct). >> >> Good point, thanks for the feedback. Updated (simpler!) patch attached. > > > LGTM. > Sorry about delay - pushed. Ronald ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] avformat/mov: Enable stream parsing for VP9.
Hi, On Tue, Sep 6, 2016 at 10:39 PM, Matthew Greganwrote: > At 2016-09-06T22:18:18-0400, Ronald S. Bultje wrote: > > I think the patch is fine, but I wonder if it should set it to _FULL (the > > parser ignores the option, but it is semantically more correct). > > Good point, thanks for the feedback. Updated (simpler!) patch attached. LGTM. Ronald ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] avformat/mov: Enable stream parsing for VP9.
At 2016-09-06T22:18:18-0400, Ronald S. Bultje wrote: > I think the patch is fine, but I wonder if it should set it to _FULL (the > parser ignores the option, but it is semantically more correct). Good point, thanks for the feedback. Updated (simpler!) patch attached. Cheers, >From a9d69f145bb92939c1ffce11a0522d76857f Mon Sep 17 00:00:00 2001 From: Matthew GreganDate: Wed, 7 Sep 2016 13:58:30 +1200 Subject: avformat/mov: Enable stream parsing for VP9. MP4 media containing VP9 using superframes (such as https://github.com/Netflix/vp9-dash/raw/master/DASH-Samples/Fountain_2997_0560kbps_640x480_4x3PAR.ivf_DashUnencrypted.ismv) does not decode correctly with the built-in VP9 decoder because superframes are passed to the decoder whole rather than split into individual frames. Signed-off-by: Matthew Gregan diff --git a/libavformat/mov.c b/libavformat/mov.c index f499906..fa4e016 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -2161,6 +2161,7 @@ static int mov_finalize_stsd_codec(MOVContext *c, AVIOContext *pb, case AV_CODEC_ID_EAC3: case AV_CODEC_ID_MPEG1VIDEO: case AV_CODEC_ID_VC1: +case AV_CODEC_ID_VP9: st->need_parsing = AVSTREAM_PARSE_FULL; break; default: -- 2.9.3 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel