Re: [FFmpeg-devel] [PATCH] avformat/movenc: Add support for more colorspaces

2017-12-15 Thread Carl Eugen Hoyos
2017-12-15 8:22 GMT+01:00 Steven Robertson :
> Actually QT has supported these codepoints for some time now internally,
> but not officially. That said, I modified this to write nonsense values and
> it interpreted everything as Rec 601 625 aka 470BG, which isn't great (I
> think the default for anything should be 709 these days) but is not crazy
> either.

Thank you for testing and reporting this!

Please avoid top-posting here, Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH] avformat/movenc: Add support for more colorspaces

2017-12-14 Thread Steven Robertson
Actually QT has supported these codepoints for some time now internally,
but not officially. That said, I modified this to write nonsense values and
it interpreted everything as Rec 601 625 aka 470BG, which isn't great (I
think the default for anything should be 709 these days) but is not crazy
either. I presume the same behavior applies to very old versions of
QuickTime looking at these new codepoints.

On Dec 14, 2017 6:51 PM, "Carl Eugen Hoyos"  wrote:

> 2017-12-14 20:52 GMT+01:00 Steven Robertson :
> > With FCPX 10.4, Apple has expanded the set of colorspace,
> > primaries, and trc flags officially supported in QuickTime files.
>
> What happens if new files (with new colorspace etc.) areplayed
> back with older QT?
>
> Carl Eugen
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH] avformat/movenc: Add support for more colorspaces

2017-12-14 Thread Carl Eugen Hoyos
2017-12-14 20:52 GMT+01:00 Steven Robertson :
> With FCPX 10.4, Apple has expanded the set of colorspace,
> primaries, and trc flags officially supported in QuickTime files.

What happens if new files (with new colorspace etc.) areplayed
back with older QT?

Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH] avformat/movenc: Add support for more colorspaces

2017-12-14 Thread Michael Niedermayer
On Thu, Dec 14, 2017 at 11:52:45AM -0800, Steven Robertson wrote:
> With FCPX 10.4, Apple has expanded the set of colorspace, primaries,
> and trc flags officially supported in QuickTime files. The expanded set
> matches the codepoints used in ffmpeg and many other specs.
> ---
>  libavformat/movenc.c | 25 -
>  1 file changed, 16 insertions(+), 9 deletions(-)

will apply

thx

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel