Re: [FFmpeg-devel] [PATCH] avpacket: Set dst->side_data_elems to 0 within av_packet_copy_props.

2018-02-14 Thread wm4
On Wed, 14 Feb 2018 19:59:32 -0300 James Almer wrote: > On 2/14/2018 7:54 PM, wm4 wrote: > > On Wed, 14 Feb 2018 18:57:37 -0300 > > James Almer wrote: > > > >> On 2/14/2018 4:21 PM, wm4 wrote: > >>> On Wed, 14 Feb 2018 13:14:19 -0300 > >>> James Almer

Re: [FFmpeg-devel] [PATCH] avpacket: Set dst->side_data_elems to 0 within av_packet_copy_props.

2018-02-14 Thread James Almer
On 2/14/2018 7:54 PM, wm4 wrote: > On Wed, 14 Feb 2018 18:57:37 -0300 > James Almer wrote: > >> On 2/14/2018 4:21 PM, wm4 wrote: >>> On Wed, 14 Feb 2018 13:14:19 -0300 >>> James Almer wrote: >>> On 2/14/2018 2:25 AM, wm4 wrote: > On Wed, 14

Re: [FFmpeg-devel] [PATCH] avpacket: Set dst->side_data_elems to 0 within av_packet_copy_props.

2018-02-14 Thread wm4
On Wed, 14 Feb 2018 18:57:37 -0300 James Almer wrote: > On 2/14/2018 4:21 PM, wm4 wrote: > > On Wed, 14 Feb 2018 13:14:19 -0300 > > James Almer wrote: > > > >> On 2/14/2018 2:25 AM, wm4 wrote: > >>> On Wed, 14 Feb 2018 00:11:32 -0300 > >>> James Almer

Re: [FFmpeg-devel] [PATCH] avpacket: Set dst->side_data_elems to 0 within av_packet_copy_props.

2018-02-14 Thread James Almer
On 2/14/2018 4:21 PM, wm4 wrote: > On Wed, 14 Feb 2018 13:14:19 -0300 > James Almer wrote: > >> On 2/14/2018 2:25 AM, wm4 wrote: >>> On Wed, 14 Feb 2018 00:11:32 -0300 >>> James Almer wrote: >>> > --- > libavcodec/avpacket.c | 1 + > 1 file

Re: [FFmpeg-devel] [PATCH] avpacket: Set dst->side_data_elems to 0 within av_packet_copy_props.

2018-02-14 Thread wm4
On Wed, 14 Feb 2018 13:14:19 -0300 James Almer wrote: > On 2/14/2018 2:25 AM, wm4 wrote: > > On Wed, 14 Feb 2018 00:11:32 -0300 > > James Almer wrote: > > > >>> --- > >>> libavcodec/avpacket.c | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >>> diff

Re: [FFmpeg-devel] [PATCH] avpacket: Set dst->side_data_elems to 0 within av_packet_copy_props.

2018-02-14 Thread James Almer
On 2/14/2018 2:25 AM, wm4 wrote: > On Wed, 14 Feb 2018 00:11:32 -0300 > James Almer wrote: > >>> --- >>> libavcodec/avpacket.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c >>> index 90b8215928..1a9be60e20 100644

Re: [FFmpeg-devel] [PATCH] avpacket: Set dst->side_data_elems to 0 within av_packet_copy_props.

2018-02-13 Thread wm4
On Wed, 14 Feb 2018 00:11:32 -0300 James Almer wrote: > > --- > > libavcodec/avpacket.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c > > index 90b8215928..1a9be60e20 100644 > > --- a/libavcodec/avpacket.c > >

Re: [FFmpeg-devel] [PATCH] avpacket: Set dst->side_data_elems to 0 within av_packet_copy_props.

2018-02-13 Thread James Almer
On 2/14/2018 12:22 AM, Yusuke Nakamura wrote: > 2018-02-14 12:11 GMT+09:00 James Almer : > >> On 2/13/2018 11:43 PM, Yusuke Nakamura wrote: >>> This makes you need not call av_init_packet before av_packet_copy_props >> like the following. >>> >>> AVPacket dst; >>>

Re: [FFmpeg-devel] [PATCH] avpacket: Set dst->side_data_elems to 0 within av_packet_copy_props.

2018-02-13 Thread Yusuke Nakamura
2018-02-14 12:11 GMT+09:00 James Almer : > On 2/13/2018 11:43 PM, Yusuke Nakamura wrote: > > This makes you need not call av_init_packet before av_packet_copy_props > like the following. > > > > AVPacket dst; > > av_packet_copy_props(, ); > > In this scenario, dst->side_data is

Re: [FFmpeg-devel] [PATCH] avpacket: Set dst->side_data_elems to 0 within av_packet_copy_props.

2018-02-13 Thread James Almer
On 2/13/2018 11:43 PM, Yusuke Nakamura wrote: > This makes you need not call av_init_packet before av_packet_copy_props like > the following. > > AVPacket dst; > av_packet_copy_props(, ); In this scenario, dst->side_data is uninitialized, and bad things can happen when av_packet_copy_props