Re: [FFmpeg-devel] [PATCH] doc/muxers: add flv muxer document into doc/muxers

[Lou Logan]

On Fri, 16 Sep 2016 09:50:25 +0800, Steven Liu wrote:

> From e94de46102a57be1988cc451e1b610b404453c81 Mon Sep 17 00:00:00 2001
> From: Steven Liu 
> Date: Fri, 16 Sep 2016 08:58:33 +0800
> Subject: [PATCH] doc/muxers: add flv muxer document into doc/muxers
> 
> add flvflags aac_seq_header_detect and flvflags no_sequence_end
> document into doc/muxers
> ---
>  doc/muxers.texi | 30 ++
>  1 file changed, 30 insertions(+)

LGTM and pushed after removing the examples.

Thanks.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] doc/muxers: add flv muxer document into doc/muxers

[Steven Liu]

2016-09-16 3:11 GMT+08:00 Lou Logan :

> On Thu, 15 Sep 2016 12:02:15 +0800, Steven Liu wrote:
>
> > From 0a62f9cb55df317c7c3df47d31e345cb9ad593d0 Mon Sep 17 00:00:00 2001
> > From: Steven Liu 
> > Date: Thu, 15 Sep 2016 11:59:35 +0800
> > Subject: [PATCH] doc/muxers: add flv muxer document into doc/muxers
> >
> > add flvflags aac_seq_header_detect and flvflags no_sequence_end document
> > into doc/muxers
> >
> > Signed-off-by: Steven Liu 
> > ---
> >  doc/muxers.texi | 18 ++
> >  1 file changed, 18 insertions(+)
> >
> > diff --git a/doc/muxers.texi b/doc/muxers.texi
> > index ccf8ea1..8d94136 100644
> > --- a/doc/muxers.texi
> > +++ b/doc/muxers.texi
> > @@ -1047,6 +1047,24 @@ ffmpeg -i file.mpg -c copy \
> >   -y out.ts
> >  @end example
> >
> > +@section flv
>
> Your documentation is in the wrong location: it should be in
> alphabetical order, so place it between the crc and framecrc sections.
>
> > +Adobe Flash Video Format muxer.
> > +This muxer accepts the following options:
>
> Please add a blank line between the two sentences above.
>
> > +@table @option
> > +@item flvflags @var{flags}
> > +This flag currently supports the following flags:
>
> I prefer:
> "Possible values:"
>
> Optionally, you can add a short description of flvflags if it makes
> sense to do so. See the other flag type options for examples.
>
> > +@table @samp
> > +@item aac_seq_header_detect
> > +If this flag is set, the muxer will put AAC sequence header based on
> audio stream data.
>
> Can be shortened to:
> "Place AAC sequence header based on audio stream data."
>
> > +@item no_sequence_end
> > +If this flag is set, the muxer will have no sequence end tag at the end
> of flv.
>
> Can be shortened to:
> "Disable sequence end tag."
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>


0001-doc-muxers-add-flv-muxer-document-into-doc-muxers.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] doc/muxers: add flv muxer document into doc/muxers

[Lou Logan]

On Thu, 15 Sep 2016 12:02:15 +0800, Steven Liu wrote:

> From 0a62f9cb55df317c7c3df47d31e345cb9ad593d0 Mon Sep 17 00:00:00 2001
> From: Steven Liu 
> Date: Thu, 15 Sep 2016 11:59:35 +0800
> Subject: [PATCH] doc/muxers: add flv muxer document into doc/muxers
> 
> add flvflags aac_seq_header_detect and flvflags no_sequence_end document
> into doc/muxers
> 
> Signed-off-by: Steven Liu 
> ---
>  doc/muxers.texi | 18 ++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/doc/muxers.texi b/doc/muxers.texi
> index ccf8ea1..8d94136 100644
> --- a/doc/muxers.texi
> +++ b/doc/muxers.texi
> @@ -1047,6 +1047,24 @@ ffmpeg -i file.mpg -c copy \
>   -y out.ts
>  @end example
>  
> +@section flv

Your documentation is in the wrong location: it should be in
alphabetical order, so place it between the crc and framecrc sections.

> +Adobe Flash Video Format muxer.
> +This muxer accepts the following options:

Please add a blank line between the two sentences above.

> +@table @option
> +@item flvflags @var{flags}
> +This flag currently supports the following flags:

I prefer:
"Possible values:"

Optionally, you can add a short description of flvflags if it makes
sense to do so. See the other flag type options for examples.

> +@table @samp
> +@item aac_seq_header_detect
> +If this flag is set, the muxer will put AAC sequence header based on audio 
> stream data.

Can be shortened to:
"Place AAC sequence header based on audio stream data."

> +@item no_sequence_end
> +If this flag is set, the muxer will have no sequence end tag at the end of 
> flv.

Can be shortened to:
"Disable sequence end tag."
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] doc/muxers: add flv muxer document into doc/muxers

[Steven Liu]

2016-09-15 7:30 GMT+08:00 Lou Logan :

> On Wed, 14 Sep 2016 10:25:01 +0800, Steven Liu wrote:
>
> > From eb8856c6296eedb97a903028a93b2b1b23c50c97 Mon Sep 17 00:00:00 2001
> > From: Steven Liu 
> > Date: Wed, 14 Sep 2016 10:20:51 +0800
> > Subject: [PATCH] doc/muxers: add flv muxer document into doc/muxers
> >
> > add flvflags aac_seq_header_detect and flvflags no_sequence_end document
> > into doc/muxers
> >
> > Signed-off-by: Steven Liu 
> > ---
> >  doc/muxers.texi | 17 +
> >  1 file changed, 17 insertions(+)
> >
> > diff --git a/doc/muxers.texi b/doc/muxers.texi
> > index ccf8ea1..c8bd874 100644
> > --- a/doc/muxers.texi
> > +++ b/doc/muxers.texi
> > @@ -1047,6 +1047,23 @@ ffmpeg -i file.mpg -c copy \
> >   -y out.ts
> >  @end example
> >
> > +@section flv
> > +
> > +flv muxer.
>
> Adobe Flash Video Format muxer.
>
> > +@subsection Options
> > +
> > +The muxer options are:
>
> This muxer accepts the following options:
>
> > +@table @option
> > +
> > +@item flvflags aac_seq_header_detect
> > +If this flag is set, the muxer will put AAC sequence header based on
> audio stream data.
> > +
> > +@item flvflags no_sequence_end
> > +If this flag is set, the muxer will have no sequence end tag at the end
> of flv.
> > +@end table
> > +
>
> Please refer to other flag type option examples for the proper
> formatting (search "@table @samp").
> ___
>
>
Patch update


0001-doc-muxers-add-flv-muxer-document-into-doc-muxers.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel