Re: [FFmpeg-devel] [PATCH] lavf/concatdec: remove unrelated change during codecpar merge.

Le septidi 7 floréal, an CCXXIV, Derek Buitenhuis a écrit : > I'm not opposed to it, as long as the API conversion is done in a reasonable > amount of time. Ok, both patches pushed after Andrey confirmed they work. And I start lookint more closely at the new API. Regards, -- Nicolas George

Re: [FFmpeg-devel] [PATCH] lavf/concatdec: remove unrelated change during codecpar merge.

On 4/25/2016 1:09 PM, Nicolas George wrote: > Indeed, I had made a note to look into it, if only to silence the warnings, > and it seems the new API does the right thing. That will take a little time, > though, it would probably be better to have the fix immediately. I'm not opposed to it, as

Re: [FFmpeg-devel] [PATCH] lavf/concatdec: remove unrelated change during codecpar merge.

Le septidi 7 floréal, an CCXXIV, Hendrik Leppkes a écrit : > concatdec should be converted to the new BSF API, which should clear > and/or replace the extradata itself then IIRC. Indeed, I had made a note to look into it, if only to silence the warnings, and it seems the new API does the right

Re: [FFmpeg-devel] [PATCH] lavf/concatdec: remove unrelated change during codecpar merge.

On Mon, Apr 25, 2016 at 1:59 PM, Nicolas George wrote: > Le sextidi 6 floréal, an CCXXIV, Derek Buitenhuis a écrit : >> Removing this causes failures when concatdec is used to concat two H.264 >> streams from an MP4 source, when remuxed, IIRC. >> >> Example:

Re: [FFmpeg-devel] [PATCH] lavf/concatdec: remove unrelated change during codecpar merge.

Le sextidi 6 floréal, an CCXXIV, Derek Buitenhuis a écrit : > Removing this causes failures when concatdec is used to concat two H.264 > streams from an MP4 source, when remuxed, IIRC. > > Example: https://trac.ffmpeg.org/raw-attachment/ticket/3108/examplefiles.zip > > ./ffmpeg -f concat -i

Re: [FFmpeg-devel] [PATCH] lavf/concatdec: remove unrelated change during codecpar merge.

On Mon, Apr 25, 2016 at 08:58:40AM +0200, Nicolas George wrote: > Le sextidi 6 floréal, an CCXXIV, Andrey Utkin a écrit : > > Please look at my email in ffmpeg-devel > > '[PATCH] concatdec: Fix handling of H.264 in MP4 in case of "-auto_convert > > 0"' > > it adds a check which allows to

Re: [FFmpeg-devel] [PATCH] lavf/concatdec: remove unrelated change during codecpar merge.

Le sextidi 6 floréal, an CCXXIV, Andrey Utkin a écrit : > Please look at my email in ffmpeg-devel > '[PATCH] concatdec: Fix handling of H.264 in MP4 in case of "-auto_convert 0"' > it adds a check which allows to correctly handle both cases. I will be able to look at this patch when it arrives,

Re: [FFmpeg-devel] [PATCH] lavf/concatdec: remove unrelated change during codecpar merge.

On Sun, Apr 24, 2016 at 05:26:33PM +0200, Nicolas George wrote: > Le sextidi 6 floréal, an CCXXIV, Derek Buitenhuis a écrit : > > Removing this causes failures when concatdec is used to concat two H.264 > > streams from an MP4 source, when remuxed, IIRC. > > > > Example:

Re: [FFmpeg-devel] [PATCH] lavf/concatdec: remove unrelated change during codecpar merge.

On 4/24/2016 4:26 PM, Nicolas George wrote: > That may be true, but the fix is incorrect, and should not have sneaked > during a completely unrelated merge. For the sake of tracking changes, I > want to revert this, and then look for a more correct fix. The fix was deemed OK at the time by a few

Re: [FFmpeg-devel] [PATCH] lavf/concatdec: remove unrelated change during codecpar merge.

Le sextidi 6 floréal, an CCXXIV, Derek Buitenhuis a écrit : > Removing this causes failures when concatdec is used to concat two H.264 > streams from an MP4 source, when remuxed, IIRC. > > Example: https://trac.ffmpeg.org/raw-attachment/ticket/3108/examplefiles.zip > > ./ffmpeg -f concat -i

Re: [FFmpeg-devel] [PATCH] lavf/concatdec: remove unrelated change during codecpar merge.

On 4/24/2016 3:39 PM, Nicolas George wrote: > Clearing the extradata is not related to the codecpar change, > and it breaks if auto_convert is disabled. > > Fix trac ticket #5461. > > Signed-off-by: Nicolas George > --- > libavformat/concatdec.c | 5 - > 1 file changed, 5