Re: [FFmpeg-devel] [PATCH] lavf/mov: atom box parsing returneofcause play fail

[Michael Niedermayer]

On Mon, Dec 11, 2017 at 08:37:43PM +0800, Tiejun.Peng wrote:
> yes, it  is.
> maybe we should add every stream's status and the whole file status can't  be 
> fail only by  one of streams.
> but the modification will be too much and the effect  is extensive.

iam not sure i understand what you suggest but
this issue can be avoided by avoiding the overlap between the error
codes.
simply adding a otherwise not used error code for signaling that
data is truncated but everything is fine and code can continue
should work.
we can also use EOF as in your patch if people feel the advantages
outweight the risk. I just dont want this to be done as undocumented
sideeffect.
If EOF return implies everything must have been fully consistently
initialized then this must be documented

[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavf/mov: atom box parsing returneofcause play fail

[Tiejun.Peng]

yes, it  is.
maybe we should add every stream's status and the whole file status can't  be 
fail only by  one of streams.
but the modification will be too much and the effect  is extensive.



-- Original --
From:  "Michael Niedermayer";;
Send time: Saturday, Dec 9, 2017 3:36 AM
To: "FFmpeg development discussions and patches"; 

Subject:  Re: [FFmpeg-devel] [PATCH] lavf/mov: atom box parsing returneofcause 
play fail

On Sat, Dec 09, 2017 at 12:06:47AM +0800, Tiejun.Peng wrote: > yes,  i have 
checked this case and i have done a lot of tests  with .mp4 file and fate  
Please correct me if iam wrong there are many different atoms/boxes and many 
functions parsing them If any of these return EOF, it has previously been 
consideered an error now it can be handled as not an error. Noone has reviewed 
most of this code to be safe after the change. It doesnt crash in fate or with 
some valid mp4 files When a parsing function hits EOF it may return EOF. This 
can occur in the middle of the function, initializing some but not all of what 
it does normally. Previously this would stop the demuxer and trigger cleanup, 
after the change the code continues and may behave badly when it uses half 
initialized structures
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel