Re: [FFmpeg-devel] [PATCH] lavf/mov: atom box parsing return eof cause play fail

2017-12-07 Thread Michael Niedermayer
On Thu, Dec 07, 2017 at 05:47:46PM +0800, tiejun.peng wrote: > fix eof lead to play fail. > > Signed-off-by: tiejun.peng > --- > libavformat/mov.c | 47 --- > 1 file changed, 36 insertions(+), 11 deletions(-) please split the addition of warning messa

Re: [FFmpeg-devel] [PATCH] lavf/mov: atom box parsing return eof cause play fail

2017-12-06 Thread Carl Eugen Hoyos
2017-12-06 9:25 GMT+01:00 tiejun.peng : > /* check MOV header */ > do { > -if (mov->moov_retry) > -avio_seek(pb, 0, SEEK_SET); > -if ((err = mov_read_default(mov, pb, atom)) < 0) { > -av_log(s, AV_LOG_ERROR, "error reading header\n"); > -mov_read_close(s);

Re: [FFmpeg-devel] [PATCH] lavf/mov: atom box parsing return eof cause play fail

2017-12-05 Thread Michael Niedermayer
On Tue, Dec 05, 2017 at 11:34:12AM +0800, tiejun.peng wrote: > 1.add warning info about corrupted atom box parsing. > 2.atom box parsing return eof cause mov_read_close called in mov_read_header > and user have no chance to play the file. i think someone should cleanup the english, it sounds a bit