Re: [FFmpeg-devel] [PATCH] lavf/movenc: keep eac3_priv around; fixes eac3 in DASH

2018-03-09 Thread Derek Buitenhuis 
On 3/9/2018 2:42 AM, Rodger Combs wrote:
> Muxing DASH may involve calling mov_write_eac3_tag multiple times on the same 
> stream. If we destroy eac3_priv after the first call, we don't have it  
> later, so we end up not writing that data. This is fine for lavf (since 
> everything in that atom is redundant), but some other players require it.

So add that to the commit message and also make it clear
no mem leak is introduced.

- Derek
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavf/movenc: keep eac3_priv around; fixes eac3 in DASH

2018-03-08 Thread Rodger Combs 
Muxing DASH may involve calling mov_write_eac3_tag multiple times on the same 
stream. If we destroy eac3_priv after the first call, we don't have it  later, 
so we end up not writing that data. This is fine for lavf (since everything in 
that atom is redundant), but some other players require it.

> On Mar 8, 2018, at 05:46, Derek Buitenhuis  wrote:
> 
> On 3/8/2018 5:10 AM, Rodger Combs wrote:
>> ---
>> libavformat/movenc.c | 1 -
>> 1 file changed, 1 deletion(-)
> 
> Er, how/why?
> 
> No info is provided in this commit message.
> 
> - Derek
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavf/movenc: keep eac3_priv around; fixes eac3 in DASH

2018-03-08 Thread Derek Buitenhuis 
On 3/8/2018 5:10 AM, Rodger Combs wrote:
> ---
>  libavformat/movenc.c | 1 -
>  1 file changed, 1 deletion(-)

Er, how/why?

No info is provided in this commit message.

- Derek
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel