Re: [FFmpeg-devel] [PATCH] libavformat/mov: Replace duplicate stream_nb check by assert
On Wed, Nov 22, 2017 at 08:19:45PM +, Derek Buitenhuis wrote: > On 11/22/2017 8:09 PM, Michael Niedermayer wrote: > > not much, no > > its a non static function tough > > i can remove the check completely if thats preferred ? > > I guess leave it since it's non-static. > > LGTM. ok, will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who would give up essential Liberty, to purchase a little temporary Safety, deserve neither Liberty nor Safety -- Benjamin Franklin signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] libavformat/mov: Replace duplicate stream_nb check by assert
On 11/22/2017 8:09 PM, Michael Niedermayer wrote: > not much, no > its a non static function tough > i can remove the check completely if thats preferred ? I guess leave it since it's non-static. LGTM. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] libavformat/mov: Replace duplicate stream_nb check by assert
On Wed, Nov 22, 2017 at 02:09:46PM +, Derek Buitenhuis wrote: > On 11/22/2017 12:04 PM, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/mov.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > If it's a duplicate check, is there even a gain from using an assert? not much, no its a non static function tough i can remove the check completely if thats preferred ? -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Old school: Use the lowest level language in which you can solve the problem conveniently. New school: Use the highest level language in which the latest supercomputer can solve the problem without the user falling asleep waiting. signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] libavformat/mov: Replace duplicate stream_nb check by assert
On 11/22/2017 12:04 PM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/mov.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) If it's a duplicate check, is there even a gain from using an assert? - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel