Re: [FFmpeg-devel] [PATCH] libopenjpegenc: fix out-of-bounds reads when filling the edges

2016-10-14 Thread Andreas Cadhalpun
On 14.10.2016 06:08, Michael Bradshaw wrote: > On Thu, Oct 13, 2016 at 6:49 PM, Michael Niedermayer > wrote: >> >>> libopenjpegenc.c | 18 +- >>> 1 file changed, 9 insertions(+), 9 deletions(-) >>> 17061aee3e88729993c9581f688cbfda01fccaac

Re: [FFmpeg-devel] [PATCH] libopenjpegenc: fix out-of-bounds reads when filling the edges

2016-10-13 Thread Michael Bradshaw
On Thu, Oct 13, 2016 at 6:49 PM, Michael Niedermayer wrote: > > > libopenjpegenc.c | 18 +- > > 1 file changed, 9 insertions(+), 9 deletions(-) > > 17061aee3e88729993c9581f688cbfda01fccaac 0001-libopenjpegenc-fix-out- >

Re: [FFmpeg-devel] [PATCH] libopenjpegenc: fix out-of-bounds reads when filling the edges

2016-10-13 Thread Michael Niedermayer
On Fri, Oct 14, 2016 at 02:00:49AM +0200, Andreas Cadhalpun wrote: > On 14.10.2016 00:49, Michael Niedermayer wrote: > > On Fri, Oct 14, 2016 at 12:23:02AM +0200, Andreas Cadhalpun wrote: > >> The avctx->width/avctx->height is not zero, but libopenjpeg_copy_unpacked8 > >> does: > > > >>

Re: [FFmpeg-devel] [PATCH] libopenjpegenc: fix out-of-bounds reads when filling the edges

2016-10-13 Thread Andreas Cadhalpun
On 14.10.2016 00:49, Michael Niedermayer wrote: > On Fri, Oct 14, 2016 at 12:23:02AM +0200, Andreas Cadhalpun wrote: >> The avctx->width/avctx->height is not zero, but libopenjpeg_copy_unpacked8 >> does: > >> width = avctx->width / image->comps[compno].dx; >> height =

Re: [FFmpeg-devel] [PATCH] libopenjpegenc: fix out-of-bounds reads when filling the edges

2016-10-13 Thread Michael Niedermayer
On Fri, Oct 14, 2016 at 12:23:02AM +0200, Andreas Cadhalpun wrote: > On 14.10.2016 00:00, Hendrik Leppkes wrote: > > On Thu, Oct 13, 2016 at 10:25 PM, Andreas Cadhalpun > > wrote: > >> If x is 0, 'x - 1' is in the previous line, or worse outside the buffer > >>

Re: [FFmpeg-devel] [PATCH] libopenjpegenc: fix out-of-bounds reads when filling the edges

2016-10-13 Thread Andreas Cadhalpun
On 14.10.2016 00:00, Hendrik Leppkes wrote: > On Thu, Oct 13, 2016 at 10:25 PM, Andreas Cadhalpun > wrote: >> If x is 0, 'x - 1' is in the previous line, or worse outside the buffer >> for the first line. >> >> If y is 0, 'x - image->comps[compno].w' is outside

Re: [FFmpeg-devel] [PATCH] libopenjpegenc: fix out-of-bounds reads when filling the edges

2016-10-13 Thread Hendrik Leppkes
On Thu, Oct 13, 2016 at 10:25 PM, Andreas Cadhalpun wrote: > If x is 0, 'x - 1' is in the previous line, or worse outside the buffer > for the first line. > > If y is 0, 'x - image->comps[compno].w' is outside the buffer. > I'm slightly puzzled, as you say,