Re: [FFmpeg-devel] [PATCH] libvmaf: exit gracefully if the library fails.

Hi, On Mon, Dec 18, 2017 at 11:55 PM, James Almer wrote: > On 12/8/2017 10:35 PM, Ronald S. Bultje wrote: > > Fixes trac issue #6884 and Netflix/vmaf issue #124. > > --- > > libavfilter/vf_libvmaf.c | 28 ++-- > > 1 file changed, 22 insertions(+), 6

Re: [FFmpeg-devel] [PATCH] libvmaf: exit gracefully if the library fails.

On 12/8/2017 10:35 PM, Ronald S. Bultje wrote: > Fixes trac issue #6884 and Netflix/vmaf issue #124. > --- > libavfilter/vf_libvmaf.c | 28 ++-- > 1 file changed, 22 insertions(+), 6 deletions(-) > > diff --git a/libavfilter/vf_libvmaf.c b/libavfilter/vf_libvmaf.c > index

Re: [FFmpeg-devel] [PATCH] libvmaf: exit gracefully if the library fails.

2017-12-19 0:49 GMT+01:00 Ronald S. Bultje : > Hi, > > On Mon, Dec 18, 2017 at 6:31 PM, Carl Eugen Hoyos > wrote: > >> 2017-12-18 14:00 GMT+01:00 Ronald S. Bultje : >> > Hi, >> > >> > On Mon, Dec 18, 2017 at 12:28 AM, Gyan Doshi wrote:

Re: [FFmpeg-devel] [PATCH] libvmaf: exit gracefully if the library fails.

Hi, On Mon, Dec 18, 2017 at 6:31 PM, Carl Eugen Hoyos wrote: > 2017-12-18 14:00 GMT+01:00 Ronald S. Bultje : > > Hi, > > > > On Mon, Dec 18, 2017 at 12:28 AM, Gyan Doshi wrote: > > > >> Hi Ronald, > >> > >> When do you expect to apply this? > > > Oops,

Re: [FFmpeg-devel] [PATCH] libvmaf: exit gracefully if the library fails.

Hi, On Mon, Dec 18, 2017 at 12:28 AM, Gyan Doshi wrote: > Hi Ronald, > > When do you expect to apply this? Oops, forgot; pushed. Nicolas makes a good point that we may want to add a version check for libvmaf, but that can be done separately... Ronald

Re: [FFmpeg-devel] [PATCH] libvmaf: exit gracefully if the library fails.

Hi Ronald, When do you expect to apply this? Regards, Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] libvmaf: exit gracefully if the library fails.

Carl Eugen Hoyos (2017-12-10): > Sorry if I miss something: > This looks completely broken to me, how can the same function > of the same external library have two different amounts of > arguments (in C)? https://github.com/Netflix/vmaf/commit/96b99b9416135a0dfeb42c3b148852cce2b3f531 This commit

Re: [FFmpeg-devel] [PATCH] libvmaf: exit gracefully if the library fails.

2017-12-09 2:35 GMT+01:00 Ronald S. Bultje : > Fixes trac issue #6884 and Netflix/vmaf issue #124. > -s->vmaf_score = compute_vmaf(format, s->width, s->height, read_frame, s, > - s->model_path, s->log_path, s->log_fmt, 0, > 0, > -

Re: [FFmpeg-devel] [PATCH] libvmaf: exit gracefully if the library fails.

Hi, On Sat, Dec 9, 2017 at 2:34 AM, Gyan Doshi wrote: > > On 12/9/2017 7:05 AM, Ronald S. Bultje wrote: > >> Fixes trac issue #6884 and Netflix/vmaf issue #124. >> > > static void *call_vmaf(void *ctx) >> { >> > > ... > >> pthread_exit(NULL); >> } >> > > Fails

Re: [FFmpeg-devel] [PATCH] libvmaf: exit gracefully if the library fails.

On 12/9/2017 7:05 AM, Ronald S. Bultje wrote: Fixes trac issue #6884 and Netflix/vmaf issue #124. static void *call_vmaf(void *ctx) { > ... pthread_exit(NULL); } Fails to build unless I add 'return NULL;' in call_vmaf. Pre-existing issue. Open ticket is #6878. Is it