On 08-02-2019 03:18 AM, Carl Eugen Hoyos wrote:
2019-02-07 22:15 GMT+01:00, Gyan :
I don't see other h264 decoders, as used within ffmpeg, exporting CC
side-data, e.g. OpenH264 or QSV.
Do they provide it?
QSV offers a method to retrieve it but our wrapper doesn't.
(I do see native hevc
On 2/7/19 10:48 PM, Carl Eugen Hoyos wrote:
> Seems like a good reason to remove the useless information.
Done in my latest patch for what it's worth, I also don't think it's very
important
information, plus CC can also be provided by the motivated user through the
new_side_data() API anyway :)
2019-02-07 22:15 GMT+01:00, Gyan :
> I don't see other h264 decoders, as used within ffmpeg, exporting CC
> side-data, e.g. OpenH264 or QSV.
Do they provide it?
> (I do see native hevc doing so, as well as the Decklink indev , but not
> mentioned here.)
Seems like a good reason to remove the
On 08-02-2019 01:39 AM, Carl Eugen Hoyos wrote:
2019-02-07 21:07 GMT+01:00, Gyan :
On 08-02-2019 01:18 AM, Carl Eugen Hoyos wrote:
2019-02-07 20:16 GMT+01:00, Mathieu Duponchelle :
---
doc/encoders.texi | 3 +++
libavcodec/mpeg12enc.c | 31 +++
2019-02-07 21:07 GMT+01:00, Gyan :
>
>
> On 08-02-2019 01:18 AM, Carl Eugen Hoyos wrote:
>> 2019-02-07 20:16 GMT+01:00, Mathieu Duponchelle :
>>> ---
>>> doc/encoders.texi | 3 +++
>>> libavcodec/mpeg12enc.c | 31 +++
>>> libavcodec/mpegvideo.h | 2 ++
>>> 3
On 08-02-2019 01:18 AM, Carl Eugen Hoyos wrote:
2019-02-07 20:16 GMT+01:00, Mathieu Duponchelle :
---
doc/encoders.texi | 3 +++
libavcodec/mpeg12enc.c | 31 +++
libavcodec/mpegvideo.h | 2 ++
3 files changed, 36 insertions(+)
diff --git
2019-02-07 20:16 GMT+01:00, Mathieu Duponchelle :
> ---
> doc/encoders.texi | 3 +++
> libavcodec/mpeg12enc.c | 31 +++
> libavcodec/mpegvideo.h | 2 ++
> 3 files changed, 36 insertions(+)
>
> diff --git a/doc/encoders.texi b/doc/encoders.texi
> index
> On Feb 7, 2019, at 1:22 PM, Mathieu Duponchelle
> wrote:
>
>
>
> On 2/7/19 7:21 PM, Devin Heitmueller wrote:
>> Isn’t this calculation incorrect? The max cc_count possible is 31 (0x1F),
>> hence the max size should be 93.
>>
>
> True that, updating
Not to nitpick, but it might also be
On 2/7/19 7:21 PM, Devin Heitmueller wrote:
> Isn’t this calculation incorrect? The max cc_count possible is 31 (0x1F),
> hence the max size should be 93.
>
True that, updating
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
> On Feb 7, 2019, at 1:11 PM, Mathieu Duponchelle
> wrote:
> +if (side_data->size <= 96) {
Isn’t this calculation incorrect? The max cc_count possible is 31 (0x1F),
hence the max size should be 93.
> +int i = 0;
> +
> +put_header (s,
On 2/7/19 6:28 PM, Carl Eugen Hoyos wrote:
> Should you check here if the size is not bigger than a certain maximum
> value ...
>
>> +int i = 0;
>> +
>> +put_header (s, USER_START_CODE);
>> +
>> +put_bits(>pb, 8, 'G'); // user_identifier
>> +
2019-02-07 17:08 GMT+01:00, Mathieu Duponchelle :
> ---
> doc/encoders.texi | 3 +++
> libavcodec/mpeg12enc.c | 24
> libavcodec/mpegvideo.h | 2 ++
> 3 files changed, 29 insertions(+)
>
> diff --git a/doc/encoders.texi b/doc/encoders.texi
> index
12 matches
Mail list logo