Tsukasa OMOTO henry0312 at gmail.com writes:
I added support of ARIB subtitles to mpegts in
libavformat.
Shouldn't you add ARIB to DESC_types[]?
Could you provide samples for both types?
(Ideally even for all stream_identifiers but I
guess this isn't possible.)
Carl Eugen
On Thu, 21 Aug 2014 10:26:18 + (UTC)
Carl Eugen Hoyos ceho...@ag.or.at wrote:
Could you provide samples for both types?
uploaded to incoming/private-aribu_sub_sample.ts
-compn
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
On Thu, Aug 21, 2014 at 1:49 PM, Tsukasa OMOTO henry0...@gmail.com wrote:
Hi, Carl
Shouldn't you add ARIB to DESC_types[]?
I don't know which ISO_types or DESC_types I should add to.
Do you think DESC_types is better?
Tsukasa
ISO defines id 0x6 as a generic type for private data, its
Tsukasa OMOTO henry0312 at gmail.com writes:
Shouldn't you add ARIB to DESC_types[]?
I don't know which ISO_types or DESC_types I should
add to. Do you think DESC_types is better?
I probably mixed up stream descriptions and stream
identifiers, so ignore this suggestion.
But I believe you
But I believe you should simply remove the hunk
that sets ISO_types for ARIB.
updated the patch.
Like this?
0001-mpegts-support-ARIB-subtitles-in-libavformat.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
On Thu, Aug 21, 2014 at 09:42:30PM +0900, Tsukasa ŌMOTO wrote:
But I believe you should simply remove the hunk
that sets ISO_types for ARIB.
updated the patch.
Like this?
libavcodec/avcodec.h|2 ++
libavcodec/codec_desc.c | 14 ++
libavformat/mpegts.c| 34
