Re: [FFmpeg-devel] [PATCH] swresample/swresample: check for invalid sample rates

2019-05-25 Thread Paul B Mahol
On 5/25/19, Michael Niedermayer wrote: > On Fri, May 24, 2019 at 06:05:42PM +0200, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libswresample/swresample.c | 8 >> 1 file changed, 8 insertions(+) >> >> diff --git a/libswresample/swresample.c b/libswresample/swresample.c

Re: [FFmpeg-devel] [PATCH] swresample/swresample: check for invalid sample rates

2019-05-25 Thread Michael Niedermayer
On Sat, May 25, 2019 at 06:45:01PM +0200, Hendrik Leppkes wrote: > On Sat, May 25, 2019 at 5:58 PM Michael Niedermayer > wrote: > > > > On Fri, May 24, 2019 at 06:05:42PM +0200, Paul B Mahol wrote: > > > Signed-off-by: Paul B Mahol > > > --- > > > libswresample/swresample.c | 8 > > >

Re: [FFmpeg-devel] [PATCH] swresample/swresample: check for invalid sample rates

2019-05-25 Thread Hendrik Leppkes
On Sat, May 25, 2019 at 5:58 PM Michael Niedermayer wrote: > > On Fri, May 24, 2019 at 06:05:42PM +0200, Paul B Mahol wrote: > > Signed-off-by: Paul B Mahol > > --- > > libswresample/swresample.c | 8 > > 1 file changed, 8 insertions(+) > > > > diff --git a/libswresample/swresample.c

Re: [FFmpeg-devel] [PATCH] swresample/swresample: check for invalid sample rates

2019-05-25 Thread Michael Niedermayer
On Fri, May 24, 2019 at 06:05:42PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libswresample/swresample.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/libswresample/swresample.c b/libswresample/swresample.c > index 6d28e6a798..1ac5ef9a30 100644 > ---

Re: [FFmpeg-devel] [PATCH] swresample/swresample: check for invalid sample rates

2019-05-24 Thread Paul B Mahol
On 5/24/19, Derek Buitenhuis wrote: > On 24/05/2019 17:05, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libswresample/swresample.c | 8 >> 1 file changed, 8 insertions(+) > > Seems reasonable. What happens if these aren't in place? It may divide by zero and crash with

Re: [FFmpeg-devel] [PATCH] swresample/swresample: check for invalid sample rates

2019-05-24 Thread Derek Buitenhuis
On 24/05/2019 17:05, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libswresample/swresample.c | 8 > 1 file changed, 8 insertions(+) Seems reasonable. What happens if these aren't in place? - Derek ___ ffmpeg-devel mailing list