Re: [FFmpeg-devel] [PATCH]configure: libvmaf depends on pthreads

2017-12-28 Thread Carl Eugen Hoyos
2017-11-26 15:10 GMT+01:00 Nicolas George : > -> our code depends on pthreads for this filters, it must be expressed > in configure: Carl Eugen's patch is right Pushed with pthreads, as this is currently used. Thank you, Carl Eugen

Re: [FFmpeg-devel] [PATCH]configure: libvmaf depends on pthreads

2017-11-26 Thread Carl Eugen Hoyos
2017-11-26 15:10 GMT+01:00 Nicolas George : > $ grep -c pthread libavfilter/*vmaf* > libavfilter/vf_libvmaf.c:22 > libavfilter/vf_vmafmotion.c:0 > libavfilter/vmaf_motion.h:0 > > -> our code depends on pthreads for this filters, it must be expressed > in configure: Carl Eugen's

Re: [FFmpeg-devel] [PATCH]configure: libvmaf depends on pthreads

2017-11-26 Thread Derek Buitenhuis
On 11/26/2017 2:15 PM, Carl Eugen Hoyos wrote: > I believe I have explained before that I always only use > vanilla toolchains because that's the only thing users > typically have access to. It's possible the OS X version was outdated then, since the system clang has used libc++ as default since

Re: [FFmpeg-devel] [PATCH]configure: libvmaf depends on pthreads

2017-11-26 Thread Carl Eugen Hoyos
2017-11-26 15:11 GMT+01:00 Derek Buitenhuis : > On 11/26/2017 2:09 PM, Carl Eugen Hoyos wrote: >> As said before, it is non-trivial to find such a system >> (it worked fine here on osx when I tested last). > > OS X does not ship with libstdc++, IIRC. You must > have

Re: [FFmpeg-devel] [PATCH]configure: libvmaf depends on pthreads

2017-11-26 Thread Derek Buitenhuis
On 11/26/2017 2:10 PM, Nicolas George wrote: > -> our code depends on pthreads for this filters, it must be expressed > in configure: Carl Eugen's patch is right, there is no need to bugreport > anything. His explanations later were wrong, but it may only be caused > by the confusion you brought.

Re: [FFmpeg-devel] [PATCH]configure: libvmaf depends on pthreads

2017-11-26 Thread Derek Buitenhuis
On 11/26/2017 2:09 PM, Carl Eugen Hoyos wrote: > As said before, it is non-trivial to find such a system > (it worked fine here on osx when I tested last). OS X does not ship with libstdc++, IIRC. You must have been using a ports-build toolchain? Using clang-cl or MSVC on windows will also not

Re: [FFmpeg-devel] [PATCH]configure: libvmaf depends on pthreads

2017-11-26 Thread Nicolas George
Derek Buitenhuis (2017-11-26): > The problem is that libvmaf's .pc file put all of its deps in > Libs instead of splitting them out into Libs.private, which > is used only when static linking. Stuff like -lpthreads is > only needed if static linking, and stuff like -lstdc++ is > just wrong on any

Re: [FFmpeg-devel] [PATCH]configure: libvmaf depends on pthreads

2017-11-26 Thread Derek Buitenhuis
On 11/26/2017 2:06 PM, Carl Eugen Hoyos wrote: > In this case the library and our interface both depend on pthreads > but configure ignores this. Sorry, I wasn't aware our own wrapper code use pthreads too. Patch should be OK then. Upstream pkg-config file is still broken, though. :) - Derek

Re: [FFmpeg-devel] [PATCH]configure: libvmaf depends on pthreads

2017-11-26 Thread Carl Eugen Hoyos
2017-11-26 15:06 GMT+01:00 Derek Buitenhuis : > On 11/26/2017 2:02 PM, Carl Eugen Hoyos wrote: >> The way I understand (Linux) dynamic libraries, one implies >> the other. > > The problem is that libvmaf's .pc file put all of its deps in > Libs instead of splitting them

Re: [FFmpeg-devel] [PATCH]configure: libvmaf depends on pthreads

2017-11-26 Thread Derek Buitenhuis
On 11/26/2017 2:05 PM, Nicolas George wrote: > If a library does not use threads but our calls to the library require > threads, then we must consider it a dependency. Netflix made their pkg-config file incorrectly, which causes this. It should be fixed there, but do we want to work around that

Re: [FFmpeg-devel] [PATCH]configure: libvmaf depends on pthreads

2017-11-26 Thread Carl Eugen Hoyos
2017-11-26 15:05 GMT+01:00 Nicolas George : > Carl Eugen Hoyos (2017-11-26): >> The way I understand (Linux) dynamic libraries, one implies >> the other. > > Yes, but not the other way around. > > If a library uses threads internally but provides an interface that can > be used

Re: [FFmpeg-devel] [PATCH]configure: libvmaf depends on pthreads

2017-11-26 Thread Derek Buitenhuis
On 11/26/2017 2:02 PM, Carl Eugen Hoyos wrote: > The way I understand (Linux) dynamic libraries, one implies > the other. The problem is that libvmaf's .pc file put all of its deps in Libs instead of splitting them out into Libs.private, which is used only when static linking. Stuff like

Re: [FFmpeg-devel] [PATCH]configure: libvmaf depends on pthreads

2017-11-26 Thread Nicolas George
Carl Eugen Hoyos (2017-11-26): > The way I understand (Linux) dynamic libraries, one implies > the other. Yes, but not the other way around. If a library uses threads internally but provides an interface that can be used without threads, then it is not our problem. If a library does not use

Re: [FFmpeg-devel] [PATCH]configure: libvmaf depends on pthreads

2017-11-26 Thread Carl Eugen Hoyos
2017-11-26 14:59 GMT+01:00 Nicolas George : > Carl Eugen Hoyos (2017-11-26): >> The following produces an ffmpeg binary that loads pthreads >> at start-time: >> $ ./configure --enable-libvmaf --disable-pthreads > > That is not a problem. The fact that it produces a binary with >

Re: [FFmpeg-devel] [PATCH]configure: libvmaf depends on pthreads

2017-11-26 Thread Nicolas George
Carl Eugen Hoyos (2017-11-26): > The following produces an ffmpeg binary that loads pthreads > at start-time: > $ ./configure --enable-libvmaf --disable-pthreads That is not a problem. The fact that it produces a binary with pthreads symbols in it is. Regards, -- Nicolas George

Re: [FFmpeg-devel] [PATCH]configure: libvmaf depends on pthreads

2017-11-26 Thread Carl Eugen Hoyos
2017-11-26 14:53 GMT+01:00 Derek Buitenhuis : > On 11/26/2017 1:50 PM, Carl Eugen Hoyos wrote: >> Sorry, I don't understand how pkg-config is related to the missing >> dependency of our configure script: Please explain. > > Because pthreads is a dependency of libvmaf. >

Re: [FFmpeg-devel] [PATCH]configure: libvmaf depends on pthreads

2017-11-26 Thread Derek Buitenhuis
On 11/26/2017 1:50 PM, Carl Eugen Hoyos wrote: > Sorry, I don't understand how pkg-config is related to the missing > dependency of our configure script: Please explain. Because pthreads is a dependency of libvmaf. Looking at libvmaf, it does list pthreads as a dependency:

Re: [FFmpeg-devel] [PATCH]configure: libvmaf depends on pthreads

2017-11-26 Thread Carl Eugen Hoyos
2017-11-26 14:40 GMT+01:00 Derek Buitenhuis : > On 11/26/2017 1:35 PM, Carl Eugen Hoyos wrote: >> Attached patch adds a missing dependency to libvmaf, I don't know if >> other threads also work. > > This should also be filed as a bug against libvmaf, since its

Re: [FFmpeg-devel] [PATCH]configure: libvmaf depends on pthreads

2017-11-26 Thread Derek Buitenhuis
On 11/26/2017 1:35 PM, Carl Eugen Hoyos wrote: > Attached patch adds a missing dependency to libvmaf, I don't know if > other threads also work. This should also be filed as a bug against libvmaf, since its pkg-config file isn't complete, then. - Derek