Re: [FFmpeg-devel] [PATCH]lavf/mpegts: Add extension "m2t"

2016-04-10 Thread Carl Eugen Hoyos
Michael Niedermayer  niedermayer.cc> writes:

> On Sun, Apr 10, 2016 at 06:39:08AM +0200, Carl Eugen Hoyos wrote:
> > Hi!
> > 
> > Attached patch fixes ticket #4862 for me.

> should do no harm, so feel free to push but this is not the 
> correct fix ill push a fix for the probe code in a moment

Thank you!

I didn't realize this could be fixed, I am not particularly 
keen on adding extensions.

On the contrary, we have extensions listed for formats 
where demuxing will definitely fail if probing fails, 
for example avi.

Carl Eugen

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH]lavf/mpegts: Add extension "m2t"

2016-04-10 Thread Hendrik Leppkes
On Sun, Apr 10, 2016 at 6:39 AM, Carl Eugen Hoyos  wrote:
> Hi!
>
> Attached patch fixes ticket #4862 for me.
>

Listing only one extension, and a uncommon one at that, seems not ideal.
Considering the probing was fixed, maybe we should hold off on this.

- Hendrik
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH]lavf/mpegts: Add extension "m2t"

2016-04-10 Thread Michael Niedermayer
On Sun, Apr 10, 2016 at 06:39:08AM +0200, Carl Eugen Hoyos wrote:
> Hi!
> 
> Attached patch fixes ticket #4862 for me.
> 
> Please comment, Carl Eugen

should do no harm, so feel free to push but this is not the correct fix
ill push a fix for the probe code in a moment

[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you drop bombs on a foreign country and kill a hundred thousand
innocent people, expect your government to call the consequence
"unprovoked inhuman terrorist attacks" and use it to justify dropping
more bombs and killing more people. The technology changed, the idea is old.


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel