Re: [FFmpeg-devel] [PATCH]lavf/sdp: Fix MIME-type for big-endian G.726 audio.

2017-10-07 Thread Carl Eugen Hoyos 
2017-10-07 17:19 GMT+02:00 Michael Niedermayer :
> On Sat, Aug 26, 2017 at 11:53:46AM +0200, Carl Eugen Hoyos wrote:
>> Hi!
>>
>> Attached patch follows RFC 3551, a followup patch adds little-endian
>> G.726 with the old MIME-type.
>>
>> Please comment, Carl Eugen
>
>>  sdp.c |2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 764023f2cf781b005fba6baf777543fe298eca9f  
>> 0001-lavf-sdp-Fix-MIME-type-for-big-endian-G.726.patch
>> From 6ee9178dfad75c4fdb1556e929a59c9d80f0976d Mon Sep 17 00:00:00 2001
>> From: Carl Eugen Hoyos 
>> Date: Sat, 26 Aug 2017 11:46:18 +0200
>> Subject: [PATCH 1/2] lavf/sdp: Fix MIME-type for big-endian G.726.
>>
>> RFC 3551 defines "AAL2-G726" for big-endian ("left-justified") G.726
>> and "G726" for little-endian ("right-justified") G.726.
>
> if thats what the rfc says then its obviously ok
>
> the micro version should be bumped for every muxer fix

Done and pushed with slightly changed commit message.

Thank you, Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]lavf/sdp: Fix MIME-type for big-endian G.726 audio.

2017-10-07 Thread Michael Niedermayer 
On Sat, Aug 26, 2017 at 11:53:46AM +0200, Carl Eugen Hoyos wrote:
> Hi!
> 
> Attached patch follows RFC 3551, a followup patch adds little-endian
> G.726 with the old MIME-type.
> 
> Please comment, Carl Eugen

>  sdp.c |2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 764023f2cf781b005fba6baf777543fe298eca9f  
> 0001-lavf-sdp-Fix-MIME-type-for-big-endian-G.726.patch
> From 6ee9178dfad75c4fdb1556e929a59c9d80f0976d Mon Sep 17 00:00:00 2001
> From: Carl Eugen Hoyos 
> Date: Sat, 26 Aug 2017 11:46:18 +0200
> Subject: [PATCH 1/2] lavf/sdp: Fix MIME-type for big-endian G.726.
> 
> RFC 3551 defines "AAL2-G726" for big-endian ("left-justified") G.726
> and "G726" for little-endian ("right-justified") G.726.

if thats what the rfc says then its obviously ok

the micro version should be bumped for every muxer fix

thx

[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]lavf/sdp: Fix MIME-type for big-endian G.726 audio.

2017-10-06 Thread Carl Eugen Hoyos 
2017-08-26 11:53 GMT+02:00 Carl Eugen Hoyos :
> Hi!
>
> Attached patch follows RFC 3551, a followup patch adds little-endian
> G.726 with the old MIME-type.

Same here:
Please comment, Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel