Re: [FFmpeg-devel] [PATCH]lavfi/buffersrc: Add AVBufferSrcParameters->bits_per_raw_sample parameter.
On 11/17/17, Carl Eugen Hoyos wrote: > 2017-11-17 13:35 GMT+01:00 Paul B Mahol : >> On 11/17/17, Carl Eugen Hoyos wrote: >>> 2017-11-17 12:43 GMT+01:00 Paul B Mahol : On 11/17/17, Carl Eugen Hoyos wrote: > > I believe attached patch is necessary to fix ticket #6839 and > several older bug reports. No it is not neccessary. Because nothing uses it. >>> >>> libavcodec uses it in several codecs and others may benefit from it. >>> It is also used by ffmpeg and shown by ffprobe. >> >> But one you just added is not used > > That is because I wanted to know if the addition of the field is > acceptable before patching the various functions that will use it. > Do you find that this is unreasonable? > > But I realize now that the struct I had been searching for > is probably AVFilterLink in avfilter.h. > > Sorry for the noise, Carl Eugen Proper way to fx that issue is change decoder to output gbrp10. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH]lavfi/buffersrc: Add AVBufferSrcParameters->bits_per_raw_sample parameter.
Le septidi 27 brumaire, an CCXXVI, Carl Eugen Hoyos a écrit : > Hi! > > I believe attached patch is necessary to fix ticket #6839 and several > older bug reports. > > Missing version bump and APIchanges entry. > > Please review, Carl Eugen As is, no, it is just code connected with nothing. With a full patch maybe. But if I understand correctly what this field does, then to get it working you would have to go over all filters that change the contents of the signal to see how many significant bits they produce. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH]lavfi/buffersrc: Add AVBufferSrcParameters->bits_per_raw_sample parameter.
On Fri, Nov 17, 2017 at 1:26 PM, Carl Eugen Hoyos wrote: > 2017-11-17 12:43 GMT+01:00 Paul B Mahol : >> On 11/17/17, Carl Eugen Hoyos wrote: >>> Hi! >>> >>> I believe attached patch is necessary to fix ticket #6839 and several >>> older bug reports. >> >> No it is not neccessary. Because nothing uses it. > > libavcodec uses it in several codecs and others may benefit from it. > It is also used by ffmpeg and shown by ffprobe. > Where is this field realistically used for video? I only know if its use for audio. - Hendrik ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH]lavfi/buffersrc: Add AVBufferSrcParameters->bits_per_raw_sample parameter.
2017-11-17 13:35 GMT+01:00 Paul B Mahol : > On 11/17/17, Carl Eugen Hoyos wrote: >> 2017-11-17 12:43 GMT+01:00 Paul B Mahol : >>> On 11/17/17, Carl Eugen Hoyos wrote: I believe attached patch is necessary to fix ticket #6839 and several older bug reports. >>> >>> No it is not neccessary. Because nothing uses it. >> >> libavcodec uses it in several codecs and others may benefit from it. >> It is also used by ffmpeg and shown by ffprobe. > > But one you just added is not used That is because I wanted to know if the addition of the field is acceptable before patching the various functions that will use it. Do you find that this is unreasonable? But I realize now that the struct I had been searching for is probably AVFilterLink in avfilter.h. Sorry for the noise, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH]lavfi/buffersrc: Add AVBufferSrcParameters->bits_per_raw_sample parameter.
On 11/17/17, Carl Eugen Hoyos wrote: > 2017-11-17 12:43 GMT+01:00 Paul B Mahol : >> On 11/17/17, Carl Eugen Hoyos wrote: >>> Hi! >>> >>> I believe attached patch is necessary to fix ticket #6839 and several >>> older bug reports. >> >> No it is not neccessary. Because nothing uses it. > > libavcodec uses it in several codecs and others may benefit from it. > It is also used by ffmpeg and shown by ffprobe. But one you just added is not used ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH]lavfi/buffersrc: Add AVBufferSrcParameters->bits_per_raw_sample parameter.
2017-11-17 12:43 GMT+01:00 Paul B Mahol : > On 11/17/17, Carl Eugen Hoyos wrote: >> Hi! >> >> I believe attached patch is necessary to fix ticket #6839 and several >> older bug reports. > > No it is not neccessary. Because nothing uses it. libavcodec uses it in several codecs and others may benefit from it. It is also used by ffmpeg and shown by ffprobe. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH]lavfi/buffersrc: Add AVBufferSrcParameters->bits_per_raw_sample parameter.
On 11/17/17, Carl Eugen Hoyos wrote: > Hi! > > I believe attached patch is necessary to fix ticket #6839 and several > older bug reports. No it is not neccessary. Because nothing uses it. > > Missing version bump and APIchanges entry. > > Please review, Carl Eugen > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
