Re: [FFmpeg-devel] [PATCH 0/7] Fix for transparent gif creation

[Bjorn Roche]

On Wed, Oct 4, 2017 at 2:50 AM, Clément Bœsch  wrote:

> On Mon, Oct 02, 2017 at 01:24:32PM -0400, Bjorn Roche wrote:
> [...]
> > Bjorn Roche (7):
> >   First pass at fixing paletteuse
> >   Fix for dithering.
> >   Removing some debugging
> >   First pass at making the gif support transparency with the right
> > disposal methods. Needs more optimization.
> >   Reimplement optimization for transparency
> >   cleanup
> >   Fix for detecting opaque correctly.
>
> Please organize your patches in atomic changes instead of your
> chronological construction:
>
> - a patch should ideally change only one thing
> - each patch should be applicable without breaking anything
> - changes that do not belong at the end of the patchset should not be
>   present in the middle of the history unless technically required (your
>   debug logs don't).
>

Thank you Clement. I cleaned it up and sent a separate patch just for
paletteuse in response to a similar request from Carl Eugen.


bjorn

-- 


Bjorn Roche

Sr. Video Pipeline Engineer

bj...@giphy.com
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 0/7] Fix for transparent gif creation

[Clément Bœsch]

On Mon, Oct 02, 2017 at 01:24:32PM -0400, Bjorn Roche wrote:
[...]
> Bjorn Roche (7):
>   First pass at fixing paletteuse
>   Fix for dithering.
>   Removing some debugging
>   First pass at making the gif support transparency with the right
> disposal methods. Needs more optimization.
>   Reimplement optimization for transparency
>   cleanup
>   Fix for detecting opaque correctly.

Please organize your patches in atomic changes instead of your
chronological construction:

- a patch should ideally change only one thing
- each patch should be applicable without breaking anything
- changes that do not belong at the end of the patchset should not be
  present in the middle of the history unless technically required (your
  debug logs don't).

Interactive git rebase is your friend.

Thanks

-- 
Clément B.


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel