Re: [FFmpeg-devel] [PATCH 00/12] I added text to bitmap subtitle conversion functionality!

2022-05-03 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Soft > Works > Sent: Tuesday, May 3, 2022 6:27 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Traian Coza > Subject: Re: [FFmpeg-devel] [PATCH 00/12] I added text to bitm

Re: [FFmpeg-devel] [PATCH 00/12] I added text to bitmap subtitle conversion functionality!

2022-05-03 Thread Traian Coza
Thanks, I'll do that. I did read a bit of Contributing, but not entirely. And I read after writing the code, so there are some things I wasn't aware of at the time of writing the code. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 00/12] I added text to bitmap subtitle conversion functionality!

2022-05-03 Thread Leo Izen
On 5/3/22 13:01, Traian Coza wrote: I already made the commits, tho, what do you suggest I do? Should I modify the messages? ___ You'll have to send another patchset. You append -v2 to your "git format-patch" command-line to generate a second

Re: [FFmpeg-devel] [PATCH 00/12] I added text to bitmap subtitle conversion functionality!

2022-05-03 Thread Traian Coza
I already made the commits, tho, what do you suggest I do? Should I modify the messages? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH 00/12] I added text to bitmap subtitle conversion functionality!

2022-05-03 Thread Nicolas George
Paul B Mahol (12022-05-03): > Sorry but i think this needs to be in libavfilter instead of libavcodec. > > And for libavfilter one needs to add proper, not hacky, subtitle support to > library. I completely agree. Also, the patches neglect a lot of the directives in the developer documentation,

Re: [FFmpeg-devel] [PATCH 00/12] I added text to bitmap subtitle conversion functionality!

2022-05-03 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Traian Coza > Sent: Tuesday, May 3, 2022 6:13 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Traian Coza > Subject: [FFmpeg-devel] [PATCH 00/12] I added text to bitmap subtitle > conversion functionality! > > I added the possibility of

Re: [FFmpeg-devel] [PATCH 00/12] I added text to bitmap subtitle conversion functionality!

2022-05-03 Thread Paul B Mahol
On Tue, May 3, 2022 at 6:13 PM Traian Coza wrote: > I added the possibility of converting text-based subtitle tracks (such as > subrip or ass) to bitmap-based subtitle tracks (such as dvd_subtitle). > > I accomplished this by using libass, and basically using the code from > vf_subtitles.c to