Re: [FFmpeg-devel] [PATCH 1/2] fftools: Use right function signature and pointers

2019-08-14 Thread Michael Niedermayer
On Wed, Aug 14, 2019 at 06:06:04PM +0200, Paul B Mahol wrote: > LGTM will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many things microsoft did are stupid, but not doing something just because microsoft did it is even more stupid. If everything

Re: [FFmpeg-devel] [PATCH 1/2] fftools: Use right function signature and pointers

2019-08-14 Thread Paul B Mahol
LGTM On Mon, Aug 12, 2019 at 11:59 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Andreas Rheinhardt: > > The option tables of the various fftools (in particular ffprobe) are > > arrays of OptionDef; said type contains a union of a pointer to void and > > a function pointer of

Re: [FFmpeg-devel] [PATCH 1/2] fftools: Use right function signature and pointers

2019-08-12 Thread Andreas Rheinhardt
Andreas Rheinhardt: > The option tables of the various fftools (in particular ffprobe) are > arrays of OptionDef; said type contains a union of a pointer to void and > a function pointer of type int (*)(void *, const char *, const char *) > as well as a size_t. Some entries (namely the common