Re: [FFmpeg-devel] [PATCH 1/6] lavf/movenc: add sdtp (sample dependency) box
On Sun, Nov 19, 2017 at 12:46:30PM -0800, John Stebbins wrote: > The sdtp is required by the AppleTV 4K in order to play 2160p60 video. > --- > libavcodec/avcodec.h | 6 ++ > libavformat/isom.h | 5 + > libavformat/movenc.c | 30 ++ > libavformat/movenc.h | 2 ++ > 4 files changed, 43 insertions(+) will apply thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If you drop bombs on a foreign country and kill a hundred thousand innocent people, expect your government to call the consequence "unprovoked inhuman terrorist attacks" and use it to justify dropping more bombs and killing more people. The technology changed, the idea is old. signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 1/6] lavf/movenc: add sdtp (sample dependency) box
On 11/19/2017 02:29 PM, Carl Eugen Hoyos wrote: > 2017-11-19 23:25 GMT+01:00 John Stebbins: >> On 11/19/2017 02:12 PM, Carl Eugen Hoyos wrote: >>> 2017-11-19 21:46 GMT+01:00 John Stebbins : The sdtp is required by the AppleTV 4K in order to play 2160p60 video. +/** + * Flag is used to indicate packets that contain frames that can + * be discarded by the decoder. I.e. Non-reference frames. + */ +#define AV_PKT_FLAG_DISPOSABLE 0x0010 >>> What sets this flag? >> Encoders when encoding, demuxer when remuxing. >> The subsequent patches set this flag for x264, x265, and mp4 demux. > So does this patch alone work wrt the description: Does AppleTV play > 4k with this patch alone? > > The commit message simply states that the atom is a requirement. It doesn't say whether there are additional requirements. Are you saying you would like the commit message amended, or that the comment in the code needs to say who must set the flag, or both? Please be to the point. -- John GnuPG fingerprint: D0EC B3DB C372 D1F1 0B01 83F0 49F1 D7B2 60D4 D0F7 signature.asc Description: OpenPGP digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 1/6] lavf/movenc: add sdtp (sample dependency) box
2017-11-19 23:25 GMT+01:00 John Stebbins: > On 11/19/2017 02:12 PM, Carl Eugen Hoyos wrote: >> 2017-11-19 21:46 GMT+01:00 John Stebbins : >>> The sdtp is required by the AppleTV 4K in order to play 2160p60 video. >>> +/** >>> + * Flag is used to indicate packets that contain frames that can >>> + * be discarded by the decoder. I.e. Non-reference frames. >>> + */ >>> +#define AV_PKT_FLAG_DISPOSABLE 0x0010 >> What sets this flag? > > Encoders when encoding, demuxer when remuxing. > The subsequent patches set this flag for x264, x265, and mp4 demux. So does this patch alone work wrt the description: Does AppleTV play 4k with this patch alone? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 1/6] lavf/movenc: add sdtp (sample dependency) box
On 11/19/2017 02:12 PM, Carl Eugen Hoyos wrote: > 2017-11-19 21:46 GMT+01:00 John Stebbins: >> The sdtp is required by the AppleTV 4K in order to play 2160p60 video. >> +/** >> + * Flag is used to indicate packets that contain frames that can >> + * be discarded by the decoder. I.e. Non-reference frames. >> + */ >> +#define AV_PKT_FLAG_DISPOSABLE 0x0010 > What sets this flag? > > Encoders when encoding, demuxer when remuxing. The subsequent patches set this flag for x264, x265, and mp4 demux. -- John GnuPG fingerprint: D0EC B3DB C372 D1F1 0B01 83F0 49F1 D7B2 60D4 D0F7 signature.asc Description: OpenPGP digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 1/6] lavf/movenc: add sdtp (sample dependency) box
2017-11-19 21:46 GMT+01:00 John Stebbins: > The sdtp is required by the AppleTV 4K in order to play 2160p60 video. > +/** > + * Flag is used to indicate packets that contain frames that can > + * be discarded by the decoder. I.e. Non-reference frames. > + */ > +#define AV_PKT_FLAG_DISPOSABLE 0x0010 What sets this flag? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel