Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpegenc - reject unsupported audio streams

2018-02-26 Thread Gyan Doshi
On 2/27/2018 4:44 AM, Carl Eugen Hoyos wrote: "16 bit" seems useless to me, even more so as all other strings are the FFmpeg codec names (as opposed to generally used names) which seems a very good idea to me. 20 and 24 bit PCM DVD streams cannot be muxed, as the packet header and block

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpegenc - reject unsupported audio streams

2018-02-26 Thread Carl Eugen Hoyos
2018-02-23 6:05 GMT+01:00 Gyan Doshi : > > > On 2/23/2018 3:50 AM, Carl Eugen Hoyos wrote: >> >> >> Please also mention "mp1" and "pcm_dvd" in the log message. > > > Revised patch attached. "16 bit" seems useless to me, even more so as all other strings are the FFmpeg codec

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpegenc - reject unsupported audio streams

2018-02-26 Thread Gyan Doshi
On 2/23/2018 10:35 AM, Gyan Doshi wrote: On 2/23/2018 3:50 AM, Carl Eugen Hoyos wrote: Please also mention "mp1" and "pcm_dvd" in the log message. Revised patch attached. Ping. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpegenc - reject unsupported audio streams

2018-02-22 Thread Gyan Doshi
On 2/23/2018 3:50 AM, Carl Eugen Hoyos wrote: Please also mention "mp1" and "pcm_dvd" in the log message. Revised patch attached. From 0bb6debc91c59a10fd43dc4670bd513adab1f1e0 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Tue, 20 Feb 2018 20:42:21 +0530 Subject:

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpegenc - reject unsupported audio streams

2018-02-22 Thread Carl Eugen Hoyos
2018-02-21 7:05 GMT+01:00 Gyan Doshi : > > > On 2/21/2018 3:03 AM, Carl Eugen Hoyos wrote: >> >> 2018-02-20 16:17 GMT+01:00 Gyan Doshi : >> >> Please also mention LPCM. > > Only 16-bit LPCM BE can be muxed, which is mentioned. Sorry, above comment was not

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpegenc - reject unsupported audio streams

2018-02-22 Thread Gyan Doshi
On 2/22/2018 1:08 AM, Michael Niedermayer wrote: this looks like its missing AV_CODEC_ID_MP1 at least MP1 exception added. From be49ca276c58b515e7f8e472221203c25efc6c86 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Tue, 20 Feb 2018 20:42:21 +0530 Subject: [PATCH 2/2]

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpegenc - reject unsupported audio streams

2018-02-21 Thread Michael Niedermayer
On Tue, Feb 20, 2018 at 08:47:47PM +0530, Gyan Doshi wrote: > mpegenc.c |4 > 1 file changed, 4 insertions(+) > 1546f15d202546d69494e49a1a90a7668be9 > 0002-avformat-mpegenc-reject-unsupported-audio-streams.patch > From f0aabc7b9f959dc94084fb6d9b644104fc203566 Mon Sep 17 00:00:00

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpegenc - reject unsupported audio streams

2018-02-20 Thread Gyan Doshi
On 2/21/2018 3:03 AM, Carl Eugen Hoyos wrote: 2018-02-20 16:17 GMT+01:00 Gyan Doshi : Please also mention LPCM. Only 16-bit LPCM BE can be muxed, which is mentioned. Regards, Gyan ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpegenc - reject unsupported audio streams

2018-02-20 Thread Carl Eugen Hoyos
2018-02-20 16:17 GMT+01:00 Gyan Doshi : Please also mention LPCM. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel