Re: [FFmpeg-devel] [PATCH 2/2] decklink: Add support for output of Active Format Description (AFD)

2018-08-27 Thread Devin Heitmueller
> On Aug 26, 2018, at 11:34 AM, Marton Balint wrote: > > Hello Marton, Ok, I’ll take another pass and send an updated patch. Devin --- Devin Heitmueller - LTN Global Communications dheitmuel...@ltnglobal.com ___ ffmpeg-devel mailing list ffmpeg-d

Re: [FFmpeg-devel] [PATCH 2/2] decklink: Add support for output of Active Format Description (AFD)

2018-08-27 Thread Devin Heitmueller
Hello Vittorio, Thanks for the feedback. > > I think you should add an entry in ff_decode_frame_props() so that pkt side > data can propagate to frame side data > -- > Vittorio I’ve got a whole patch series related to capture of AFD from decklink and getting it through the pipeline (to be e

Re: [FFmpeg-devel] [PATCH 2/2] decklink: Add support for output of Active Format Description (AFD)

2018-08-27 Thread Vittorio Giovara
On Wed, Aug 22, 2018 at 9:53 PM, Devin Heitmueller < dheitmuel...@ltnglobal.com> wrote: > Implement support for including AFD in decklink output. This > includes making sure the AFD data is preserved when going from > an AVFrame to a V210 packet (needed for 10-bit support). > > Updated to reflect

Re: [FFmpeg-devel] [PATCH 2/2] decklink: Add support for output of Active Format Description (AFD)

2018-08-26 Thread Marton Balint
On Wed, 22 Aug 2018, Devin Heitmueller wrote: Implement support for including AFD in decklink output. This includes making sure the AFD data is preserved when going from an AVFrame to a V210 packet (needed for 10-bit support). Updated to reflect feedback from Marton Balint , Carl Eugen Hoyos

Re: [FFmpeg-devel] [PATCH 2/2] decklink: Add support for output of Active Format Description (AFD)

2017-11-28 Thread Devin Heitmueller
Hi Marton, Comments inline. >> +data = av_packet_get_side_data(pkt, AV_PKT_DATA_AFD, &size); >> +if (data) { >> +struct klvanc_packet_afd_s *pkt; >> +uint16_t *afd; >> +uint16_t len; >> + >> +ret = klvanc_create_AFD(&pkt); >> +if (ret != 0) >> +

Re: [FFmpeg-devel] [PATCH 2/2] decklink: Add support for output of Active Format Description (AFD)

2017-11-27 Thread Marton Balint
On Thu, 16 Nov 2017, Devin Heitmueller wrote: Implement support for including AFD in decklink output. This includes making sure the AFD data is preserved when going from an AVFrame to a V210 packet (needed for 10-bit support). Signed-off-by: Devin Heitmueller --- libavcodec/avcodec.h