Just a few comments on your review:
On Sun, 2018-02-18 at 19:01 +0100, Nicolas George wrote:
> > @@ -91,31 +94,46 @@ static av_cold int init(AVFilterContext *ctx)
> > {
> > FPSContext *s = ctx->priv;
> >
> > -if (!(s->fifo = av_fifo_alloc_array(2, sizeof(AVFrame*
> > -
Hi Nicolas,
On Sun, 2018-02-18 at 19:01 +0100, Nicolas George wrote:
>
> Thanks for the patch. It was something I had in my TODO list for a
> long
> time. The code looks very good. Here are a few comments below. Of
> course
> open to discussion.
Thanks for the review. I'm going to spend some
On 16.02.2018 21:09, calvin.wal...@kepstin.ca wrote:
Oops, I forgot to remove this bit from the changelog:
On Fri, 2018-02-16 at 15:02 -0500, Calvin Walton wrote:
TODO: This is still a work in progress. It may have different
behaviour
in some cases from the old fps filter. I have not yet
Calvin Walton (2018-02-16):
> The old version of the filter had a problem where it would queue up
> all of the duplicate frames required to fill a timestamp gap in a
> single call to filter_frame. In problematic files - I've hit this in
> webcam streams with large gaps due to network issues - this
Oops, I forgot to remove this bit from the changelog:
On Fri, 2018-02-16 at 15:02 -0500, Calvin Walton wrote:
> TODO: This is still a work in progress. It may have different
> behaviour
> in some cases from the old fps filter. I have not yet implemented the
> "eof_action" option, since I haven't
