Re: [FFmpeg-devel] [PATCH 2/4] lavfi/buffersrc: add add av_buffersrc_close().

2014-08-02 Thread Michael Niedermayer
On Wed, Jul 30, 2014 at 11:44:47PM +0200, Nicolas George wrote: Also deprecate adding a NULL frame to mark EOF. TODO APIchanges entry, version bump. Signed-off-by: Nicolas George geo...@nsup.org --- libavfilter/buffersrc.c | 40 ++--

Re: [FFmpeg-devel] [PATCH 2/4] lavfi/buffersrc: add add av_buffersrc_close().

2014-07-30 Thread Nicolas George
Le duodi 12 thermidor, an CCXXII, wm4 a écrit : The libavfilter API for EOF is ok, No, it is not. So if you're not actually fixing anything I am. What wrong result? See my first answer when you started this bikeshedding.

Re: [FFmpeg-devel] [PATCH 2/4] lavfi/buffersrc: add add av_buffersrc_close().

2014-07-30 Thread Derek Buitenhuis
On 7/30/2014 6:10 PM, Nicolas George wrote: This is tiring. Everyone knows it already and it has been explained numerous times. Yeah, why should you have to explain the reason for a change in a review of that change? How silly. I should just divine the reason why. I guess we don't count as

Re: [FFmpeg-devel] [PATCH 2/4] lavfi/buffersrc: add add av_buffersrc_close().

2014-07-29 Thread wm4
On Thu, 24 Jul 2014 15:49:33 +0200 Nicolas George geo...@nsup.org wrote: Le sextidi 6 thermidor, an CCXXII, wm4 a écrit : No, you can't do this. Yes, I can. It breaks compatibility with Libav; No, it does not. Removing it would break compatibility. Deprecating it does nothing.

Re: [FFmpeg-devel] [PATCH 2/4] lavfi/buffersrc: add add av_buffersrc_close().

2014-07-24 Thread wm4
On Thu, 24 Jul 2014 15:39:43 +0200 Nicolas George geo...@nsup.org wrote: Also deprecate adding a NULL frame to mark EOF. No, you can't do this. It breaks compatibility with Libav; also what's even the purpose of this (API) change? TODO APIchanges entry, version bump. Signed-off-by: Nicolas