Re: [FFmpeg-devel] [PATCH 2/6] vaapi: Remove H.264 baseline profile

2017-10-09 13:21 GMT+02:00 wm4 : > Shouldn't trying to decode baseline video just fall back to sw decoding? Given that software doesn't support the specific features of baseline either, I don't think this helps. I was under the impression the only sane thing to do when

Re: [FFmpeg-devel] [PATCH 2/6] vaapi: Remove H.264 baseline profile

On Sun, 8 Oct 2017 16:49:58 +0100 Mark Thompson wrote: > This has been deprecated in libva2 because hardware does not and will not > support it. Therefore never consider it for decode, and for encode assume > the user meant constrained baseline profile instead. > --- > On

Re: [FFmpeg-devel] [PATCH 2/6] vaapi: Remove H.264 baseline profile

On Sun, Oct 08, 2017 at 16:49:58 +0100, Mark Thompson wrote: > switch (avctx->profile) { > +case FF_PROFILE_H264_BASELINE: > +av_log(avctx, AV_LOG_WARNING, "H.264 baseline profile is not " > + "supported, using constrained baseline profile instead.\n"); > +

Re: [FFmpeg-devel] [PATCH 2/6] vaapi: Remove H.264 baseline profile

On 10/8/2017 4:49 PM, Mark Thompson wrote: > Yeah, ok, I agree. Patch changed as enclosing. > > > libavcodec/vaapi_decode.c | 1 - > libavcodec/vaapi_encode_h264.c | 12 > 2 files changed, 4 insertions(+), 9 deletions(-) Looks OK to me. I assume we don't care about the old

Re: [FFmpeg-devel] [PATCH 2/6] vaapi: Remove H.264 baseline profile

On 10/8/2017 4:11 PM, Mark Thompson wrote: > +case FF_PROFILE_H264_BASELINE: > +// Baseline profile is not supported, assume the user meant > +// constrained baseline instead. > +avctx->profile = FF_PROFILE_H264_CONSTRAINED_BASELINE; Trying to automatically (and