Re: [FFmpeg-devel] [PATCH 3/3][RFC] avfilter/vf_chromakey: Add OpenCL acceleration

2015-10-14 Thread Wei Gao
2015-10-14 14:31 GMT+08:00 Timo Rothenpieler : > Hi >> >> I have check the error, for some card, yes, just like what I said above, >> some cards does not support double type, so we must check the opencl >> extension: cl_khr_fp64 before the kernel compile. If the device

Re: [FFmpeg-devel] [PATCH 3/3][RFC] avfilter/vf_chromakey: Add OpenCL acceleration

2015-10-14 Thread Timo Rothenpieler
Hi I have check the error, for some card, yes, just like what I said above, some cards does not support double type, so we must check the opencl extension: cl_khr_fp64 before the kernel compile. If the device support, we use GPU, else, we use CPU or use float type, Is it OK? Thanks Best regards

Re: [FFmpeg-devel] [PATCH 3/3][RFC] avfilter/vf_chromakey: Add OpenCL acceleration

2015-10-13 Thread Timothy Gu
On Tue, Oct 13, 2015 at 3:28 AM Timo Rothenpieler wrote: > > Hi > > > > I use your filter, but the kernel can't pass the compile, you should > consider the "double" type in the kernel, some GPU card does not support > double type > > I add "#pragma OPENCL_EXTENSION

Re: [FFmpeg-devel] [PATCH 3/3][RFC] avfilter/vf_chromakey: Add OpenCL acceleration

2015-10-13 Thread highgod0401
From: Timo Rothenpieler Date: 2015-10-10 17:47 To: FFmpeg development discussions and patches CC: highgod0401 Subject: Re: [FFmpeg-devel] [PATCH 3/3][RFC] avfilter/vf_chromakey: Add OpenCL acceleration > Could you please fix it? > > Thanks > > Best regards curl https://github.

Re: [FFmpeg-devel] [PATCH 3/3][RFC] avfilter/vf_chromakey: Add OpenCL acceleration

2015-10-13 Thread Wei Gao
2015-10-13 18:27 GMT+08:00 Timo Rothenpieler : > Hi >> >> I use your filter, but the kernel can't pass the compile, you should >> consider the "double" type in the kernel, some GPU card does not support >> double type >> I add "#pragma OPENCL_EXTENSION cl_khr_fp64: enable "

Re: [FFmpeg-devel] [PATCH 3/3][RFC] avfilter/vf_chromakey: Add OpenCL acceleration

2015-10-11 Thread highgod0401
From: Timo Rothenpieler Date: 2015-10-10 17:47 To: FFmpeg development discussions and patches CC: highgod0401 Subject: Re: [FFmpeg-devel] [PATCH 3/3][RFC] avfilter/vf_chromakey: Add OpenCL acceleration > Could you please fix it? > > Thanks > > Best regards curl https://github.

Re: [FFmpeg-devel] [PATCH 3/3][RFC] avfilter/vf_chromakey: Add OpenCL acceleration

2015-10-10 Thread Timo Rothenpieler
> Could you please fix it? > > Thanks > > Best regards curl https://github.com/BtbN/FFmpeg/commit/29294c283a656cf809461cbae21d612b5a0f2159.patch | git apply That works for me, the patch is not in git format-patch format, so git am can't apply it. I also attached the two patches in

Re: [FFmpeg-devel] [PATCH 3/3][RFC] avfilter/vf_chromakey: Add OpenCL acceleration

2015-10-09 Thread Timo Rothenpieler
Using this sample: https://btbn.de/files/chromakey_sample.mp4 ffmpeg -f lavfi -i color=c=black:s=1280x720 -i chromakey_sample.mp4 -an -c:v libx264 -preset veryfast -crf 18 -shortest -filter_complex "[1:v]chromakey=0x70de77:0.1:0.2:0:1[ckout];[0:v][ckout]overlay[out]" -map "[out]" -y output.mkv

Re: [FFmpeg-devel] [PATCH 3/3][RFC] avfilter/vf_chromakey: Add OpenCL acceleration

2015-10-09 Thread highgod0401
From: Timo Rothenpieler Date: 2015-10-09 16:41 To: FFmpeg development discussions and patches CC: highgod0401 Subject: Re: [FFmpeg-devel] [PATCH 3/3][RFC] avfilter/vf_chromakey: Add OpenCL acceleration > > Using this sample: https://btbn.de/files/chromakey_sample.mp4 > > ffmpeg -f la

Re: [FFmpeg-devel] [PATCH 3/3][RFC] avfilter/vf_chromakey: Add OpenCL acceleration

2015-10-09 Thread highgod0401
From: Timo Rothenpieler Date: 2015-10-09 16:41 To: FFmpeg development discussions and patches CC: highgod0401 Subject: Re: [FFmpeg-devel] [PATCH 3/3][RFC] avfilter/vf_chromakey: Add OpenCL acceleration > > Using this sample: https://btbn.de/files/chromakey_sample.mp4 > > ffmpeg -f la

Re: [FFmpeg-devel] [PATCH 3/3][RFC] avfilter/vf_chromakey: Add OpenCL acceleration

2015-10-07 Thread highgod0401
From: Timo Rothenpieler Date: 2015-09-30 19:27 To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 3/3][RFC] avfilter/vf_chromakey: Add OpenCL acceleration >> ping once again >> >> Hi > Could you describe how to verify it, and how can I test i

Re: [FFmpeg-devel] [PATCH 3/3][RFC] avfilter/vf_chromakey: Add OpenCL acceleration

2015-09-30 Thread Timo Rothenpieler
> I'm not quite sure of what I think of this software/opencl hybrid > approach. On one hand, it's good that they share the "user interface" > (options etc.). On the other hand, the OpenCL part duplicates the > entire actual filter code. And unlike with asm, there's no good way to > test that they

Re: [FFmpeg-devel] [PATCH 3/3][RFC] avfilter/vf_chromakey: Add OpenCL acceleration

2015-09-30 Thread wm4
On Thu, 24 Sep 2015 17:12:25 +0200 Timo Rothenpieler wrote: > Signed-off-by: Timo Rothenpieler > --- > doc/filters.texi | 5 + > libavfilter/chromakey_opencl_kernel.h | 98 +++ >

Re: [FFmpeg-devel] [PATCH 3/3][RFC] avfilter/vf_chromakey: Add OpenCL acceleration

2015-09-30 Thread Timo Rothenpieler
>> ping once again >> >> Hi > Could you describe how to verify it, and how can I test it? > > Thanks > Best regards > Using this sample: https://btbn.de/files/chromakey_sample.mp4 ffmpeg -f lavfi -i color=c=black:s=1280x720 -i chromakey_sample.mp4 -an -c:v libx264 -preset veryfast -crf 18

Re: [FFmpeg-devel] [PATCH 3/3][RFC] avfilter/vf_chromakey: Add OpenCL acceleration

2015-09-29 Thread Timo Rothenpieler
> Signed-off-by: Timo Rothenpieler > --- > doc/filters.texi | 5 + > libavfilter/chromakey_opencl_kernel.h | 98 +++ > libavfilter/opencl_allkernels.c | 2 + > libavfilter/vf_chromakey.c| 179 >