Re: [FFmpeg-devel] [PATCH 4/4] lavc/qsvenc_h264: remove the privite option trellis

2019-03-27 Thread Carl Eugen Hoyos
2019-03-27 15:51 GMT+01:00, Moritz Barsnick :
> On Wed, Mar 27, 2019 at 20:51:47 +0800, Zhong Li wrote:
>> Just simply remove the private option, and switch to the AVCodecContext
>> definition. Compatibility should not a big problem (expect can't exact
>> map)
>> since the option name is same as AVCodecContext.
>
> You should probably bump libavcodec's micro version if the option
> mapping changes.

+1

Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 4/4] lavc/qsvenc_h264: remove the privite option trellis

2019-03-27 Thread Moritz Barsnick
On Wed, Mar 27, 2019 at 20:51:47 +0800, Zhong Li wrote:
> Just simply remove the private option, and switch to the AVCodecContext
> definition. Compatibility should not a big problem (expect can't exact map)
> since the option name is same as AVCodecContext.

You should probably bump libavcodec's micro version if the option
mapping changes.

Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".