Re: [FFmpeg-devel] [PATCH 5/5] avformat/avc: support writting more than one sps/pps in ff_isom_write_avcc
On 11/29/2017 9:58 PM, Michael Niedermayer wrote: > On Tue, Nov 28, 2017 at 10:43:03PM -0300, James Almer wrote: >> Addresses ticket #6864 >> >> Signed-off-by: James Almer >> --- >> I don't have the h264 in isobmff spec at hand, so i just looked at what >> the h264_mp4toannexb bsf does to handle more than one sps and pps and >> worked with that. >> If there's a pps limit it's not currently enforced, but adding it is >> trivial. The sps limit i added is arbitrarily 2^5-1, as that's the >> amount of bits available for it. > > theres H264_MAX_PPS_COUNT and H264_MAX_SPS_COUNT Exactly 5 and 8 bits each, so that's pretty much it. Thanks. > > >> >> libavformat/avc.c | 50 +- >> 1 file changed, 37 insertions(+), 13 deletions(-) > > LGTM, someone should check it against the spec thhough Pushed. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 5/5] avformat/avc: support writting more than one sps/pps in ff_isom_write_avcc
On Tue, Nov 28, 2017 at 10:43:03PM -0300, James Almer wrote: > Addresses ticket #6864 > > Signed-off-by: James Almer > --- > I don't have the h264 in isobmff spec at hand, so i just looked at what > the h264_mp4toannexb bsf does to handle more than one sps and pps and > worked with that. > If there's a pps limit it's not currently enforced, but adding it is > trivial. The sps limit i added is arbitrarily 2^5-1, as that's the > amount of bits available for it. theres H264_MAX_PPS_COUNT and H264_MAX_SPS_COUNT > > libavformat/avc.c | 50 +- > 1 file changed, 37 insertions(+), 13 deletions(-) LGTM, someone should check it against the spec thhough [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I have never wished to cater to the crowd; for what I know they do not approve, and what they approve I do not know. -- Epicurus signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
