Re: [FFmpeg-devel] [PATCH 5/6] Add suppoort for using libklvanc from within decklink capture module

On 11/29/2017 7:17 PM, Devin Heitmueller wrote: >> Is there a reason we shouldn't fail hard here? > > Not really. The parser will log an error if the callback returns a nonzero > value, but beyond the return value isn’t actively used. That said, no > objection to having it return -1 for

Re: [FFmpeg-devel] [PATCH 5/6] Add suppoort for using libklvanc from within decklink capture module

Hello James, Thanks for reviewing. >> +afd[0] = pkt->hdr.payload[0] >> 3; >> +if (av_packet_add_side_data(cb_ctx->pkt, AV_PKT_DATA_AFD, afd, 1) < 0) >> +av_free(afd); > > For this, av_packet_new_side_data() seems more adequate than av_malloc() > + av_packet_add_side_data(). > >

Re: [FFmpeg-devel] [PATCH 5/6] Add suppoort for using libklvanc from within decklink capture module

Hello Derek, Comments inline. >> >> +afd[0] = pkt->hdr.payload[0] >> 3; >> +if (av_packet_add_side_data(cb_ctx->pkt, AV_PKT_DATA_AFD, afd, 1) < 0) >> +av_free(afd); > > Is there a reason we shouldn't fail hard here? Not really. The parser will log an error if the callback

Re: [FFmpeg-devel] [PATCH 5/6] Add suppoort for using libklvanc from within decklink capture module

On 11/16/2017 3:34 PM, Devin Heitmueller wrote: > Make use of libklvanc from within the decklink capture module, > initially for EIA-708 and AFD. Support for other VANC types will > come in subsequent patches. > > Signed-off-by: Devin Heitmueller > --- >

Re: [FFmpeg-devel] [PATCH 5/6] Add suppoort for using libklvanc from within decklink capture module

On 11/16/2017 6:34 PM, Devin Heitmueller wrote: > Make use of libklvanc from within the decklink capture module, > initially for EIA-708 and AFD. Support for other VANC types will > come in subsequent patches. > > Signed-off-by: Devin Heitmueller > --- >