Re: [FFmpeg-devel] [PATCH v1 1/2] avformat/libsrt: change tlpktdrop, nakreport, messageapi options to boolean type

2019-12-06 Thread Michael Niedermayer 
On Fri, Sep 20, 2019 at 07:17:27PM +0800, lance.lmw...@gmail.com wrote:
> From: Limin Wang 
> 
> Signed-off-by: Limin Wang 
> ---
>  libavformat/libsrt.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

will apply

thx

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

During times of universal deceit, telling the truth becomes a
revolutionary act. -- George Orwell


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v1 1/2] avformat/libsrt: change tlpktdrop, nakreport, messageapi options to boolean type

2019-12-04 Thread Limin Wang 

ping the very old patch, please review and push it. 

On Fri, Sep 20, 2019 at 07:17:27PM +0800, lance.lmw...@gmail.com wrote:
> From: Limin Wang 
> 
> Signed-off-by: Limin Wang 
> ---
>  libavformat/libsrt.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c
> index b5568089fa..2fc6328c4e 100644
> --- a/libavformat/libsrt.c
> +++ b/libavformat/libsrt.c
> @@ -111,8 +111,8 @@ static const AVOption libsrt_options[] = {
>  { "tsbpddelay", "deprecated, same effect as latency option", 
>OFFSET(latency),  AV_OPT_TYPE_INT64, { .i64 = -1 
> }, -1, INT64_MAX, .flags = D|E },
>  { "rcvlatency", "receive latency",   
>OFFSET(rcvlatency),   AV_OPT_TYPE_INT64, { .i64 = -1 
> }, -1, INT64_MAX, .flags = D|E },
>  { "peerlatency","peer latency",  
>OFFSET(peerlatency),  AV_OPT_TYPE_INT64, { .i64 = -1 
> }, -1, INT64_MAX, .flags = D|E },
> -{ "tlpktdrop",  "Enable receiver pkt drop",  
>OFFSET(tlpktdrop),AV_OPT_TYPE_INT,  { .i64 = 
> -1 }, -1, 1, .flags = D|E },
> -{ "nakreport",  "Enable receiver to send periodic NAK reports",  
>OFFSET(nakreport),AV_OPT_TYPE_INT,  { .i64 = 
> -1 }, -1, 1, .flags = D|E },
> +{ "tlpktdrop",  "Enable receiver pkt drop",  
>OFFSET(tlpktdrop),AV_OPT_TYPE_BOOL,  { .i64 = 
> -1 }, -1, 1, .flags = D|E },
> +{ "nakreport",  "Enable receiver to send periodic NAK reports",  
>OFFSET(nakreport),AV_OPT_TYPE_BOOL,  { .i64 = 
> -1 }, -1, 1, .flags = D|E },
>  { "connect_timeout", "Connect timeout. Caller default: 3000, rendezvous 
> (x 10)",OFFSET(connect_timeout),  AV_OPT_TYPE_INT64, { .i64 = -1 
> }, -1, INT64_MAX, .flags = D|E },
>  { "mode",   "Connection mode (caller, listener, rendezvous)",
>OFFSET(mode), AV_OPT_TYPE_INT,  { .i64 = 
> SRT_MODE_CALLER }, SRT_MODE_CALLER, SRT_MODE_RENDEZVOUS, .flags = D|E, "mode" 
> },
>  { "caller", NULL, 0, AV_OPT_TYPE_CONST,  { .i64 = 
> SRT_MODE_CALLER }, INT_MIN, INT_MAX, .flags = D|E, "mode" },
> @@ -124,7 +124,7 @@ static const AVOption libsrt_options[] = {
>  { "minversion", "The minimum SRT version that is required from the 
> peer",   OFFSET(minversion),   AV_OPT_TYPE_INT,  { .i64 = 
> -1 }, -1, INT_MAX,   .flags = D|E },
>  { "streamid",   "A string of up to 512 characters that an Initiator 
> can pass to a Responder",  OFFSET(streamid),  AV_OPT_TYPE_STRING,   { .str = 
> NULL },  .flags = D|E },
>  { "smoother",   "The type of Smoother used for the transmission for 
> that socket",   OFFSET(smoother), AV_OPT_TYPE_STRING,   { .str = 
> NULL },  .flags = D|E },
> -{ "messageapi", "Enable message API",
>OFFSET(messageapi),   AV_OPT_TYPE_INT,  { .i64 = 
> -1 }, -1, 1, .flags = D|E },
> +{ "messageapi", "Enable message API",
>OFFSET(messageapi),   AV_OPT_TYPE_BOOL, { .i64 = 
> -1 }, -1, 1, .flags = D|E },
>  { "transtype",  "The transmission type for the socket",  
>OFFSET(transtype),AV_OPT_TYPE_INT,  { .i64 = 
> SRTT_INVALID }, SRTT_LIVE, SRTT_INVALID, .flags = D|E, "transtype" },
>  { "live",   NULL, 0, AV_OPT_TYPE_CONST,  { .i64 = SRTT_LIVE }, 
> INT_MIN, INT_MAX, .flags = D|E, "transtype" },
>  { "file",   NULL, 0, AV_OPT_TYPE_CONST,  { .i64 = SRTT_FILE }, 
> INT_MIN, INT_MAX, .flags = D|E, "transtype" },
> -- 
> 2.21.0
> 
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v1 1/2] avformat/libsrt: change tlpktdrop, nakreport, messageapi options to boolean type

2019-09-29 Thread Limin Wang 

ping.

On Fri, Sep 20, 2019 at 07:17:27PM +0800, lance.lmw...@gmail.com wrote:
> From: Limin Wang 
> 
> Signed-off-by: Limin Wang 
> ---
>  libavformat/libsrt.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c
> index b5568089fa..2fc6328c4e 100644
> --- a/libavformat/libsrt.c
> +++ b/libavformat/libsrt.c
> @@ -111,8 +111,8 @@ static const AVOption libsrt_options[] = {
>  { "tsbpddelay", "deprecated, same effect as latency option", 
>OFFSET(latency),  AV_OPT_TYPE_INT64, { .i64 = -1 
> }, -1, INT64_MAX, .flags = D|E },
>  { "rcvlatency", "receive latency",   
>OFFSET(rcvlatency),   AV_OPT_TYPE_INT64, { .i64 = -1 
> }, -1, INT64_MAX, .flags = D|E },
>  { "peerlatency","peer latency",  
>OFFSET(peerlatency),  AV_OPT_TYPE_INT64, { .i64 = -1 
> }, -1, INT64_MAX, .flags = D|E },
> -{ "tlpktdrop",  "Enable receiver pkt drop",  
>OFFSET(tlpktdrop),AV_OPT_TYPE_INT,  { .i64 = 
> -1 }, -1, 1, .flags = D|E },
> -{ "nakreport",  "Enable receiver to send periodic NAK reports",  
>OFFSET(nakreport),AV_OPT_TYPE_INT,  { .i64 = 
> -1 }, -1, 1, .flags = D|E },
> +{ "tlpktdrop",  "Enable receiver pkt drop",  
>OFFSET(tlpktdrop),AV_OPT_TYPE_BOOL,  { .i64 = 
> -1 }, -1, 1, .flags = D|E },
> +{ "nakreport",  "Enable receiver to send periodic NAK reports",  
>OFFSET(nakreport),AV_OPT_TYPE_BOOL,  { .i64 = 
> -1 }, -1, 1, .flags = D|E },
>  { "connect_timeout", "Connect timeout. Caller default: 3000, rendezvous 
> (x 10)",OFFSET(connect_timeout),  AV_OPT_TYPE_INT64, { .i64 = -1 
> }, -1, INT64_MAX, .flags = D|E },
>  { "mode",   "Connection mode (caller, listener, rendezvous)",
>OFFSET(mode), AV_OPT_TYPE_INT,  { .i64 = 
> SRT_MODE_CALLER }, SRT_MODE_CALLER, SRT_MODE_RENDEZVOUS, .flags = D|E, "mode" 
> },
>  { "caller", NULL, 0, AV_OPT_TYPE_CONST,  { .i64 = 
> SRT_MODE_CALLER }, INT_MIN, INT_MAX, .flags = D|E, "mode" },
> @@ -124,7 +124,7 @@ static const AVOption libsrt_options[] = {
>  { "minversion", "The minimum SRT version that is required from the 
> peer",   OFFSET(minversion),   AV_OPT_TYPE_INT,  { .i64 = 
> -1 }, -1, INT_MAX,   .flags = D|E },
>  { "streamid",   "A string of up to 512 characters that an Initiator 
> can pass to a Responder",  OFFSET(streamid),  AV_OPT_TYPE_STRING,   { .str = 
> NULL },  .flags = D|E },
>  { "smoother",   "The type of Smoother used for the transmission for 
> that socket",   OFFSET(smoother), AV_OPT_TYPE_STRING,   { .str = 
> NULL },  .flags = D|E },
> -{ "messageapi", "Enable message API",
>OFFSET(messageapi),   AV_OPT_TYPE_INT,  { .i64 = 
> -1 }, -1, 1, .flags = D|E },
> +{ "messageapi", "Enable message API",
>OFFSET(messageapi),   AV_OPT_TYPE_BOOL, { .i64 = 
> -1 }, -1, 1, .flags = D|E },
>  { "transtype",  "The transmission type for the socket",  
>OFFSET(transtype),AV_OPT_TYPE_INT,  { .i64 = 
> SRTT_INVALID }, SRTT_LIVE, SRTT_INVALID, .flags = D|E, "transtype" },
>  { "live",   NULL, 0, AV_OPT_TYPE_CONST,  { .i64 = SRTT_LIVE }, 
> INT_MIN, INT_MAX, .flags = D|E, "transtype" },
>  { "file",   NULL, 0, AV_OPT_TYPE_CONST,  { .i64 = SRTT_FILE }, 
> INT_MIN, INT_MAX, .flags = D|E, "transtype" },
> -- 
> 2.21.0
> 
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".