Re: [FFmpeg-devel] [PATCH v2 6/8] avfilter/silencedetect: fix for ticket 6968 Fix missing log of silence_end at end of stream

2018-02-13 Thread Gaullier Nicolas
> +av_ts2timestr(duration_ts, &stime_base)); ^ this does not build, and looks like a typo Sorry, this is ugly, I had indeed replaced manually two occurrences (s->time_base => &time_base) at the last minute just before

Re: [FFmpeg-devel] [PATCH v2 6/8] avfilter/silencedetect: fix for ticket 6968 Fix missing log of silence_end at end of stream

2018-02-13 Thread Michael Niedermayer
On Mon, Feb 12, 2018 at 10:48:28AM +0100, Nicolas Gaullier wrote: > From: nicolas gaullier > > --- > libavfilter/af_silencedetect.c | 33 +++-- > 1 file changed, 27 insertions(+), 6 deletions(-) > > diff --git a/libavfilter/af_silencedetect.c b/libavfilter/af_silence

Re: [FFmpeg-devel] [PATCH v2 6/8] avfilter/silencedetect: fix for ticket 6968 Fix missing log of silence_end at end of stream

2018-02-12 Thread Carl Eugen Hoyos
2018-02-12 16:33 GMT+01:00 Gaullier Nicolas : > Here, the "fix for ticket 6968" should be the header, so I think the format > is correct ? I simply missed it, but a better alternative is: lavfi/silencedetect: Fix missing log at eos. Fixes ticket #6968. Carl Eugen ___

Re: [FFmpeg-devel] [PATCH v2 6/8] avfilter/silencedetect: fix for ticket 6968 Fix missing log of silence_end at end of stream

2018-02-12 Thread Gaullier Nicolas
this issue! Nicolas Gaullier -Message d'origine- De : ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] De la part de Carl Eugen Hoyos Envoyé : lundi 12 février 2018 14:52 À : FFmpeg development discussions and patches Objet : Re: [FFmpeg-devel] [PATCH v2 6/8] avfilter/silencedet

Re: [FFmpeg-devel] [PATCH v2 6/8] avfilter/silencedetect: fix for ticket 6968 Fix missing log of silence_end at end of stream

2018-02-12 Thread Carl Eugen Hoyos
2018-02-12 10:48 GMT+01:00 Nicolas Gaullier : > From: nicolas gaullier Please mention ticket #6968 in the commit message if it is related. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel