Re: [FFmpeg-devel] [PATCH v4 2/2] libavcodec/libaomenc.c: Support lossless encoding

2020-06-06 Thread Kieran O Leary
Hi all - just wondering about the status of this. I was doing some tests
with just -crf 0 with mixed results before I saw this thread.
http://ffmpeg.org/pipermail/ffmpeg-user/2020-June/048885.html

K
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v4 2/2] libavcodec/libaomenc.c: Support lossless encoding

2020-04-21 Thread James Zern
On Fri, Apr 17, 2020 at 9:57 AM Ryo Hirafuji  wrote:
>
> I see, Thanks.
> I'm looking forward to the answer.
>

There is some benefit to using cq-level as many of the encoder
decisions are based on this (reference frame structure, speed
features, etc) and so it's better tuned than quality mode. In both
cases the output is lossless so either will work, but given the
structure of the options to the library it might make sense to match
vp9 in libvpxenc.c and use cq-level.

> (If you are OK, please CC to me. I also would like to know about lossless
> mode in libaom, because I also use my software)
>

Sorry, I missed this comment. I don't have any results that would be
visible publicly.

> 2020年4月15日(水) 10:00 James Zern :
>
> > On Tue, Apr 7, 2020 at 5:14 PM Ryo Hirafuji 
> > wrote:
> > >
> > > From: Ryo Hirafuji 
> > >
> > > AV1 support lossless encoding.
> > > In this patch, I added a command line flag to enable it.
> > >
> > > Fixes ticket #7600
> > > ---
> > >  libavcodec/libaomenc.c | 14 +++---
> > >  1 file changed, 11 insertions(+), 3 deletions(-)
> > >
> > > [...]
> > > @@ -574,7 +577,9 @@ static av_cold int aom_init(AVCodecContext *avctx,
> > >  if (avctx->rc_min_rate == avctx->rc_max_rate &&
> > >  avctx->rc_min_rate == avctx->bit_rate && avctx->bit_rate) {
> > >  enccfg.rc_end_usage = AOM_CBR;
> > > -} else if (ctx->crf >= 0) {
> > > +} else if (ctx->crf == 0) {
> > > +enccfg.rc_end_usage = AOM_Q;
> >
> > I saw the earlier comments around using crf=0 as the trigger for this.
> > libaom will behave differently with q vs cq mode. This also differs
> > from the -lossless in libvpxenc where this feature originated; mostly
> > we've been mapping options one to one with vpx/aomenc. Let me ask
> > around about the preference for lossless usage in libaom.
> > ___
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v4 2/2] libavcodec/libaomenc.c: Support lossless encoding

2020-04-17 Thread Ryo Hirafuji
I see, Thanks.
I'm looking forward to the answer.

(If you are OK, please CC to me. I also would like to know about lossless
mode in libaom, because I also use my software)

2020年4月15日(水) 10:00 James Zern :

> On Tue, Apr 7, 2020 at 5:14 PM Ryo Hirafuji 
> wrote:
> >
> > From: Ryo Hirafuji 
> >
> > AV1 support lossless encoding.
> > In this patch, I added a command line flag to enable it.
> >
> > Fixes ticket #7600
> > ---
> >  libavcodec/libaomenc.c | 14 +++---
> >  1 file changed, 11 insertions(+), 3 deletions(-)
> >
> > [...]
> > @@ -574,7 +577,9 @@ static av_cold int aom_init(AVCodecContext *avctx,
> >  if (avctx->rc_min_rate == avctx->rc_max_rate &&
> >  avctx->rc_min_rate == avctx->bit_rate && avctx->bit_rate) {
> >  enccfg.rc_end_usage = AOM_CBR;
> > -} else if (ctx->crf >= 0) {
> > +} else if (ctx->crf == 0) {
> > +enccfg.rc_end_usage = AOM_Q;
>
> I saw the earlier comments around using crf=0 as the trigger for this.
> libaom will behave differently with q vs cq mode. This also differs
> from the -lossless in libvpxenc where this feature originated; mostly
> we've been mapping options one to one with vpx/aomenc. Let me ask
> around about the preference for lossless usage in libaom.
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v4 2/2] libavcodec/libaomenc.c: Support lossless encoding

2020-04-14 Thread James Zern
On Tue, Apr 7, 2020 at 5:14 PM Ryo Hirafuji  wrote:
>
> From: Ryo Hirafuji 
>
> AV1 support lossless encoding.
> In this patch, I added a command line flag to enable it.
>
> Fixes ticket #7600
> ---
>  libavcodec/libaomenc.c | 14 +++---
>  1 file changed, 11 insertions(+), 3 deletions(-)
>
> [...]
> @@ -574,7 +577,9 @@ static av_cold int aom_init(AVCodecContext *avctx,
>  if (avctx->rc_min_rate == avctx->rc_max_rate &&
>  avctx->rc_min_rate == avctx->bit_rate && avctx->bit_rate) {
>  enccfg.rc_end_usage = AOM_CBR;
> -} else if (ctx->crf >= 0) {
> +} else if (ctx->crf == 0) {
> +enccfg.rc_end_usage = AOM_Q;

I saw the earlier comments around using crf=0 as the trigger for this.
libaom will behave differently with q vs cq mode. This also differs
from the -lossless in libvpxenc where this feature originated; mostly
we've been mapping options one to one with vpx/aomenc. Let me ask
around about the preference for lossless usage in libaom.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".