Re: [FFmpeg-devel] [mov] When both edit list and start padding present, take maximum.

2017-10-20 Thread Michael Niedermayer
On Wed, Oct 18, 2017 at 04:23:04PM -0700, Sasi Inguva wrote: > Patch LGTM. Thanks. will apply thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Take away the freedom of one citizen and you will be jailed, take away the freedom of all citizens and you will

Re: [FFmpeg-devel] [mov] When both edit list and start padding present, take maximum.

2017-10-18 Thread Sasi Inguva
Patch LGTM. Thanks. On Wed, Oct 18, 2017 at 4:14 PM, Dale Curtis wrote: > On Wed, Oct 18, 2017 at 4:00 PM, Sasi Inguva wrote: > >> Thanks for the patch. The bug is because mov_fix_index updates >> skip_samples correctly, but not start_pad. Can you

Re: [FFmpeg-devel] [mov] When both edit list and start padding present, take maximum.

2017-10-18 Thread Dale Curtis
On Wed, Oct 18, 2017 at 4:00 PM, Sasi Inguva wrote: > Thanks for the patch. The bug is because mov_fix_index updates > skip_samples correctly, but not start_pad. Can you instead of taking the > max, just update the mov_fix_index function so that start_pad = > skip_samples

Re: [FFmpeg-devel] [mov] When both edit list and start padding present, take maximum.

2017-10-18 Thread Sasi Inguva
Thanks for the patch. The bug is because mov_fix_index updates skip_samples correctly, but not start_pad. Can you instead of taking the max, just update the mov_fix_index function so that start_pad = skip_samples always. Something like this diff --git a/libavformat/mov.c b/libavformat/mov.c index

Re: [FFmpeg-devel] [mov] When both edit list and start padding present, take maximum.

2017-10-17 Thread Michael Niedermayer
On Mon, Oct 16, 2017 at 02:22:45PM -0700, Dale Curtis wrote: > Previously the start padding was used to blindly overwrite any skip samples > which may have come from an edit list. Instead take the maximum of the two. > > A new fate test is added, fate-mov-440hz-10ms, to ensure this is handled >

Re: [FFmpeg-devel] [mov] When both edit list and start padding present, take maximum.

2017-10-16 Thread Dale Curtis
More details on the issue which uncovered this can be seen here https://bugs.chromium.org/p/chromium/issues/detail?id=775042#c13 - dale On Mon, Oct 16, 2017 at 2:22 PM, Dale Curtis wrote: > Previously the start padding was used to blindly overwrite any skip > samples