Re: [FFmpeg-devel] Add on-the-fly bitrate adjustment for encoding
On Thu, Oct 10, 2019 at 09:24:08AM -0700, Adrian Cable wrote: > This is an addition to ffmpeg.c which enables on-the-fly encoder (e.g. H.264) > bitrate adjustment using ffmpeg interactive mode. For example, specify “-b:v > 299k -bufsize 299k” on the command line to start encoding at 299kbit/sec, > then to adjust the encoder bitrate to 200kbit/sec during encoding, type: > > > > r20 > > > > -Adrian > > ffmpeg.c | 40 > 1 file changed, 40 insertions(+) > 6c4ba49bdd422993c402395158f9fdbbfd20feb9 > 0001-Support-on-the-fly-encoder-bitrate-adjustment-using-.patch > From ba2ee84e34bc57c42203a1f7329ab72e4f19ce02 Mon Sep 17 00:00:00 2001 > From: Adrian Cable > Date: Thu, 10 Oct 2019 09:17:42 -0700 > Subject: [PATCH] Support on-the-fly encoder bitrate adjustment using ffmpeg > interactive mode I think if this is supported it should not be limited to just changing the bitrate. Also it needs to be ensured that the used encoder and muxer can handle such a change thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Its not that you shouldnt use gotos but rather that you should write readable code and code with gotos often but not always is less readable signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] Add on-the-fly bitrate adjustment for encoding
Kieran et al. - understand your comments - feel free to reject the patch. -Adrian On 10/11/19, 7:52 AM, "ffmpeg-devel on behalf of Kieran Kunhya" wrote: On Fri, 11 Oct 2019 at 10:16, Moritz Barsnick wrote: > On Thu, Oct 10, 2019 at 09:24:08 -0700, Adrian Cable wrote: > > This is an addition to ffmpeg.c which enables on-the-fly encoder (e.g. > H.264) bitrate adjustment using ffmpeg interactive mode. For example, > specify “-b:v 299k -bufsize 299k” on the command line to start encoding at > 299kbit/sec, then to adjust the encoder bitrate to 200kbit/sec during > encoding, type > I really think this is a bad idea. You should be using the API for this. Soon we will have every feature reconfigurable from the CLI, it will be unmaintainable. Kieran ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] Add on-the-fly bitrate adjustment for encoding
On Fri, 11 Oct 2019 at 10:16, Moritz Barsnick wrote: > On Thu, Oct 10, 2019 at 09:24:08 -0700, Adrian Cable wrote: > > This is an addition to ffmpeg.c which enables on-the-fly encoder (e.g. > H.264) bitrate adjustment using ffmpeg interactive mode. For example, > specify “-b:v 299k -bufsize 299k” on the command line to start encoding at > 299kbit/sec, then to adjust the encoder bitrate to 200kbit/sec during > encoding, type > I really think this is a bad idea. You should be using the API for this. Soon we will have every feature reconfigurable from the CLI, it will be unmaintainable. Kieran ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] Add on-the-fly bitrate adjustment for encoding
On Thu, Oct 10, 2019 at 09:24:08 -0700, Adrian Cable wrote: > This is an addition to ffmpeg.c which enables on-the-fly encoder (e.g. H.264) > bitrate adjustment using ffmpeg interactive mode. For example, specify “-b:v > 299k -bufsize 299k” on the command line to start encoding at 299kbit/sec, > then to adjust the encoder bitrate to 200kbit/sec during encoding, type: Just from a quick attempt and check: - Doesn't prompt properly like the other commands do. (Did you model the code against those implementations? I didn't compare.) I think the input "prompt" appears on top of the default progress output, which is highly confusing. - Doesn't parse bitrates like the command line does (e.g. "3M"). I believe the command line uses av_strtod(). - What are the side effects? Will metadata be incorrect? - Documentation is missing. Cheers, Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
