Re: [FFmpeg-devel] avdevice/sdl output : fix window_size and add new option (WIP)

2018-05-19 Thread Martin Vignali
>
> Thanks for comments and testing.
> Dropped the window_pos patch.
>
> New patch in attach :
> - 001 : Fix -window_size option --> Unchanged patch
> - 002 : Add option to disable quit action : Add doc
>
>
> Pushed

Martin
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] avdevice/sdl output : fix window_size and add new option (WIP)

2018-05-08 Thread Martin Vignali
2018-04-20 22:24 GMT+02:00 Moritz Barsnick :

> On Sun, Apr 08, 2018 at 17:28:24 +0200, Martin Vignali wrote:
>
> > - 001 : Fix -window_size option
> > Before this patch, window_size is always set to the source size
> > In other word, -window_size option have no effect.
>
> Makes sense, since the option was already there.
>
> > - 002 : Add option to set the position of the window
> > the default behaviour doesn't change (set the position to undefined)
>
> A -window_size syntax such as 1024x768+100+100 would seem intuitive to
> me (old Unix/X11 user), but perhaps that's just me, and I guess
> AV_OPT_TYPE_IMAGE_SIZE doesn't support that.
>
> > Comments Welcome
>
> -window_size: works for me
> -window_enable_quit 0: works for me
> -window_pos_x/-window_pos_y: doesn't work for me, but I can only test
>  remote X11 (Xwayland) via ssh
>
>
>
Thanks for comments and testing.
Dropped the window_pos patch.

New patch in attach :
- 001 : Fix -window_size option --> Unchanged patch
- 002 : Add option to disable quit action : Add doc

Martin


0001-avdevice-sdl2output-fix-setting-window_size.patch
Description: Binary data


0002-avdevice-sdl2-add-option-to-define-if-the-window-qui.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] avdevice/sdl output : fix window_size and add new option (WIP)

2018-04-20 Thread Moritz Barsnick
On Sun, Apr 08, 2018 at 17:28:24 +0200, Martin Vignali wrote:

> - 001 : Fix -window_size option
> Before this patch, window_size is always set to the source size
> In other word, -window_size option have no effect.

Makes sense, since the option was already there.

> - 002 : Add option to set the position of the window
> the default behaviour doesn't change (set the position to undefined)

A -window_size syntax such as 1024x768+100+100 would seem intuitive to
me (old Unix/X11 user), but perhaps that's just me, and I guess
AV_OPT_TYPE_IMAGE_SIZE doesn't support that.

> Comments Welcome

-window_size: works for me
-window_enable_quit 0: works for me
-window_pos_x/-window_pos_y: doesn't work for me, but I can only test
 remote X11 (Xwayland) via ssh

Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] avdevice/sdl output : fix window_size and add new option (WIP)

2018-04-14 Thread Martin Vignali
2018-04-08 17:28 GMT+02:00 Martin Vignali :

> Hello,
>
> In attach patchs to improve SDL Output device
> (Missing doc update)
>
> - 001 : Fix -window_size option
> Before this patch, window_size is always set to the source size
> In other word, -window_size option have no effect.
>
> To test :
> ./ffmpeg -f lavfi -i smptehdbars=hd1080 -c:v rawvideo -pix_fmt yuv420p
> -window_size 1024x576 -f sdl "SDL output with Custom Size"
>
> - 002 : Add option to set the position of the window
> the default behaviour doesn't change (set the position to undefined)
>
> To test :
> ./ffmpeg -f lavfi -i smptehdbars=hd1080 -c:v rawvideo -pix_fmt yuv420p
> -window_size 1024x576 -window_pos_x 30 -window_pos_y 100 -f sdl "SDL output
> With Custom size pos"
>
> - 003 : Add option to disable quit action
> Without this patch, the window can be close by the user
> if this new option is set, the window can't be close (by "close" window
> btn, escape, or "q")
> The default behaviour doesn't change
>
> To test :
> ./ffmpeg -re -f lavfi -i smptehdbars=hd1080:duration=10 -c:v rawvideo
> -pix_fmt yuv420p -window_enable_quit 0 -f sdl "SDL output Without Quit"
>
>
>
Ping

Martin
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel