Re: [FFmpeg-devel] avformat/mpegts: set AV_DISPOSITION_DESCRIPTIONS for OIPF cases

That is great - thank you. Regards, *Łukasz Krzciuk* Developer Vewd ul. Grabarska 2, Pegaz 2A, 50-079 Wrocław, Polska On Mon, May 21, 2018 at 10:06 PM, Aman Gupta wrote: > On Sun, May 20, 2018 at 11:09 PM, Łukasz Krzciuk > wrote: > > > Any updates on

Re: [FFmpeg-devel] avformat/mpegts: set AV_DISPOSITION_DESCRIPTIONS for OIPF cases

On Sun, May 20, 2018 at 11:09 PM, Łukasz Krzciuk wrote: > Any updates on this issue? > I believe that this patch was already merged: https://github.com/FFmpeg/FFmpeg/commit/48330500efd636b1540002b600257d8802badc69 > > Regards, > > *Łukasz Krzciuk* > Developer > > Vewd > ul.

Re: [FFmpeg-devel] avformat/mpegts: set AV_DISPOSITION_DESCRIPTIONS for OIPF cases

Any updates on this issue? Regards, *Łukasz Krzciuk* Developer Vewd ul. Grabarska 2, Pegaz 2A, 50-079 Wrocław, Polska On Tue, May 15, 2018 at 12:51 PM, Łukasz Krzciuk wrote: > I have prepared a testcase. PMT data comes from org.hbbtv_HTML50420 - I > have squashed them and

Re: [FFmpeg-devel] avformat/mpegts: set AV_DISPOSITION_DESCRIPTIONS for OIPF cases

I have prepared a testcase. PMT data comes from org.hbbtv_HTML50420 - I have squashed them and there is one file attached now. Please review. Regards, *Łukasz Krzciuk* Developer Vewd ul. Grabarska 2, Pegaz 2A, 50-079 Wrocław, Polska On Mon, May 14, 2018 at 10:23 AM, Łukasz Krzciuk

Re: [FFmpeg-devel] avformat/mpegts: set AV_DISPOSITION_DESCRIPTIONS for OIPF cases

I have prepared a testcase. PMT data comes from org.hbbtv_HTML50420. Please review. Regards, *Łukasz Krzciuk* Developer Vewd ul. Grabarska 2, Pegaz 2A, 50-079 Wrocław, Polska On Thu, May 10, 2018 at 8:54 PM, Aman Gupta wrote: > On Thu, May 10, 2018 at 1:46 AM Łukasz Krzciuk

Re: [FFmpeg-devel] avformat/mpegts: set AV_DISPOSITION_DESCRIPTIONS for OIPF cases

On Thu, May 10, 2018 at 1:46 AM Łukasz Krzciuk wrote: > Lets skip a testcase. It will be not easy to me to prepare it. It should be simple to extract a small sample containing the PMT. If you link some larger samples I can help extract the relevant bytes for test case. Aman

Re: [FFmpeg-devel] avformat/mpegts: set AV_DISPOSITION_DESCRIPTIONS for OIPF cases

Lets skip a testcase. It will be not easy to me to prepare it. Regards, *Łukasz Krzciuk* Developer Vewd ul. Grabarska 2, Pegaz 2A, 50-079 Wrocław, Polska On Thu, May 10, 2018 at 3:09 AM, Michael Niedermayer wrote: > On Wed, May 09, 2018 at 10:19:26AM +0200, Łukasz

Re: [FFmpeg-devel] avformat/mpegts: set AV_DISPOSITION_DESCRIPTIONS for OIPF cases

On Wed, May 09, 2018 at 10:19:26AM +0200, Łukasz Krzciuk wrote: > Any updates on this issue? about adding a testcase ? adding a huge sample file is not possible. It either has to be made smaller or generated by a muxer or last resort, no test [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] avformat/mpegts: set AV_DISPOSITION_DESCRIPTIONS for OIPF cases

Any updates on this issue? Regards, *Łukasz Krzciuk* Developer Vewd ul. Grabarska 2, Pegaz 2A, 50-079 Wrocław, Polska On Thu, Apr 26, 2018 at 9:22 AM, Łukasz Krzciuk wrote: > Thank you. > > This change is really simple: set AV_DISPOSITION_DESCRIPTIONS bit when we > have a

Re: [FFmpeg-devel] avformat/mpegts: set AV_DISPOSITION_DESCRIPTIONS for OIPF cases

Thank you. This change is really simple: set AV_DISPOSITION_DESCRIPTIONS bit when we have a specified stream. So a test could be simple too. But I cannot see many of tests in .../libavformat/tests dir. It seems 'disposition' is not tested at all currently. So if I will prepare a testcase for

Re: [FFmpeg-devel] avformat/mpegts: set AV_DISPOSITION_DESCRIPTIONS for OIPF cases

On Wed, Apr 25, 2018 at 08:17:38AM +0200, Łukasz Krzciuk wrote: > Yes, I have checked it and I implemented it according to OIPF spec: 8.4.2 > AVComponent, audioDescription case (as I wrote in my 1st email). This > implementation is tested by official org.hbbtv_HTML50420 testcase. ok, ill apply it

Re: [FFmpeg-devel] avformat/mpegts: set AV_DISPOSITION_DESCRIPTIONS for OIPF cases

Yes, I have checked it and I implemented it according to OIPF spec: 8.4.2 AVComponent, audioDescription case (as I wrote in my 1st email). This implementation is tested by official org.hbbtv_HTML50420 testcase. Regards, *Łukasz Krzciuk* Developer Vewd ul. Grabarska 2, Pegaz 2A, 50-079 Wrocław,

Re: [FFmpeg-devel] avformat/mpegts: set AV_DISPOSITION_DESCRIPTIONS for OIPF cases

On Tue, Apr 24, 2018 at 10:36:50AM +0200, Łukasz Krzciuk wrote: > Any updates on this? did you base this on teh specification / have checked that it matches the specification ? [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many that live deserve death. And

Re: [FFmpeg-devel] avformat/mpegts: set AV_DISPOSITION_DESCRIPTIONS for OIPF cases

Any updates on this? Regards, *Łukasz Krzciuk* Developer Vewd ul. Grabarska 2, Pegaz 2A, 50-079 Wrocław, Polska On Wed, Apr 18, 2018 at 11:03 PM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > On Wed, Apr 18, 2018 at 08:28:05AM +0200, Łukasz Krzciuk wrote: > > Any updates on this? >

Re: [FFmpeg-devel] avformat/mpegts: set AV_DISPOSITION_DESCRIPTIONS for OIPF cases

On Wed, Apr 18, 2018 at 08:28:05AM +0200, Łukasz Krzciuk wrote: > Any updates on this? has someone crosschecked this with the spec ? [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many that live deserve death. And some that die deserve life. Can you give it to

Re: [FFmpeg-devel] avformat/mpegts: set AV_DISPOSITION_DESCRIPTIONS for OIPF cases

Any updates on this? Regards, *Łukasz Krzciuk* Developer Vewd ul. Grabarska 2, Pegaz 2A, 50-079 Wrocław, Polska On Mon, Apr 16, 2018 at 9:16 AM, Łukasz Krzciuk wrote: > I agree, AV_LOG_INFO has been changed to AV_LOG_DEBUG. > > Regards, > > *Łukasz Krzciuk* > Developer >

Re: [FFmpeg-devel] avformat/mpegts: set AV_DISPOSITION_DESCRIPTIONS for OIPF cases

I agree, AV_LOG_INFO has been changed to AV_LOG_DEBUG. Regards, *Łukasz Krzciuk* Developer Vewd ul. Grabarska 2, Pegaz 2A, 50-079 Wrocław, Polska On Fri, Apr 13, 2018 at 5:50 PM, Michael Niedermayer wrote: > On Fri, Apr 13, 2018 at 03:44:40PM +0200, Łukasz Krzciuk

Re: [FFmpeg-devel] avformat/mpegts: set AV_DISPOSITION_DESCRIPTIONS for OIPF cases

On Fri, Apr 13, 2018 at 03:44:40PM +0200, Łukasz Krzciuk wrote: > Hi, > > this change is needed according to OIPF spec: 8.4.2 AVComponent, > audioDescription case: > >1. an audio component with an ISO_639_language_descriptor in the PMT >with the audio_type field set to 0x03 >2. a