Re: [FFmpeg-devel] swscale/x86/rgb2rgb : port shuffle2103 to external asm

2018-10-13 Thread Martin Vignali
> thats eliminates my concern > > Pushed, thanks. Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] swscale/x86/rgb2rgb : port shuffle2103 to external asm

2018-10-11 Thread Michael Niedermayer
On Thu, Oct 11, 2018 at 09:37:52PM +0200, Martin Vignali wrote: > > > > the split should be > > the removal of the code that stays removed > > the porting of the remaining code > > > > I understand its easier to drop both and then add one but thats a ugly way > > to split the patch. The patch

Re: [FFmpeg-devel] swscale/x86/rgb2rgb : port shuffle2103 to external asm

2018-10-11 Thread Martin Vignali
> > the split should be > the removal of the code that stays removed > the porting of the remaining code > > I understand its easier to drop both and then add one but thats a ugly way > to split the patch. The patch porting the code should show both the code > thats removed as well as the added

Re: [FFmpeg-devel] swscale/x86/rgb2rgb : port shuffle2103 to external asm

2018-10-10 Thread Michael Niedermayer
On Tue, Oct 09, 2018 at 10:52:58PM +0200, Martin Vignali wrote: > > > > porting code and removing code sounds like 2 seperate things, > > that should not be in the same patch > > > > Split patch in attach the split should be the removal of the code that stays removed the porting of the remaining

Re: [FFmpeg-devel] swscale/x86/rgb2rgb : port shuffle2103 to external asm

2018-10-09 Thread Martin Vignali
> > porting code and removing code sounds like 2 seperate things, > that should not be in the same patch > Split patch in attach Martin 0002-swscale-x86-rgb2rgb-remove-inline-mmx-mmxext-version.patch Description: Binary data 0001-swscale-x86-rgb2rgb-port-shuffle-2103-mmxext-to-exte.patch

Re: [FFmpeg-devel] swscale/x86/rgb2rgb : port shuffle2103 to external asm

2018-10-09 Thread Michael Niedermayer
On Tue, Oct 09, 2018 at 09:51:16PM +0200, Martin Vignali wrote: > > > > > > > > Keeping both MMX and MMXEXT seems a bit excessive. Ideally both would > > > > be replaced with something more modern, but I'd at least drop the MMX > > > > one. > > > > > > > > > > This func already have SSSE3 version

Re: [FFmpeg-devel] swscale/x86/rgb2rgb : port shuffle2103 to external asm

2018-10-09 Thread Martin Vignali
> > > > > > Keeping both MMX and MMXEXT seems a bit excessive. Ideally both would > > > be replaced with something more modern, but I'd at least drop the MMX > > > one. > > > > > > > This func already have SSSE3 version (AVX2 can be add easily, but doesn't > > find a command line where the speed

Re: [FFmpeg-devel] swscale/x86/rgb2rgb : port shuffle2103 to external asm

2018-10-09 Thread Hendrik Leppkes
On Tue, Oct 9, 2018 at 1:31 PM Martin Vignali wrote: > > > > > Keeping both MMX and MMXEXT seems a bit excessive. Ideally both would > > be replaced with something more modern, but I'd at least drop the MMX > > one. > > > > This func already have SSSE3 version (AVX2 can be add easily, but doesn't

Re: [FFmpeg-devel] swscale/x86/rgb2rgb : port shuffle2103 to external asm

2018-10-09 Thread Martin Vignali
> > Keeping both MMX and MMXEXT seems a bit excessive. Ideally both would > be replaced with something more modern, but I'd at least drop the MMX > one. > This func already have SSSE3 version (AVX2 can be add easily, but doesn't find a command line where the speed is interesting in AVX2 (on my

Re: [FFmpeg-devel] swscale/x86/rgb2rgb : port shuffle2103 to external asm

2018-10-09 Thread Henrik Gramner
On Mon, Oct 8, 2018 at 7:46 PM Martin Vignali wrote: > > Hello, > > Patch in attach port inline asm shuffle 2103 func (mmx/mmxext) to external > asm > and remove the inline asm version > > Martin Keeping both MMX and MMXEXT seems a bit excessive. Ideally both would be replaced with something