[issue675] White artifacts on JPEGs when using libswscale

2011-06-14 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Fixed in 0af8a71d66305874bd6f0ebc84ebf99339b6a5d3

--
nosy:  -cehoyos, michaelni, xrigou
status: open - closed
substatus: reproduced - fixed
topic:  -regression, swscaler

__
Libav issue tracker iss...@roundup.libav.org
https://roundup.libav.org/issue675
__


[issue1108] yuvj420p scaling artefact

2011-06-12 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Duplicate of 1108 then.

--
status: open - closed
substatus: reproduced - duplicate
superseder: +yuvj420p scaling artefact
topic:  -regression, swscaler

__
Libav issue tracker iss...@roundup.libav.org
https://roundup.libav.org/issue1108
__


[issue1108] yuvj420p scaling artefact

2011-06-12 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Oops, I mean 675, mixed up the two...

--
superseder: +White artifacts on JPEGs when using libswscale -yuvj420p scaling 
artefact

__
Libav issue tracker iss...@roundup.libav.org
https://roundup.libav.org/issue1108
__


[issue2558] VPlayer Android app in violation of LGPL

2011-03-28 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Please let us confirm that first.

--
status: closed - open
substatus: fixed - reproduced

__
Libav issue tracker iss...@roundup.libav.org
https://roundup.libav.org/issue2558
__


[issue2657] 688c22e causes ffplay to freeze after pressing q on streamed content

2011-03-24 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

This was fixed a while ago in c76374c6db5f486672f9df223f43e4892bd655c9

--
nosy:  -llogan
status: new - closed
substatus: new - fixed

__
Libav issue tracker iss...@roundup.libav.org
https://roundup.libav.org/issue2657
__


[issue255] Colour artifacts in wmv3

2011-03-22 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Fixed in c47d3835021effc04bc1fd2cef6be31e1b186491

--
nosy:  -cehoyos, kostya
status: open - closed
substatus: analyzed - fixed
topic:  -avcodec

__
Libav issue tracker iss...@roundup.libav.org
https://roundup.libav.org/issue255
__


[issue2638] commit 3244293 breaks metadata in mp4 output

2011-03-04 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Fixed in fd085bc08203979c6d0e8a6ab031c7e19b57f7a1.

--
status: new - closed
substatus: new - fixed


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2638



[issue2638] commit 3244293 breaks metadata in mp4 output

2011-03-03 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

41936608   00 00 00 00 00 00 00 00 00 00 00 00 79 69 6c 73
yils
41936624   74 00 00 00 1d a9 6e 61 6d 00 00 00 15 64 61 74t nam
dat
41936640   61 00 00 00 01 00 00 00 00 74 69 74 6c 65 00 00a
title  
41936656   00 30 a9 64 61 79 00 00 00 28 64 61 74 61 00 00 0 day   
(data 
41936672   00 01 00 00 00 00 32 30 31 31 2d 30 31 2d 33 30  
2011-01-30
41936688   54 31 35 3a 33 35 3a 30 31 2d 30 35 30 30 00 00T15:35:01-
0500  
41936704   00 24 a9 74 6f 6f 00 00 00 1c 64 61 74 61 00 00 $ too
data  
41936720   00 01 00 00 00 00 4c 61 76 66 35 32 2e 31 30 32  
Lavf52.102
41936736   2e 30  .0
41936752
** /tmp/before.mp4  41936738 41936608  
99%  
41936608   00 00 00 00 00 00 00 00 00 00 00 00 79 69 6c 73
yils
41936624   74 00 00 00 1d a9 ff ff ff 00 00 00 15 64 61 74t
dat
41936640   61 00 00 00 01 00 00 00 00 74 69 74 6c 65 00 00a
title  
41936656   00 30 a9 ff ff ff 00 00 00 28 64 61 74 61 00 00 0   
(data 
41936672   00 01 00 00 00 00 32 30 31 31 2d 30 31 2d 33 30  
2011-01-30
41936688   54 31 35 3a 33 35 3a 30 31 2d 30 35 30 30 00 00T15:35:01-
0500  
41936704   00 24 a9 ff ff ff 00 00 00 1c 64 61 74 61 00 00 $
data  
41936720   00 01 00 00 00 00 4c 61 76 66 35 32 2e 31 30 32  
Lavf52.102
41936736   2e 30  .0
41936752

In other words, the tag names went missing. Anton?


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2638



[issue2638] commit 3244293 breaks metadata in mp4 output

2011-03-03 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Signedness problem. Likely this fix is a hack and we should make these 
functions take fourccs as their input, that would also actually implement 
the API as it was intended. I might do that in a next iteration.


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2638


mov-fix-metadata.patch
Description: Binary data


[issue2638] commit 3244293 breaks metadata in mp4 output

2011-03-03 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Here's a more acceptable version that does the same thing.


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2638


mov-fix-metadata.patch
Description: Binary data


[issue455] Kandalu violates the GPL

2011-02-23 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Hi,

sorry to have to reply for Diego, but he's been having issues with his 
computer. Basically it's broken. Please give hime a little slack in 
fixing this. You've been on here since halfway 2008, a few days extra 
doesn't matter.


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue455



[issue2563] AVI encoder create a file (contains multiple video and audio streams) with uncorrect fourcc tag

2011-02-23 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Fixed in 4acc94e97a9551d11ead29735e23283d71f1d4c2.

--
status: new - closed
substatus: new - fixed


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2563



[issue2563] AVI encoder create a file (contains multiple video and audio streams) with uncorrect fourcc tag

2011-02-23 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

no, the 1st stream has idnex 0, the second index 1, 100th index 99.


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2563



[issue2611] bug in libavcodec/tcp.c

2011-02-16 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

I'll have a look.

(1) as for URL_FLAG_NONBLOCK, it's sn API function, and ffmpeg.c does 
not use this API, so it is never set. It not being set, the read loop 
should attempt to read forever until data has been read, just like a 
blocking read(2) call.

(2-3) for reading all data, use url_read_complete(). There is currently 
no write equivalent of this function but I'm not against adding that.


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2611



[issue2611] bug in libavcodec/tcp.c

2011-02-15 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Please use url_open()/url_read()/url_write(), they take care of the stuff 
you're trying to do.

--
status: new - closed
substatus: new - invalid


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2611



[issue3] [tracker] git transition

2011-02-12 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Yes.

--
status: open - closed
substatus: open - fixed


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue3



[issue2587] AC3 encoder has been changed to take float but accepts S16

2011-02-08 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

http://permalink.gmane.org/gmane.comp.video.ffmpeg.devel/122907

If you have no time, I can fix it up.


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2587



[issue2587] AC3 encoder has been changed to take float but accepts S16

2011-02-06 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

I agree with Reimar.


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2587



[issue2584] VLC stack overflow in libavcodec with vc1 file

2011-02-05 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

==56585== Invalid read of size 4
==56585==at 0x10036F181: vc1_decode_ac_coeff (in ./ffmpeg_g)
==56585==by 0x100373E51: vc1_decode_i_blocks_adv (in 
./ffmpeg_g)==56585==by 0x300017: ???
==56585==by 0x1010EA52F: ???
==56585==by 0x7FFF000C: ???
==56585==by 0x40019: ???
==56585==by 0x16: ???
==56585==by 0x7FFF5FBFE45B: ???
==56585==by 0x7FFF5FBFE457: ???
==56585==by 0x7FFF5FBFE453: ???
==56585==by 0x10106FFF2: ???
==56585==by 0x5BFF: ???
==56585==  Address 0x101059597 is 1,687 bytes inside a block of size 
1,690 alloc
'd
==56585==at 0x100CDFD06: memalign (vg_replace_malloc.c:581)
==56585==by 0x100CDFD5F: posix_memalign (vg_replace_malloc.c:709)
==56585==by 0x1004B50DC: av_mallocz (in ./ffmpeg_g)
==56585==by 0x7FFF5FBFE91F: ???
[..]

==56585== Invalid read of size 4
==56585==at 0x100373A6A: vc1_decode_i_blocks_adv (in ./ffmpeg_g)
==56585==by 0x300017: ???
==56585==by 0x1010EA52F: ???
==56585==by 0x7FFF000C: ???
==56585==by 0x40019: ???
==56585==by 0x16: ???
==56585==by 0x7FFF5FBFE45B: ???
==56585==by 0x7FFF5FBFE457: ???==56585==by 0x7FFF5FBFE453: ???
==56585==by 0x10106FFF2: ???
==56585==by 0x5BFF: ???
==56585==by 0x11: ???
==56585==  Address 0x101059598 is 1,688 bytes inside a block of size 
1,690 alloc
'd
==56585==at 0x100CDFD06: memalign (vg_replace_malloc.c:581)
==56585==by 0x100CDFD5F: posix_memalign (vg_replace_malloc.c:709)
==56585==by 0x1004B50DC: av_mallocz (in ./ffmpeg_g)
==56585==by 0x7FFF5FBFE91F: ???

disass of second address:
0x000100373a1b vc1_decode_i_blocks_adv+1195:  mov
0x35d0(%rbp),%ebx
0x000100373a21 vc1_decode_i_blocks_adv+1201:  mov
%ebx,0x94(%rsp)
0x000100373a28 vc1_decode_i_blocks_adv+1208:  mov
0x35d4(%rbp),%eax
0x000100373a2e vc1_decode_i_blocks_adv+1214:  mov
%eax,0x90(%rsp)
0x000100373a35 vc1_decode_i_blocks_adv+1221:  mov
0x90(%rbp),%r13d
0x000100373a3c vc1_decode_i_blocks_adv+1228:  movslq 
0x3d24(%rbp),%rax
0x000100373a43 vc1_decode_i_blocks_adv+1235:  lea
(%rax,%rax,2),%rax
0x000100373a47 vc1_decode_i_blocks_adv+1239:  shl$0x3,%rax
0x000100373a4b vc1_decode_i_blocks_adv+1243:  add
0x2bd6ae(%rip),%rax# 0x100631100
0x000100373a52 vc1_decode_i_blocks_adv+1250:  mov
0x8(%rax),%r8
0x000100373a56 get_vlc2+0:mov0x3d68(%rbp),%esi
0x000100373a5c get_vlc2+6:mov0x3d58(%rbp),%r9
0x000100373a63 get_vlc2+13:   mov%esi,%eax
0x000100373a65 get_vlc2+15:   shr$0x3,%eax
0x000100373a68 get_vlc2+18:   mov%eax,%eax
0x000100373a6a get_vlc2+20:   mov(%r9,%rax,1),%eax
0x000100373a6e av_bswap32+0:  bswap  %eax
0x000100373a70 NEG_USR32+0:   mov%esi,%ecx
0x000100373a72 NEG_USR32+2:   and$0x7,%ecx
0x000100373a75 NEG_USR32+5:   shl%cl,%eax
0x000100373a77 NEG_USR32+7:   shr$0xf7,%eax

disass of first:

0x00010036f15a vc1_decode_ac_coeff+42:lea
0x82c6df(%rip),%rdi# 0x100b9b840 ff_vc1_ac_coeff_table
0x00010036f161 vc1_decode_ac_coeff+49:movslq %r8d,%r8
0x00010036f164 vc1_decode_ac_coeff+52:lea(%r8,%r8,2),%rax
0x00010036f168 vc1_decode_ac_coeff+56:mov
0x8(%rdi,%rax,8),%r10
0x00010036f16d vc1_decode_ac_coeff+61:mov0x3d68(%rbx),%esi
0x00010036f173 vc1_decode_ac_coeff+67:mov0x3d58(%rbx),%rbp
0x00010036f17a vc1_decode_ac_coeff+74:mov%esi,%eax
0x00010036f17c vc1_decode_ac_coeff+76:shr$0x3,%eax
0x00010036f17f vc1_decode_ac_coeff+79:mov%eax,%eax
0x00010036f181 vc1_decode_ac_coeff+81:mov
0x0(%rbp,%rax,1),%eax
0x00010036f185 av_bswap32+0:  bswap  %eax
0x00010036f187 NEG_USR32+0:   mov%esi,%ecx
0x00010036f189 NEG_USR32+2:   and$0x7,%ecx
0x00010036f18c NEG_USR32+5:   shl%cl,%eax
0x00010036f18e NEG_USR32+7:   shr$0xf7,%eax
0x00010036f191 vc1_decode_ac_coeff+97:mov%eax,%eax
0x00010036f193 vc1_decode_ac_coeff+99:lea
(%r10,%rax,4),%rax
0x00010036f197 vc1_decode_ac_coeff+103:   movswl (%rax),%r9d
0x00010036f19b vc1_decode_ac_coeff+107:   movswl 0x2(%rax),%edx
0x00010036f19f vc1_decode_ac_coeff+111:   test   %edx,%edx


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2584



[issue2584] VLC stack overflow in libavcodec with vc1 file

2011-02-05 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

It fixes some, but not all. wc -l of valgrind ffmpeg goes from ~2000 to 
~400, but still more warnings remain:

==61513== Invalid read of size 4
==61513==at 0x10036E8BA: vc1_decode_i_blocks_adv (in ./ffmpeg_g)
==61513==by 0x300017: ???
==61513==by 0x1010DC41F: ???
==61513==by 0x7FFF000C: ???
==61513==by 0x30019: ???
==61513==by 0x16: ???
==61513==by 0x7FFF5FBFE46B: ???
==61513==by 0x7FFF5FBFE467: ???
==61513==by 0x7FFF5FBFE463: ???
==61513==by 0x10105FFF2: ???
==61513==by 0x58FF: ???
==61513==by 0x11: ???
==61513==  Address 0x1010beedc is 3,436 bytes inside a block of size 
3,439 alloc'd

0x00010036e897 vc1_decode_i_blocks_adv+1239:  shl$0x3,%rax
0x00010036e89b vc1_decode_i_blocks_adv+1243:  add
0x2bc85e(%rip),%rax# 0x10062b100
0x00010036e8a2 vc1_decode_i_blocks_adv+1250:  mov
0x8(%rax),%r8
0x00010036e8a6 get_vlc2+0:mov0x3cf8(%rbp),%esi
0x00010036e8ac get_vlc2+6:mov0x3ce8(%rbp),%r9
0x00010036e8b3 get_vlc2+13:   mov%esi,%eax
0x00010036e8b5 get_vlc2+15:   shr$0x3,%eax
0x00010036e8b8 get_vlc2+18:   mov%eax,%eax
0x00010036e8ba get_vlc2+20:   mov(%r9,%rax,1),%eax
0x00010036e8be av_bswap32+0:  bswap  %eax
0x00010036e8c0 NEG_USR32+0:   mov%esi,%ecx
0x00010036e8c2 NEG_USR32+2:   and$0x7,%ecx
0x00010036e8c5 NEG_USR32+5:   shl%cl,%eax
0x00010036e8c7 NEG_USR32+7:   shr$0xf7,%eax

==61513== Invalid read of size 4
==61513==at 0x100369FF1: vc1_decode_ac_coeff (in ./ffmpeg_g)
==61513==by 0x10036ECA1: vc1_decode_i_blocks_adv (in ./ffmpeg_g)
==61513==by 0x300017: ???
==61513==by 0x1010E22FF: ???
==61513==by 0x7FFF000C: ???
==61513==by 0x30019: ???
==61513==by 0x16: ???
==61513==by 0x7FFF5FBFE46B: ???
==61513==by 0x7FFF5FBFE467: ???
==61513==by 0x7FFF5FBFE463: ???
==61513==by 0x10105FFF2: ???
==61513==by 0x58FF: ???
==61513==  Address 0x1010beedc is 3,436 bytes inside a block of size 
3,439 alloc'd


(gdb) disass 0x100369FF1
Dump of assembler code for function vc1_decode_ac_coeff:
0x000100369fa0 vc1_decode_ac_coeff+0: mov%rbx,-0x30(%rsp)
0x000100369fa5 vc1_decode_ac_coeff+5: mov%rbp,-0x28(%rsp)
0x000100369faa vc1_decode_ac_coeff+10:mov%r12,-0x20(%rsp)
0x000100369faf vc1_decode_ac_coeff+15:mov%r13,-0x18(%rsp)
0x000100369fb4 vc1_decode_ac_coeff+20:mov%r14,-0x10(%rsp)
0x000100369fb9 vc1_decode_ac_coeff+25:mov%r15,-0x8(%rsp)
0x000100369fbe vc1_decode_ac_coeff+30:mov%rdi,%rbx
0x000100369fc1 vc1_decode_ac_coeff+33:mov%rsi,%r13
0x000100369fc4 vc1_decode_ac_coeff+36:mov%rdx,%r14
0x000100369fc7 vc1_decode_ac_coeff+39:mov%rcx,%r15
0x000100369fca vc1_decode_ac_coeff+42:lea
0x828c4f(%rip),%rdi# 0x100b92c20 ff_vc1_ac_coeff_table
0x000100369fd1 vc1_decode_ac_coeff+49:movslq %r8d,%r8
0x000100369fd4 vc1_decode_ac_coeff+52:lea(%r8,%r8,2),%rax
0x000100369fd8 vc1_decode_ac_coeff+56:mov
0x8(%rdi,%rax,8),%r10
0x000100369fdd vc1_decode_ac_coeff+61:mov0x3cf8(%rbx),%esi
0x000100369fe3 vc1_decode_ac_coeff+67:mov0x3ce8(%rbx),%rbp
0x000100369fea vc1_decode_ac_coeff+74:mov%esi,%eax
0x000100369fec vc1_decode_ac_coeff+76:shr$0x3,%eax
0x000100369fef vc1_decode_ac_coeff+79:mov%eax,%eax
0x000100369ff1 vc1_decode_ac_coeff+81:mov
0x0(%rbp,%rax,1),%eax
0x000100369ff5 av_bswap32+0:  bswap  %eax

i.e. this is the get_vlc2() 4 lines above the one your patch touches.

Also during playback a lot of these warnings:
[vc1 @ 0x100f8bbc0] Luma scaling is not supported, expect wrong picture
[vc1 @ 0x100f8bbc0] Chroma scaling is not supported, expect wrong 
picture


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2584



[issue2583] Unable to play some relative applehttp streams from NRJ France

2011-02-04 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Closing...

--
status: new - closed
substatus: new - fixed


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2583



[issue2465] streamid does not work with newaudio, newvideo, newsubtitle

2011-02-03 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Fixed in 20ac9de3df9b129a4a312d626fed0e2bbb760200

--
status: open - closed
substatus: analyzed - fixed


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2465



[issue442] parameter for getting information about files

2011-02-03 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

I think so, yes.

--
status: open - closed
substatus: open - fixed


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue442



[issue2576] AVCHD lite MTS file conversion loses first seconds

2011-01-31 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Does make fate succeed in your windows version? It seems like a build 
problem to me...


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2576



[issue2570] configure incorrectly enables #define HAVE_AMD3DNOW 1 in config.h

2011-01-25 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Hi,

HAVE_AMD3DNOW means it can be assembled, not that the CPU supports it. Use 
enable-runtime-cpudetect configure flag to use runtime cpu detection 
which should fix this.


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2570



[issue2563] AVI encoder create a file (contains multiple video and audio streams) with uncorrect fourcc tag

2011-01-25 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Here is a forward from ffmpeg-devel. Please adjust the patch so it has 
the correct message and MAX_STREAMS (100, not 99, since they're numbered 
from 0 onwards, not 1 onwards), and then it's OK.

2011/1/24 Måns Rullgård m...@mansr.com:
 Ronald S. Bultje rsbul...@gmail.com writes:

 Hi guys,

 posting next patch:

 longstone zhibing@hotmail.com added the comment:
 Add error check in avi_write_header() function.

 Looks fine to me, although I guess 99 should be 100 (100 streams 
means
 IDs 00-99).

 Correct.

 Ronald

 Index: libavformat/avi.h
 ===
 --- libavformat/avi.h (revision 26402)
 +++ libavformat/avi.h (working copy)
 @@ -32,6 +32,7 @@

  #define AVI_MAX_RIFF_SIZE       0x4000LL
  #define AVI_MASTER_INDEX_SIZE   256
 +#define AVI_MAX_STREAM_COUNT  99             //AVI format is able to 
assign stream ID for at most 99 streams

 Wrong value and useless comment.

  /* index flags */
  #define AVIIF_INDEX             0x10
 Index: libavformat/avienc.c
 ===
 --- libavformat/avienc.c      (revision 26402)
 +++ libavformat/avienc.c      (working copy)
 @@ -85,8 +85,8 @@

  static char* avi_stream2fourcc(char* tag, int index, enum 
AVMediaType type)
  {
 -    tag[0] = '0';
 -    tag[1] = '0' + index;
 +    tag[0] = '0' + (index/10);
 +    tag[1] = '0' + (index%10);

 Lose the ().

      if (type == AVMEDIA_TYPE_VIDEO) {
          tag[2] = 'd';
          tag[3] = 'c';
 @@ -158,6 +158,12 @@
      int64_t list1, list2, strh, strf;
      AVMetadataTag *t = NULL;

 +    /* check the total stream number */

 Useless comment.

 +    if (s-nb_streams  AVI_MAX_STREAM_COUNT) {
 +        av_log(s, AV_LOG_ERROR, Too many streams for avi format 
file. Please limit the number to be less than 100.\n);
 +        return -1;
 +    }

 Wrong message.

 --
 Måns Rullgård
 m...@mansr.com
 ___
 ffmpeg-devel mailing list
 ffmpeg-de...@mplayerhq.hu
 https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel



FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2563



[issue2563] AVI encoder create a file (contains multiple video and audio streams) with uncorrect fourcc tag

2011-01-24 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

can you add a check in write_header() to error out on 100 streams?

Ronald


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2563



[issue2393] avcodec_decode_video craches with H.264 steram

2011-01-22 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

The attached patch fixes the crash for me. The problem is that on 
resolution change, the decoded NALs are free'ed in free_tables() and 
then reused directly after that (after reinit) during decoding of the 
actual data, this of course crashes. The attached patch fixes that.

There's still some corrupt data at the bottom of the images, is that 
also a bug or was that always there?


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2393
diff --git a/libavcodec/h264.c b/libavcodec/h264.c
index 40dc276..2dc8045 100644
--- a/libavcodec/h264.c
+++ b/libavcodec/h264.c
@@ -614,7 +614,7 @@ static void hl_motion(H264Context *h, uint8_t *dest_y, 
uint8_t *dest_cb, uint8_t
 }
 
 
-static void free_tables(H264Context *h){
+static void free_tables(H264Context *h, int free_rbsp){
 int i;
 H264Context *hx;
 av_freep(h-intra4x4_pred_mode);
@@ -637,10 +637,12 @@ static void free_tables(H264Context *h){
 av_freep(hx-top_borders[1]);
 av_freep(hx-top_borders[0]);
 av_freep(hx-s.obmc_scratchpad);
+if (free_rbsp){
 av_freep(hx-rbsp_buffer[1]);
 av_freep(hx-rbsp_buffer[0]);
 hx-rbsp_buffer_size[0] = 0;
 hx-rbsp_buffer_size[1] = 0;
+}
 if (i) av_freep(h-thread_context[i]);
 }
 }
@@ -748,7 +750,7 @@ int ff_h264_alloc_tables(H264Context *h){
 
 return 0;
 fail:
-free_tables(h);
+free_tables(h, 1);
 return -1;
 }
 
@@ -1776,7 +1778,7 @@ static int decode_slice_header(H264Context *h, 
H264Context *h0){
 || av_cmp_q(h-sps.sar, s-avctx-sample_aspect_ratio))) {
 if(h != h0)
 return -1;   // width / height changed during parallelized decoding
-free_tables(h);
+free_tables(h, 0);
 flush_dpb(s-avctx);
 MPV_common_end(s);
 }
@@ -1784,6 +1786,7 @@ static int decode_slice_header(H264Context *h, 
H264Context *h0){
 if(h != h0)
 return -1;  // we cant (re-)initialize context during parallel 
decoding
 
+printf(Reinit\n);
 avcodec_set_dimensions(s-avctx, s-width, s-height);
 s-avctx-sample_aspect_ratio= h-sps.sar;
 av_assert0(s-avctx-sample_aspect_ratio.den);
@@ -3331,7 +3334,7 @@ av_cold void ff_h264_free_context(H264Context *h)
 {
 int i;
 
-free_tables(h); //FIXME cleanup init stuff perhaps
+free_tables(h, 1); //FIXME cleanup init stuff perhaps
 
 for(i = 0; i  MAX_SPS_COUNT; i++)
 av_freep(h-sps_buffers + i);


[issue2393] avcodec_decode_video craches with H.264 steram

2011-01-22 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Applied.

Please open a new issue for the bottom screen corruption if appropriate.

--
status: open - closed
substatus: reproduced - fixed


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2393



[issue2393] avcodec_decode_video craches with H.264 steram

2011-01-21 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

I see the behaviour. The stream is ... dysfunctional at best. It's 
probably supported, because there's code in the decoder for handling 
this, but lacking a test-case it broke.


Stream #0.0: Video: rawvideo, yuv420p, 960x544, q=2-31, 200 kb/s, 
90k tbn, 25 tbc
Stream mapping:
  Stream #0.0 - #0.0
Press [q] to stop encoding
Reinit - called when tables are inited with size 960x544
Deinit - called when free_tables() is called because of size change
Reinit - reinit with different size 1920x1088
[h264 @ 0x101014200] mb_type -1 in I slice too large at 0 0
[h264 @ 0x101014200] error while decoding MB 0 0
[h264 @ 0x101014200] concealing 8160 DC, 8160 AC, 8160 MV errors
Input Stream #0.0 frame size changed to 1920x1088, yuv420p
bash-3.2$ 

What happens is that the tables are not cleaned up correctly or not 
reinitialized correctly or some variables not cleaned up from the old 
state. I have to look further as for what it all means, but I just 
wanted to say that the stream is messy.


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2393



[issue2393] avcodec_decode_video craches with H.264 steram

2011-01-18 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

If 25830 does not work but 16420 works fine, and since you have a good 
way of seeing if it crashes yes or no, could you figure out for us what 
revision exactly broke it? I have a Mac so no valgrind and it doesn't 
crash, so hard to debug like that. If someone can run this through 
valgrind on linux or find the offending commit (using binary search) on 
win32, that'd help a lot, and I'll try to fix it.


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2393



[issue2547] H.264 decoder x86 asm bug

2011-01-15 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

The problem is in 8x8 predict functions (16x16 are fine), working on a fix 
now...


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2547



[issue2547] H.264 decoder x86 asm bug

2011-01-15 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

I was wrong, it was the 16x16, there was an overflow in one of the 
functions. Attached patch fixes it. I've rearranged the calls a little so 
that it hopefully doesn't get slower. I haven't benchmarked the change, 
but effect should be minimal (if any).


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2547
Index: libavcodec/x86/h264_intrapred.asm
===
--- libavcodec/x86/h264_intrapred.asm   (revision 26343)
+++ libavcodec/x86/h264_intrapred.asm   (working copy)
@@ -344,28 +344,6 @@
 %endif
 paddwm0, m1   ; sum of H coefficients
 
-%ifidn %3, h264
-pmullw   m0, [pw_5]
-paddwm0, [pw_32]
-psrawm0, 6
-%elifidn %3, rv40
-pmullw   m0, [pw_5]
-psrawm0, 6
-%elifidn %3, svq3
-movdr3d, m0
-movsxr3, r3w
-test r3, r3
-lea  r4, [r3+3]
-cmovsr3, r4
-sar  r3, 2   ; H/4
-lea  r3, [r3*5]  ; 5*(H/4)
-test r3, r3
-lea  r4, [r3+15]
-cmovsr3, r4
-sar  r3, 4   ; (5*(H/4))/16
-movd m0, r3d
-%endif
-
 lea  r4, [r0+r2*8-1]
 lea  r3, [r0+r2*4-1]
 add  r4, r2
@@ -468,8 +446,30 @@
 movzxr3, byte [r3+r2*2   ]
 lea  r3, [r3+r4+1]
 shl  r3, 4
+
 movdr1d, m0
 movsx   r1d, r1w
+%ifnidn %3, svq3
+%ifidn %3, h264
+lea r1d, [r1d*5+32]
+%else ; rv40
+lea r1d, [r1d*5]
+%endif
+sar r1d, 6
+movd m0, r1d
+%else ; svq3
+test r1, r1
+lea  r4, [r1+3]
+cmovsr1, r4
+sar  r1, 2   ; H/4
+lea  r1, [r1*5]  ; 5*(H/4)
+test r1, r1
+lea  r4, [r1+15]
+cmovsr1, r4
+sar  r1, 4   ; (5*(H/4))/16
+movd m0, r1d
+%endif
+
 add r1d, r5d
 add r3d, r1d
 shl r1d, 3


[issue2547] H.264 decoder x86 asm bug

2011-01-15 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Fixed in r26381.

--
status: open - closed
substatus: reproduced - fixed


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2547



[issue2478] RTSP/WMS stream does not support ASF chaining

2011-01-14 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Patch applied. Changing topic to reflect that the stream-continuation 
still needs work.

--
title: MMSH shows full metadata, RTSP does not - RTSP/WMS stream does not 
support ASF chaining


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2478



[issue2484] WMS Compatibility Suggestions

2011-01-04 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

My idea for MMS is indeed to try RTSP, then HTTP/MMS (and I do prefer a 
fallback to mmst, just because some old servers still use that, even 
though it's not used a lot). Lack of time is the main reason that we 
haven't done it yet.

The HTTP - MMSH forward is an interesting idea and should probably be 
done, but I'd need to look some more into this. You could help here by 
writing a good check in http.c that tries to detect MMSH input, and then 
I'll add the magic code to make it forward to MMSH for those streams.

--
priority: normal - wish


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2484



[issue2478] MMSH shows full metadata, RTSP does not

2011-01-03 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Input #0, rtsp, from 'rtsp://djxmmx.net/Rap-RnB':
  Metadata:
genre   : Rap
WMFSDKVersion   : 11.0.6002.18049
WMFSDKNeeded: 0.0.0.
IsVBR   : 0
album   : Double Trouble
track   : 4
WM/Year : 2007
title   : U Aint Gotta Ask
artist  : Al Fatz  Chip Tha Ripper
copyright   : 
comment : 
  Duration: 00:03:06.64, start: 123.965000, bitrate: 128 kb/s
Stream #0.0: Audio: wmapro, 44100 Hz, stereo, flt, 128 kb/s
Stream #0.1: Data: [0][0][0][0] / 0x
 127.58 A-V:  0.000 s:0.0 aq=   94KB vq=0KB sq=0B f=0/0


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2478
Index: libavformat/rtpdec_asf.c
===
--- libavformat/rtpdec_asf.c(revision 26130)
+++ libavformat/rtpdec_asf.c(working copy)
@@ -96,6 +96,7 @@
 int ret = 0;
 if (av_strstart(p, pgmpu:data:application/vnd.ms.wms-hdr.asfv1;base64,, 
p)) {
 ByteIOContext pb;
+AVMetadataTag *t;
 RTSPState *rt = s-priv_data;
 int len = strlen(p) * 6 / 8;
 char *buf = av_mallocz(len);
@@ -112,6 +113,9 @@
 ret = av_open_input_stream(rt-asf_ctx, pb, , asf_demuxer, NULL);
 if (ret  0)
 return ret;
+while ((t = av_metadata_get(rt-asf_ctx-metadata, , t,
+AV_METADATA_IGNORE_SUFFIX)))
+av_metadata_set2(s-metadata, t-key, t-value, 0);
 rt-asf_pb_pos = url_ftell(pb);
 av_free(buf);
 rt-asf_ctx-pb = NULL;


[issue2478] MMSH shows full metadata, RTSP does not

2011-01-03 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

does the metadata update in this radio station in WMP, btw? If so, we 
should try supporting that also...


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2478



[issue2478] MMSH shows full metadata, RTSP does not

2011-01-03 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

At the end of each song, the server sends us this:

line='SET_PARAMETER rtsp://djxmmx.net:554/Rap-RnB RTSP/1.0'=0/0   
line='Content-Type: application/x-wms-extension-cmd'
line='X-Notice: 2101 End-of-Stream Reached'
line='RTP-Info: url=rtsp://djxmmx.net:554/Rap-RnB/audio;Seq=58258'
line='X-Playlist-Gen-Id: 81157'
line='Content-Length: 71'
line='Date: Mon, 03 Jan 2011 19:07:30 GMT'
line='CSeq: 1'
line='User-Agent: WMServer/9.5.6001.18281'
line=''

Apparently we have to open a new stream then, which we don't do - so we 
get silence. Would be interesting to support...


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2478



[issue2478] MMSH shows full metadata, RTSP does not

2011-01-02 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Metadata from the ASF layer isn't forwarded to the RTSP layer, this should 
be relatively easy to fix...


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2478



[issue2458] Gygan contains an extreme number of license violations

2011-01-01 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Hi Vitaly,

if your developer or yourself need legal guidance, I can also put you in 
touch with our lawyers who commonly assist in these cases. Let me know 
if you need such help.

Thanks for your cooperation!

Ronald


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2458



[issue1912] WMAPro-in-WMAVoice support not implemented

2010-12-29 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Could you upload the other files showing the message at the start 
somewhere? Maybe one of them has non-zero bits in the wmapro packet.


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue1912



[issue2283] Add timed out for mmst

2010-12-29 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

The interrupt CB is supposed to be handled in applications, why do you 
need to do this inside mmst.c?


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2283



[issue1912] WMAPro-in-WMAVoice support not implemented

2010-12-27 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Looking at the pro data in the packets, I doubt this issue can be solved 
with this file:
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][2:00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][4:00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00]   7.23 A-V:  
0.015 s:0.0 aq=  320KB vq=[00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00][00]
[00][00][00][00][00][00][00][00][00][00][00][00][00][00][00

[issue1912] WMAPro-in-WMAVoice support not implemented

2010-12-26 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Attached patch does the initialization of proper contexts for support of 
WMAPro-in-WMAVoice. The actual decoding doesn't work yet because the 
call to avcodec_decode_audio() is missing. Init fails though:

[wmapro @ 0x101855200] no length prefix
 If you want to help, upload a sample of this file to 
ftp://upload.ffmpeg.org/MPlayer/incoming/ and contact the ffmpeg-devel 
mailing list.

basically, once done correctly, the proper thing to do is to use 
ff_copy_bits() to re-align, then call the WMAPro decoder, count the 
number of bits read and then go back into the WMAVoice decoder and 
subtract that number of bits (not bytes) off of the bit context. 
Shouldn't be too hard once I know what to do with the WMAPro decoder 
init.


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue1912
Index: libavcodec/wmavoice.c
===
--- libavcodec/wmavoice.c   (revision 26050)
+++ libavcodec/wmavoice.c   (working copy)
@@ -38,6 +38,7 @@
 #include libavutil/lzo.h
 #include avfft.h
 #include fft.h
+#include wma.h
 
 #define MAX_BLOCKS   8   /// maximum number of blocks per frame
 #define MAX_LSPS 16  /// maximum filter order
@@ -256,7 +257,7 @@
 /**
  * @}
  * @defgroup post_filter Postfilter values
- * Varibales used for postfilter implementation, mostly history for
+ * Variables used for postfilter implementation, mostly history for
  * smoothing and so on, and context variables for FFT/iFFT.
  * @{
  */
@@ -283,7 +284,17 @@
   /// synthesis
 /**
  * @}
+ * @defgroup wmapro_in_wmavoice values for supporting WMAPro-in-WMAVoice
+ * Codec context and related information for WMAPro-in-WMAVoice.
+ * @{
  */
+AVCodecContext *proctx;
+int   pro_samples_per_frame;  /// (default) samples per WMAPro 
(super)frame
+int   pro_spf_nbits;  /// number of bits coding for 
samples-per-frame
+  /// when customly specified in bitstream
+/**
+ * @}
+ */
 } WMAVoiceContext;
 
 /**
@@ -1719,7 +1730,7 @@
 {
 WMAVoiceContext *s = ctx-priv_data;
 GetBitContext *gb = s-gb, s_gb;
-int n, res, n_samples = 480;
+int n, res, n_samples, max_samples, is_speech_frame, spf_nbits, shl;
 double lsps[MAX_FRAMES][MAX_LSPS];
 const double *mean_lsf = s-lsps == 16 ?
 wmavoice_mean_lsf16[s-lsp_def_mode] : 
wmavoice_mean_lsf10[s-lsp_def_mode];
@@ -1741,22 +1752,80 @@
 
 /* First bit is speech/music bit, it differentiates between WMAVoice
  * speech samples (the actual codec) and WMAVoice music samples, which
- * are really WMAPro-in-WMAVoice-superframes. I've never seen those in
- * the wild yet. */
-if (!get_bits1(gb)) {
-av_log_missing_feature(ctx, WMAPro-in-WMAVoice support, 1);
-return -1;
+ * are really WMAPro-in-WMAVoice-superframes. */
+if (!(is_speech_frame = get_bits1(gb))) {
+if (!s-pro_spf_nbits) {
+AVCodec *pro;
+
+s-pro_samples_per_frame = 1  
ff_wma_get_frame_len_bits(ctx-sample_rate,
+  3, 
AV_RL16(ctx-extradata + 14));
+s-pro_spf_nbits = av_log2(s-pro_samples_per_frame  4);
+
+/* open decoder on demand, because 1) it's usually not needed and
+ * 2) it will cause thread locking errors when doing it recursively
+ * from within _init(). */
+if (!(pro = avcodec_find_decoder(CODEC_ID_WMAPRO))) {
+av_log(ctx, AV_LOG_WARNING,
+   WMAPro decoder not found, WMAPro-in-WMAVoice will not 
work\n);
+return -1;
+} else {
+/* init wmapro decoder */
+if (!(s-proctx = avcodec_alloc_context())) {
+av_log(ctx, AV_LOG_ERROR,
+   Failed to allocate WMAPro-in-WMAVoice context\n);
+return AVERROR(ENOMEM);
+}
+if ((res = avcodec_copy_context(s-proctx, ctx))  0) {
+av_log(ctx, AV_LOG_ERROR,
+   Failed to copy WMAVoice to WMAPro context\n);
+av_free(s-proctx-extradata);
+av_freep(s-proctx);
+return res;
+}
+s-proctx-codec_id   = CODEC_ID_WMAPRO;
+s-proctx-extradata_size = 18;
+
+if ((res = avcodec_open(s-proctx, pro))  0) {
+av_log(ctx, AV_LOG_ERROR,
+   Failed to open WMAPro-in-WMAVoice decoder\n);
+av_free(s-proctx-extradata);
+av_freep(s-proctx);
+return res

[issue2451] wmaprodec.c: remove remaining_bits()

2010-12-26 Thread Ronald S. Bultje

New submission from Ronald S. Bultje rsbul...@gmail.com:

wmaprodec.c:remaining_bits_left() looks like a copy of get_bits_left(), so 
we should use get_bits_left() instead of implementing our own version of 
it.

--
messages: 13058
priority: normal
status: new
substatus: new
title: wmaprodec.c: remove remaining_bits()
type: feature_request


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2451



[issue1912] WMAPro-in-WMAVoice support not implemented

2010-12-25 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

I can't find any file containing agile on incoming, and issue1912/ does 
not exist...


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue1912



[issue2448] Crash in RTP packet reordering code

2010-12-25 Thread Ronald S. Bultje

New submission from Ronald S. Bultje rsbul...@gmail.com:

$ gdb ./ffplay_g
(gdb) r rtsp://stream.zune.net:554/a4241/e3/033/984/819/at/audio.wma
Starting program: /Users/ronaldbultje/Projects/ffmpeg-svn/x86-
64/ffplay_g rtsp://stream.zune.net:554/a4241/e3/033/984/819/at/audio.wma
[..]
FFplay version SVN-r26050, Copyright (c) 2003-2010 the FFmpeg developers
  built on Dec 17 2010 21:53:08 with gcc 4.2.1 (Apple Inc. build 5664)
  configuration: --samples=/Users/ronaldbultje/Movies/fate-suite --
enable-gpl
  libavutil 50.34. 0 / 50.34. 0
  libavcore  0.16. 0 /  0.16. 0
  libavcodec52.99. 1 / 52.99. 1
  libavformat   52.88. 0 / 52.88. 0
  libavdevice   52. 2. 2 / 52. 2. 2
  libavfilter1.69. 0 /  1.69. 0
  libswscale 0.12. 0 /  0.12. 0
[asf @ 0x10105e000] Ext DRM protected stream detected, decoding will 
likely fail!
[asf @ 0x10105e000] DRM protected stream detected, decoding will likely 
fail!
[asf @ 0x10105e000] Digital signature detected, decoding will likely 
fail!
[rtsp @ 0x10104b200] method SETUP failed: 461 Unsupported Transport

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_INVALID_ADDRESS at address: 0x0180
[Switching to process 72662]
ff_rtp_queued_packet_time (s=0x0) at 
/Users/ronaldbultje/Projects/ffmpeg-svn/libavformat/rtpdec.c:619
619 return s-queue ? s-queue-recvtime : 0;

gdb) bt
#0  ff_rtp_queued_packet_time (s=0x0) at 
/Users/ronaldbultje/Projects/ffmpeg-svn/libavformat/rtpdec.c:619
#1  0x00010008d461 in ff_rtsp_fetch_packet (s=0x10104b200, 
pkt=0x116772930) at /Users/ronaldbultje/Projects/ffmpeg-
svn/libavformat/rtsp.c:1559
(gdb) print s
$1 = (RTPDemuxContext *) 0x0
(gdb) 

Not sure where the NULL check should be, but a crash is always 
unacceptable.

--
messages: 13045
priority: normal
status: new
substatus: new
title: Crash in RTP packet reordering code
type: bug


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2448



[issue726] Possible license violation, Chroma

2010-12-16 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Please don't change the status.

--
status: closed - open
substatus: invalid - reproduced


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue726



[issue1587] Turkish Telecom's Wirofon infringes the GPL

2010-11-12 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

The program has been opensourced and license to redistribute has been 
restored, so I think the issue is resolved now.

Carl Eugen, is it OK to mark this as resolved?


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue1587



[issue2344] Patch: Remove banner based on environment variable FF_NO_BANNER = true

2010-11-07 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

I'm against this change, since it makes it possible to circumvent GPLv2.0 
section 2c or GPLv3.0 section 5d. The LGPL has similar requirements (but 
more properly worded for library use, see section 7b of LGPLv2.1).


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2344



[issue1502] Orange LiveRadio iPhone APP license violation

2010-10-29 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

I just reconfirmed this with today's download, version 2.0 available 
from French iTunes store.

Macintosh-9:LiveRadio.app ronaldbultje$ nm LiveRadio|grep _c
0004f0a0 t -[RFRadioController(Private) _checkInternetConnection]
0004f054 t -[RFRadioController(Private) _checkMaxDownload]
0004efa4 t -[RFRadioController(Private) _checkProduct:]
000ae720 s _OBJC_IVAR_$_LRSortedChildren._container
000b5784 S _OBJC_IVAR_$_PhoenixWebClient._cachePath
000b3758 S _OBJC_IVAR_$_RemoteImageCache._cacheDirectory
00028ce4 T __Z13rmff_new_contPKcS0_S0_S0_
00024480 T __ZN15TMAEntClientMMS12send_commandEiijjiPc
 U __ZTVN10__cxxabiv117__class_type_infoE
 U __ZTVN10__cxxabiv120__si_class_type_infoE
 U __ZTVN10__cxxabiv121__vmi_class_type_infoE
0007ad70 t ___aeabi_cdcmpeq
0007ad70 t ___aeabi_cdcmple
0007ad54 t ___aeabi_cdrcmple
0007b538 t ___aeabi_cfcmpeq
0007b538 t ___aeabi_cfcmple
0007b528 t ___aeabi_cfrcmple
000a2a64 s ___clz_tab
0007acd0 t ___cmpdf2
0007b4c8 t ___cmpsf2
3b28 t ___copy_helper_block_1
3b48 t ___copy_helper_block_2
3ae8 t ___copy_helper_block_3
3b08 t ___copy_helper_block_4
 U __objc_empty_cache
00033c6e t _add_8x8basis_c
00033ca4 t _add_bytes_c
00033d08 t _add_bytes_l2_c
0002bdc8 t _add_pixels4_c
0002bd20 t _add_pixels8_c
0002bc3e t _add_pixels_clamped_c
00046d7c t _asf_read_close
00020d78 t _asmrp_comp_expression
00020e12 t _asmrp_condition
0004ac40 T _av_alloc_format_context
0004b468 T _av_close_input_stream
000a38f0 s _av_codec_context_class
000a76f4 s _av_format_context_class
000bcec0 d _av_log_callback
0004c838 T _av_log_default_callback
00041376 T _av_parser_close
0003fcba T _av_picture_copy
000497bc T _av_update_cur_dts
00043990 T _avcodec_alloc_context
0004396e T _avcodec_alloc_context2
000431f8 T _avcodec_check_dimensions
00043336 T _avcodec_close
0003f8b8 T _avcodec_get_chroma_sub_sample
000438b2 T _avcodec_get_context_defaults2
000426f4 T _avcodec_pix_fmt_to_codec_tag
0003784c t _avg_h264_chroma_mc2_c
00037588 t _avg_h264_chroma_mc4_c
000370e0 t _avg_h264_chroma_mc8_c
00039524 t _avg_h264_qpel16_mc00_c
0003a600 t _avg_h264_qpel16_mc01_c
0003292e t _avg_h264_qpel16_mc02_c
0003a5b4 t _avg_h264_qpel16_mc03_c
0003a686 t _avg_h264_qpel16_mc10_c
0003a54c t _avg_h264_qpel16_mc11_c
0003a2b0 t _avg_h264_qpel16_mc12_c
0003a474 t _avg_h264_qpel16_mc13_c
000328e0 t _avg_h264_qpel16_mc20_c
0003a39c t _avg_h264_qpel16_mc21_c
00032986 t _avg_h264_qpel16_mc22_c
0003a330 t _avg_h264_qpel16_mc23_c
0003a64c t _avg_h264_qpel16_mc30_c
0003a4e0 t _avg_h264_qpel16_mc31_c
0003a22c t _avg_h264_qpel16_mc32_c
0003a408 t _avg_h264_qpel16_mc33_c
00039588 t _avg_h264_qpel4_mc00_c
00039abc t _avg_h264_qpel4_mc01_c
00039230 t _avg_h264_qpel4_mc02_c
00039a5c t _avg_h264_qpel4_mc03_c
00039b4a t _avg_h264_qpel4_mc10_c
000399f0 t _avg_h264_qpel4_mc11_c
0003979c t _avg_h264_qpel4_mc12_c
00039914 t _avg_h264_qpel4_mc13_c
0003248c t _avg_h264_qpel4_mc20_c
0003985e t _avg_h264_qpel4_mc21_c
00032630 t _avg_h264_qpel4_mc22_c
00039816 t _avg_h264_qpel4_mc23_c
00039b1c t _avg_h264_qpel4_mc30_c
00039982 t _avg_h264_qpel4_mc31_c
00039720 t _avg_h264_qpel4_mc32_c
000398a4 t _avg_h264_qpel4_mc33_c
000394b8 t _avg_h264_qpel8_mc00_c
00039f58 t _avg_h264_qpel8_mc01_c
00032898 t _avg_h264_qpel8_mc02_c
00039f18 t _avg_h264_qpel8_mc03_c
00039fc6 t _avg_h264_qpel8_mc10_c
00039ecc t _avg_h264_qpel8_mc11_c
00039cf8 t _avg_h264_qpel8_mc12_c
00039e30 t _avg_h264_qpel8_mc13_c
0003288c t _avg_h264_qpel8_mc20_c
00039d9a t _avg_h264_qpel8_mc21_c
000328c4 t _avg_h264_qpel8_mc22_c
00039d52 t _avg_h264_qpel8_mc23_c
00039f98 t _avg_h264_qpel8_mc30_c
00039e7e t _avg_h264_qpel8_mc31_c
00039c9c t _avg_h264_qpel8_mc32_c
00039de0 t _avg_h264_qpel8_mc33_c
000394d0 t _avg_no_rnd_pixels16_c
0003a9f2 t _avg_no_rnd_pixels16_x2_c
0003cd40 t _avg_no_rnd_pixels16_xy2_c
0003a9ae t _avg_no_rnd_pixels16_y2_c
0003953c t _avg_no_rnd_pixels8_c
0003a9d8 t _avg_no_rnd_pixels8_x2_c
0003cb68 t _avg_no_rnd_pixels8_xy2_c
0003a994 t _avg_no_rnd_pixels8_y2_c
000394fa t _avg_pixels16_c
0003a1b8 t _avg_pixels16_x2_c
0003cf40 t _avg_pixels16_xy2_c
0003a174 t _avg_pixels16_y2_c
000393fc t _avg_pixels2_c
00039672 t _avg_pixels2_x2_c
0002be3e t _avg_pixels2_xy2_c
00039658 t _avg_pixels2_y2_c
00039546 t _avg_pixels4_c
00039b92 t _avg_pixels4_x2_c
0003cf6a t _avg_pixels4_xy2_c
00039b78 t _avg_pixels4_y2_c
00039434 t _avg_pixels8_c
0003a19e t _avg_pixels8_x2_c
0003cd6a t _avg_pixels8_xy2_c
0003a15a t _avg_pixels8_y2_c
00039530 t _avg_qpel16_mc00_c
0003a7bc t _avg_qpel16_mc01_c
00030512 t _avg_qpel16_mc02_c
0003a768 t _avg_qpel16_mc03_c
0003a850 t _avg_qpel16_mc10_c
0003c650 t _avg_qpel16_mc11_c
0003c470 t _avg_qpel16_mc12_c
0003c554 t _avg_qpel16_mc13_c
0002fef4 t _avg_qpel16_mc20_c
0003a714 t _avg_qpel16_mc21_c
0003053c t _avg_qpel16_mc22_c
0003a6c0 t _avg_qpel16_mc23_c
0003a810 t _avg_qpel16_mc30_c
0003c5d4 t _avg_qpel16_mc31_c
0003c408 t _avg_qpel16_mc32_c
0003c4d8 t _avg_qpel16_mc33_c
000394c4

[issue2306] YASM libavcodec/x86/dsputil_yasm.o

2010-10-25 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Also please run:

yasm -f macho -e -o /tmp/x.s dsputil_yasm.asm

and then attach /tmp/x.s here. Is this latest SVN of FFmpeg or latest 
SVN of YASM (or both). If FFmpeg SVN is problem, can you tell us which 
revision introduced the compiler bug?


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2306



[issue2270] RTP parser fails on RFC 3550 header extensions

2010-10-06 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

 +/* RFC 3550 Section 5.3.1 RTP Header Extension handling */
 +if (ext) {
 +if (len  4)
 +return -1;
 +// retrieve header extension length (number of 32-bit words)
 +ext = AV_RB16(buf + 2);
 +
 +// add header extension itself to extension length
 +ext++;
 +
 +// convert header extension length to bytes
 +ext = 2;

ext = (AV_RB16(..) + 1)  2;, this isn't barbie-code.

+// abort if extension length exceeds remaining buffer length
+if (len  ext)
+return -1;
+
+// skip past RTP header extension
+len -= ext;
+buf += ext;
+}

Rest OK.


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2270



[issue2266] add null checking to mmst

2010-10-05 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Fixed in r25349, thanks.

--
status: open - closed
substatus: needs_changes - fixed


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2266



[issue2266] add null checking to mmst

2010-10-03 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

read() is called after close(). That is a bug inside aviobuf.c or whatever 
part is calling this code, the patch itself is an imo unacceptable) 
workaround. The proper fix is to not call read() after close().


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2266



[issue2249] error decoding h264

2010-09-27 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

You need to decode more data before the first image is returned. simply 
call avcodec_decode_video2() again with subsequent frame data until 
got_picture != 0.


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2249



[issue2220] WAV to AAC causes glitches/noise in STEREO

2010-09-24 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Alex told me he's currently working on mono-only and stereo will be buggy 
for a while. So the suggestion is to not use the internal AAC encoder for 
stereo for a while or bug (pay) Alex or one of his teammates (e.g. 
saintdev, forgot his real name) to work on this fulltime to fix it.


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2220



[issue2212] rtsp punch packets sent to wrong IP

2010-09-03 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

+} else if (!strcmp(parameter, source)) {
+if (*p == '=') {

(This should be fixed, this is hideous, all over that function, but 
that's ok for now.)

-/* XXX: also use address if specified */
-ff_url_join(url, sizeof(url), rtp, NULL, host,
-reply-transports[0].server_port_min, NULL);
+/* Use source address if specified */
+if (reply-transports[0].source[0]) {
+ff_url_join(url, sizeof(url), rtp, NULL,
+reply-transports[0].source,
+reply-transports[0].server_port_min, 
NULL);
+} else {
+ff_url_join(url, sizeof(url), rtp, NULL, host,
+reply-transports[0].server_port_min, 
NULL);
+}

Please separate the reindenting from the function change while 
committing.

+/** Space for text ip address (max of INET_ADDRSTRLEN INET6_ADDRSTRLEN) 
*/
+#define MAX_ADDRSTR_LEN 46

Please use INET6_ADDRSTRLEN. If undefined, in os_support.h, set it to 
INET_ADDRSTRLEN. If undefined, set it to some random number, e.g. 46. 
Don't hardcode this stuff unnecessarily.

General idea sounds good to me.


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2212



[issue2212] rtsp punch packets sent to wrong IP

2010-09-03 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

I think we'd like to use the IPv6 API where-ever possible, including here. 
If it's unavailable, os_support should provide a fallback for the IPv4 
API. If that's unavailable, it should not be compiled in the first place 
because the whole networking stack will be disabled (--disable=network).


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2212



[issue2212] rtsp punch packets sent to wrong IP

2010-09-03 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

+#ifndef INET6_ADDRSTRLEN
+#  if defined(INET_ADDRSTRLEN)
+#define INET6_ADDRSTRLEN INET_ADDRSTRLEN
+#  endif
+#endif

The inner if/endif aren't necessary (I was wrong there earlier). 
Otherwise OK.


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2212



[issue2212] rtsp punch packets sent to wrong IP

2010-09-03 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

OK from me too.


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2212



[issue2212] rtsp punch packets sent to wrong IP

2010-09-03 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Applied, thanks.

--
status: new - closed
substatus: new - fixed


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2212



[issue2183] ffplay does not stop playing

2010-08-23 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Use ./ffplay -autoexit to have it quit at the end of file. By default, it 
stays on so you can seek back in the file.

--
status: open - closed
substatus: new - invalid


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2183



[issue733] AVS Video Converter violoates FFmpeg's license

2010-08-19 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

avs4you.com domain registration info:

egistrant:
Online Media Technologies Ltd.

Suite B, 29 Harley Street
London, W1G9QR
United Kingdom

Registered through: GoDaddy.com, Inc. (http://www.godaddy.com)
Domain Name: AVS4YOU.COM
Created on: 23-Aug-06
Expires on: 23-Aug-12
Last Updated on: 05-May-07

Administrative Contact:
Myasnikov, Aleksei m...@avsmedia.com
Online Media Technologies Ltd.
Suite B, 29 Harley Street
London, W1G9QR
United Kingdom
2071826722 Fax -- 2071826722

Technical Contact:
Myasnikov, Aleksei m...@avsmedia.com
Online Media Technologies Ltd.
Suite B, 29 Harley Street
London, W1G9QR
United Kingdom
2071826722 Fax -- 2071826722


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue733



[issue660] VoltaicHD infringes the GPL

2010-08-17 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

It was decided that this was an old violation to which this doesn't apply, 
so let's leave it closed+fixed.

--
status: open - closed
substatus: open - fixed


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue660



[issue660] VoltaicHD infringes the GPL

2010-08-11 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

This is not a free software product, therefore license still needs to be 
reinstated. Has this been discussed before?

--
status: closed - open
substatus: fixed - open


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue660



[issue2116] Possible license violation, Edimax

2010-08-11 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Edimax Computer Company

3350 Scott Blvd. Bldg 15
Santa Clara, California 95054
United States

Registered through: GoDaddy.com, Inc. (http://www.godaddy.com)
Domain Name: EDIMAX.COM
Created on: 29-Nov-95
Expires on: 28-Nov-10
Last Updated on: 12-Nov-09

Administrative Contact:
Chang, Judy webmas...@edimax.com
Edimax Computer Company
3350 Scott Blvd. Bldg 15
Santa Clara, California 95054
United States
4089886092 Fax -- 4089801530

Technical Contact:
Chang, Judy webmas...@edimax.com
Edimax Computer Company
3350 Scott Blvd. Bldg 15
Santa Clara, California 95054
United States
4089886092 Fax -- 4089801530


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2116



[issue2079] ffplay: segfault if coded video WxH dimension larger than desktop

2010-08-09 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

  av_picture_copy(pict, pict_src,
 -vp-pix_fmt, vp-width, vp-height);
 +vp-pix_fmt, dst_width, dst_height);
  #else
  sws_flags = av_get_int(sws_opts, sws_flags, NULL);
  is-img_convert_ctx = sws_getCachedContext(is-
img_convert_ctx,
 -vp-width, vp-height, vp-pix_fmt, vp-width, vp-
height,
 +vp-width, vp-height, vp-pix_fmt, dst_width, 
dst_height,
  dst_pix_fmt, sws_flags, NULL, NULL, NULL);

Doesn't the top half of the #if/#else truncate the picture unscaled?


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2079



[issue2141] avcodec crash in amarok

2010-08-02 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

(Actually, in this case it probably means the bug is in Xine, not Amarok, 
looking at the backtrace in the original bugreport.)


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2141



[issue2142] Error while decoding P-Frame of mpeg4 data

2010-08-02 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Can you decode the video using ffplay?


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2142



[issue2079] ffplay: segfault if coded video WxH dimension larger than desktop

2010-07-30 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

FWIW, I can reproduce this. Whatever causes the bug should be fixed in 
ffplay.c. Please refrain from further bitchfighting and fix the actual 
bug.


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2079



[issue1607] RTSP stream doesn't play

2010-07-29 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Attached patch screws up rtpdec_asf.c to play this stream. Things to 
note:
- this is actually RDT, not RTP ;-)
- each data packet comes with 8 bytes of ?? before the actual ASF data
- each ASF packet is 4 bytes short (according to the ASF muxer), and 
then has 4 padding bytes in the RTP packet. My hack to asfdec.c fixes 
that.
- the ASF header specifies only 1 stream, but the RDT specifies 2 (see 
ASMRuleBook). I can request both from the server; they appear mostly 
identical. Not sure how to expose that, since rdt.c automatically 
generates a second AVStream, but that currently isn't filled in
- the discard flag isn't set correctly, or rtsp.c screws up, so without 
my hack in rtsp.c, you hear duplicate packet music
- I should probably implement this in rdt_wmt.c or so, but was too lazy 
to properly separate it for now, hence my hacky patch. At least we know 
how it works now. ;-).


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue1607


wmt.patch
Description: Binary data


[issue1607] RTSP stream doesn't play

2010-07-28 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Once you decode the header (and add pn-wmt as mimetype to rtpdec_asf.c), 
the header looks like this:


  00 00 00 00 02 0c d2 14 30 26 b2 75 8e 66 cf 11 
0.u.f..
0010  a6 d9 00 aa 00 62 ce 6c 98 14 00 00 00 00 00 00 
.b.l
0020  07 00 00 00 01 02 33 26 b2 75 8e 66 cf 11 a6 d9 
..3.u.f
0030  00 aa 00 62 ce 6c 5e 00 00 00 00 00 00 00 18 00 
...b.l^.
0040  0e 00 16 00 00 00 00 00 52 00 54 00 45 00 20 00 R.T.E. 
.
0050  52 00 61 00 64 00 69 00 6f 00 20 00 31 00 00 00 R.a.d.i.o. 
.1...
0060  52 00 54 00 45 00 2e 00 69 00 65 00 00 00 a9 00 
R.T.E...i.e.
0070  20 00 52 00 54 00 45 00 20 00 32 00 30 00 31 00  .R.T.E. 
.2.0.1.
0080  30 00 00 00 40 a4 d0 d2 07 e3 d2 11 97 f0 00 a0 
0...@...
0090  c9 5e a8 50 a4 00 00 00 00 00 00 00 03 00 1c 00 
.^.P
00a0  57 00 4d 00 46 00 53 00 44 00 4b 00 56 00 65 00 
W.M.F.S.D.K.V.e.
00b0  72 00 73 00 69 00 6f 00 6e 00 00 00 00 00 1c 00 
r.s.i.o.n...
00c0  31 00 30 00 2e 00 30 00 30 00 2e 00 30 00 30 00 
1.0...0.0...0.0.
00d0  2e 00 34 00 30 00 30 00 35 00 00 00 1a 00 57 00 
..4.0.0.5.W.
00e0  4d 00 46 00 53 00 44 00 4b 00 4e 00 65 00 65 00 
M.F.S.D.K.N.e.e.
00f0  64 00 65 00 64 00 00 00 00 00 16 00 30 00 2e 00 
d.e.d...0...
0100  30 00 2e 00 30 00 2e 00 30 00 30 00 30 00 30 00 
0...0...0.0.0.0.
0110  00 00 0c 00 49 00 73 00 56 00 42 00 52 00 00 00 
I.s.V.B.R...
0120  02 00 04 00 00 00 00 00 40 52 d1 86 1d 31 d0 11 
@r...1..
0130  a3 a4 00 a0 c9 03 48 f6 ae 00 00 00 00 00 00 00 
..H.
0140  41 52 d1 86 1d 31 d0 11 a3 a4 00 a0 c9 03 48 f6 
AR...1H.
0150  01 00 00 00 02 00 18 00 57 00 69 00 6e 00 64 00 
W.i.n.d.
0160  6f 00 77 00 73 00 20 00 4d 00 65 00 64 00 69 00 o.w.s. 
.M.e.d.i.
0170  61 00 20 00 41 00 75 00 64 00 69 00 6f 00 20 00 a. .A.u.d.i.o. 
.
0180  39 00 2e 00 31 00 00 00 24 00 20 00 33 00 32 00 9...1...$. 
.3.2.
0190  20 00 6b 00 62 00 70 00 73 00 2c 00 20 00 32 00  .k.b.p.s.,. 
.2.
01a0  32 00 20 00 6b 00 48 00 7a 00 2c 00 20 00 73 00 2. .k.H.z.,. 
.s.
01b0  74 00 65 00 72 00 65 00 6f 00 20 00 31 00 2d 00 t.e.r.e.o. 
.1.-.
01c0  70 00 61 00 73 00 73 00 20 00 43 00 42 00 52 00 p.a.s.s. 
.C.B.R.
01d0  00 00 02 00 61 01 ce 75 f8 7b 8d 46 d1 11 8d 82 
a..u.{.F
01e0  00 60 97 c9 a2 b2 20 00 00 00 00 00 00 00 01 00 .` 
.
01f0  01 00 85 7f 00 00 a1 dc ab 8c 47 a9 cf 11 8e e4 
..G.
0200  00 c0 0c 20 53 65 68 00 00 00 00 00 00 00 f7 07 ... 
Seh.
0210  45 6c 75 d2 6a 46 aa 76 0a 0f d7 a1 b1 56 ca 14 
Elu.jF.v.V..
0220  00 00 00 00 00 00 e0 81 2a 2f 46 27 cb 01 ff ff 
*/F'
0230  ff ff 00 00 00 00 00 00 00 00 00 00 00 00 00 00 

0240  00 00 00 00 00 00 2b 06 00 00 00 00 00 00 09 00 
..+.
0250  00 00 ee 05 00 00 ee 05 00 00 85 7f 00 00 b5 03 

0260  bf 5f 2e a9 cf 11 8e e3 00 c0 0c 20 53 65 d0 11 ._. 
Se..
0270  00 00 00 00 00 00 11 d2 d3 ab ba a9 cf 11 8e e6 

0280  00 c0 0c 20 53 65 06 00 a2 11 00 00 a9 46 43 7c ... 
Se...FC|
0290  e0 ef fc 4b b2 29 39 3e de 41 5c 85 34 00 00 00 
...K.)9.A\.4...
02a0  00 00 00 00 02 00 0c 65 00 6e 00 2d 00 69 00 65 ...e.n.-
.i.e
02b0  00 00 00 0c 65 00 6e 00 2d 00 75 00 73 00 00 00 e.n.-
.u.s...
02c0  ea cb f8 c5 af 5b 77 48 84 67 aa 8c 44 fa 4c ca 
.[wH.g..D.L.
02d0  fc 00 00 00 00 00 00 00 04 00 00 00 01 00 0c 00 

02e0  02 00 02 00 00 00 49 00 73 00 56 00 42 00 52 00 
..I.s.V.B.R.
02f0  00 00 00 00 00 00 01 00 34 00 00 00 06 00 00 00 
4...
0300  44 00 65 00 76 00 69 00 63 00 65 00 43 00 6f 00 
D.e.v.i.c.e.C.o.
0310  6e 00 66 00 6f 00 72 00 6d 00 61 00 6e 00 63 00 
n.f.o.r.m.a.n.c.
0320  65 00 54 00 65 00 6d 00 70 00 6c 00 61 00 74 00 
e.T.e.m.p.l.a.t.
0330  65 00 00 00 4c 00 32 00 00 00 00 00 01 00 2e 00 
e...L.2.
0340  03 00 04 00 00 00 57 00 4d 00 2f 00 57 00 4d 00 
..W.M./.W.M.
0350  41 00 44 00 52 00 43 00 50 00 65 00 61 00 6b 00 
A.D.R.C.P.e.a.k.
0360  52 00 65 00 66 00 65 00 72 00 65 00 6e 00 63 00 
R.e.f.e.r.e.n.c.
0370  65 00 00 00 79 2b 00 00 00 00 01 00 34 00 03 00 
e...y+..4...
0380  04 00 00 00 57 00 4d 00 2f 00 57 00 4d 00 41 00 
W.M./.W.M.A.
0390  44 00 52 00 43 00 41 00 76 00 65 00 72 00 61 00 
D.R.C.A.v.e.r.a.
03a0  67 00 65 00 52 00 65 00 66 00 65 00 72 00 65 00 
g.e.R.e.f.e.r.e.
03b0  6e 00 63 00 65 00 00 00 1d 0f 00 00 cb a5 e6 14 
n.c.e...
03c0  72 c6 32 43 83 99 a9 69 52 06 5b 5a 58 00 00 00 
r.2C...iR.[ZX...
03d0  00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 

03e0  00 00 00 00 18 7d 00 00 2b 06 00 00 00 00 00 00 
.}..+...
03f0  18 7d 00 00 2b 06 00 00 00 00 00 00 cf 05

[issue2121] Mplayer LIBRTSP:buffer overflow in rtsp_get

2010-07-22 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

This is the FFmpeg bug tracker, not the MPlayer one.

--
status: new - closed
substatus: new - invalid


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2121



[issue1908] Conceiva ConvertHQ violates the LGPL

2010-07-19 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Hi Dennis,

I've brought this up with your team several times now. I've been 
promised several times taht the product will be taken offline next 
week. If the product will be discontinued, please take it offline. If 
you intend to keep it online (for whatever reason), please make it 
comply.

At this point, I can do little else but agree with Carl Eugen's 
assessment regarding this violation: Conceiva is still violating the 
GPL/LGPL license of FFmpeg.

Thanks,
Ronald


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue1908



[issue2082] Crash in FFT-SSE code when playing mmst URI

2010-07-14 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

It crashes (also in the C version) in this piece of code:

__asm__ volatile(
1: \n
CMUL(%0, %%xmm0, %%xmm1)
CMUL(%1, %%xmm4, %%xmm5)

Particularly, the second mulps in CMUL. That's a multiply with variables 
in s-tsin/s-tcos, suggesting these aren't properly assigned.


(gdb) print tcos
$1 = value temporarily unavailable, due to optimizations
(gdb) print s
$2 = (FFTContext *) 0x2de2490
(gdb) print *s
$3 = {
  nbits = 10, 
  inverse = 1, 
  revtab = 0x1842200, 
  tmp_buf = 0x183ca00, 
  mdct_size = 0, 
  mdct_bits = 0, 
  tcos = 0x1000, 
  tsin = 0xc, 
  fft_permute = 0x182a800, 
  fft_calc = 0x182b800, 
  imdct_calc = 0x45b6f0 ff_imdct_calc_sse, 
  imdct_half = 0x45b3f0 ff_imdct_half_sse, 
  mdct_calc = 0x225730 ff_mdct_calc_c, 
  permutation = 0
}
(gdb) print *s-tcos
$4 = -1.58164644e+38
(gdb) print *s-tsin 
Cannot access memory at address 0xc
(gdb) 

Where are these allocated, and by who? It looks like they're broke here.


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2082



[issue2082] Crash in FFT-SSE code when playing mmst URI

2010-07-14 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

I also think wmadec.c never calls ff_imdct_init(), which is probably 
related to all this?


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2082



[issue2082] Crash in FFT-SSE code when playing mmst URI

2010-07-14 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Valgrind suggests something else. First error:

==70074== Invalid write of size 4
==70074==at 0x2F285D: ff_rdft_init (in ./ffplay)
==70074==  Address 0x13f6ee28 is 8 bytes after a block of size 80 
alloc'd
==70074==at 0xB5042A: memalign (vg_replace_malloc.c:532)
==70074==by 0xB50475: posix_memalign (vg_replace_malloc.c:660)
==70074==by 0x4B2510: av_malloc (in ./ffplay)

Indeed, that code writes into a struct RDFTContext, sizeof() which is 
80, at position 0x58 (i.e. 88-92):

0x002f2856 ff_rdft_init+326:  inc%esi
0x002f2857 ff_rdft_init+327:  cmp0x20(%esp),%esi
0x002f285b ff_rdft_init+331:  jne0x2f2830 ff_rdft_init+288
0x002f285d ff_rdft_init+333:  movl   $0x2f2870,0x58(%ebp)
0x002f2864 ff_rdft_init+340:  xor%eax,%eax
0x002f2866 ff_rdft_init+342:  jmp0x2f2793 ff_rdft_init+131

I have absolutely no idea what this means but something seems 
miscompiled?


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2082



[issue2082] Crash in FFT-SSE code when playing mmst URI

2010-07-14 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

A make clean fixed it.

--
status: new - closed
substatus: new - invalid


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2082



[issue2000] Sloochaj! iPhone application violates LGPL

2010-06-11 Thread Ronald S. Bultje

New submission from Ronald S. Bultje rsbul...@gmail.com:

http://itunes.apple.com/pl/app/sloochaj/id350353249?
uo%3D2%26mt%3D8%26uo%3D2 is an IPhone app (see incoming/ in a minute) 
that uses FFmpeg, without attribution, mention, sources, license, etc:

bash-3.2$ nm ~/Desktop/Sloochaj\!/Payload/Sloochaj\!.app/Sloochaj\! 
|grep -i decoder
003d24c0 D _aac_decoder
003d25a4 D _aasc_decoder
003d2e80 D _adpcm_4xm_decoder
003d2ec4 D _adpcm_adx_decoder
003d2e3c D _adpcm_ct_decoder
003d2df8 D _adpcm_ea_decoder
003d2db4 D _adpcm_ea_maxis_xa_decoder
003d2d70 D _adpcm_ea_r1_decoder
003d2d2c D _adpcm_ea_r2_decoder
003d2ce8 D _adpcm_ea_r3_decoder
003d2ca4 D _adpcm_ea_xas_decoder
003d4f84 D _adpcm_g726_decoder
003d2c60 D _adpcm_ima_amv_decoder
003d2c1c D _adpcm_ima_dk3_decoder
003d2bd8 D _adpcm_ima_dk4_decoder
003d2b94 D _adpcm_ima_ea_eacs_decoder
003d2b50 D _adpcm_ima_ea_sead_decoder
003d2b0c D _adpcm_ima_iss_decoder
003d2a7c D _adpcm_ima_qt_decoder
003d2a38 D _adpcm_ima_smjpeg_decoder
003d29a8 D _adpcm_ima_wav_decoder
003d2964 D _adpcm_ima_ws_decoder
003d28d4 D _adpcm_ms_decoder
003d2890 D _adpcm_sbpro_2_decoder
003d284c D _adpcm_sbpro_3_decoder
003d2808 D _adpcm_sbpro_4_decoder
003d2778 D _adpcm_swf_decoder
003d2734 D _adpcm_thp_decoder
003d26f0 D _adpcm_xa_decoder
003d2660 D _adpcm_yamaha_decoder
003d2f54 D _alac_decoder
003d95f0 D _amv_decoder
003d2fdc D _ape_decoder
003d30fc D _asv1_decoder
003d30b8 D _asv2_decoder
003d3140 D _atrac3_decoder
00246988 T _avcodec_find_decoder
002469c4 T _avcodec_find_decoder_by_name
003d3184 D _avs_decoder
003d31c8 D _bethsoftvid_decoder
003d320c D _bfi_decoder
003d3250 D _bmp_decoder
003d32e0 D _c93_decoder
003d3350 D _cavs_decoder
003d3394 D _cinepak_decoder
003d33d8 D _cljr_decoder
003d341c D _cook_decoder
003d3460 D _cscd_decoder
003d34a4 D _cyuv_decoder
003d34e8 D _dca_decoder
003d35b0 D _dnxhd_decoder
003d3750 D _dsicinaudio_decoder
003d3794 D _dsicinvideo_decoder
000cd8e0 t _dvbsub_close_decoder
003d4a74 D _dvbsub_decoder
000cd658 t _dvbsub_init_decoder
003d4ae4 D _dvdsub_decoder
003d496c D _dvvideo_decoder
003d4b6c D _dxa_decoder
003d4bb0 D _eacmv_decoder
003d4bf4 D _eatgq_decoder
003d4c38 D _eatgv_decoder
003d23f4 D _eightbps_decoder
003d2438 D _eightsvx_exp_decoder
003d247c D _eightsvx_fib_decoder
003d4c7c D _escape124_decoder
00092044 T _ff_init_cabac_decoder
00201a14 T _ff_init_range_decoder
0021c370 t _ff_sipr_decoder_init
003d4d90 D _ffv1_decoder
003d5a40 D _ffvhuff_decoder
003d4dd4 D _flac_decoder
003d4e64 D _flashsv_decoder
003d4efc D _flic_decoder
003d56b4 D _flv_decoder
003d23b0 D _fourxm_decoder
003d4f40 D _fraps_decoder
003d5060 D _gif_decoder
003d50d0 D _h261_decoder
003d584c D _h263_decoder
003d56f8 D _h263i_decoder
003d5918 D _h264_decoder
003d5a84 D _huffyuv_decoder
003d5ac8 D _idcin_decoder
003d5b0c D _imc_decoder
003d5b64 D _indeo2_decoder
003d5ba8 D _indeo3_decoder
003d370c D _interplay_dpcm_decoder
003d5bec D _interplay_video_decoder
003d5c30 D _jpegls_decoder
003d5ccc D _kmvc_decoder
003d5e20 D _loco_decoder
003d5ea8 D _mace3_decoder
003d5e64 D _mace6_decoder
003d5f04 D _mdec_decoder
003d5f48 D _mimic_decoder
003d6054 D _mjpeg_decoder
003d5fcc D _mjpegb_decoder
003d6114 D _mlp_decoder
003d615c D _mmvideo_decoder
003d61a0 D _motionpixels_decoder
003d6708 D _mp1_decoder
003d66c4 D _mp2_decoder
003d6680 D _mp3_decoder
003d663c D _mp3adu_decoder
003d65f8 D _mp3on4_decoder
003d6238 D _mpc7_decoder
003d627c D _mpc8_decoder
003d6348 D _mpeg1video_decoder
003d6304 D _mpeg2video_decoder
003d5890 D _mpeg4_decoder
003d62c0 D _mpegvideo_decoder
003d5808 D _msmpeg4v1_decoder
003d57c4 D _msmpeg4v2_decoder
003d5780 D _msmpeg4v3_decoder
003d6f74 D _msrle_decoder
003d6fb8 D _msvideo1_decoder
003d5d54 D _mszh_decoder
003d6ffc D _nellymoser_decoder
003d7098 D _nuv_decoder
003d7dec D _pcm_alaw_decoder
003d7da0 D _pcm_dvd_decoder
003d7d08 D _pcm_f32be_decoder
003d7c70 D _pcm_f32le_decoder
003d7bd8 D _pcm_f64be_decoder
003d7b40 D _pcm_f64le_decoder
003d7aa8 D _pcm_mulaw_decoder
003d7978 D _pcm_s16be_decoder
003d78e0 D _pcm_s16le_decoder
003d7894 D _pcm_s16le_planar_decoder
003d77fc D _pcm_s24be_decoder
003d7764 D _pcm_s24daud_decoder
003d76cc D _pcm_s24le_decoder
003d7634 D _pcm_s32be_decoder
003d759c D _pcm_s32le_decoder
003d7a10 D _pcm_s8_decoder
003d746c D _pcm_u16be_decoder
003d73d4 D _pcm_u16le_decoder
003d733c D _pcm_u24be_decoder
003d72a4 D _pcm_u24le_decoder
003d720c D _pcm_u32be_decoder
003d7174 D _pcm_u32le_decoder
003d7504 D _pcm_u8_decoder
003d70dc D _pcm_zork_decoder
003d7e84 D _pcx_decoder
003d7ec8 D _png_decoder
003d8120 D _ptx_decoder
003dbc6c D _qcelp_decoder
003d8164 D _qdm2_decoder
003d81a8 D _qdraw_decoder
003d81ec D _qpeg_decoder
003d8230 D _qtrle_decoder
003d82c0 D _ra_144_decoder
003d8304 D _ra_288_decoder
00204c4c t _raw_close_decoder
00204c64 t _raw_init_decoder
003d8348 D _rawvideo_decoder
003d83e4 D _rl2_decoder
003d8474 D _roq_decoder
003d36c8 D _roq_dpcm_decoder
003d8514 D _rpza_decoder
003d859c D _rv10_decoder
003d8558 D _rv20_decoder
003d85e0 D

[issue1587] Turkish Telecom's Wirofon infringes the GPL

2010-06-08 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Yes.

Please follow http://ffmpeg.org/legal.html if you need practical advice.


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue1587



[issue1978] Change default number of RTSP audio channels to 1

2010-06-01 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Applied in r23414.

--
status: new - closed
substatus: new - fixed


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue1978



[issue1968] iSedora distributes a non-free build of FFmpeg

2010-05-30 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

(Xuggle isn't interesting because it's opensource. We generally don't 
take legal action against them, although we might sometimes ask them to 
stop doing it. So I'll change the topic to reflect that most discussion 
here will likely be about iSedora, not so much Xuggle, unless others 
want me to email the Xuggle developers also.)

iSedora is indeed a violation, and not a small one. The company is 
registered in Russia. I've asked SFLC if there's anything they can do 
for us over there.

--
title: Non-free builds of FFmpeg are being distributed - iSedora distributes a 
non-free build of FFmpeg


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue1968



[issue1942] License violation - nettvplus

2010-05-14 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Fix topic.

--
topic: +(L)GPL violation


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue1942



[issue1758] WMA Voice decoder does not support APF

2010-05-02 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

rtsp://wm.microsoft.com/ms/Italy/MSDN/agile1.wmv

is an actual file with WMAPro-in-Voice. I think here it happens because the
stream is truncated and thus the last frame has some zero-bytes. I didn't really
look into it but I'm quite sure it's not real.


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue1758



[issue1242] Youtube downloader fails to give credit

2010-05-02 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

And the EULA forbids RE'ing.


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue1242



[issue1758] WMA Voice decoder does not support APF

2010-05-02 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Can we close this? :-).


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue1758



[issue1758] WMA Voice decoder does not support APF

2010-05-02 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Not really, it's correct to display that given the content of the packet. This
will get fixed if we get actual WMAPro-in-Voice support, since then it'll
calculate packet size or zero-byte constraints and signal end-of-file. So let's
close this and continue in your new issue with work on WMAPro-in-Voice.

--
status: open - closed
substatus: open - fixed


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue1758



[issue1758] WMA Voice decoder does not support APF

2010-05-01 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

That's no good.

Carl Eugen, since it obviously works for me, could you do the following for me?
- try this under valgrind
- try this using --disable-optimizations

Thanks!


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue1758



[issue1758] WMA Voice decoder does not support APF

2010-05-01 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Does this patch fix the problem? Looks like a typo...


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue1758
Index: wmavoice.c
===
--- wmavoice.c	(revision 22970)
+++ wmavoice.c	(working copy)
@@ -278,7 +278,7 @@
   /// aligned buffer for LPC tilting
 DECLARE_ALIGNED(16, float, denoise_coeffs_pf)[0x80];
   /// aligned buffer for denoise coefficients
-DECLARE_ALIGNED(16, float, synth_filter_out_buf)[80 + MAX_LSPS_ALIGN16];
+DECLARE_ALIGNED(16, float, synth_filter_out_buf)[0x80 + MAX_LSPS_ALIGN16];
   /// aligned buffer for postfilter speech
   /// synthesis
 /**


[issue1758] WMA Voice decoder does not support APF

2010-05-01 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

As you wish.
File 'streaming_CBR-7K.wma.myout.wav' not attached - you can download it from 
https://roundup.ffmpeg.org/file885.


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue1758



[issue1758] WMA Voice decoder does not support APF

2010-05-01 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

As for the crash, I might've gotten lost in the valgrind mess from this buffer
overrun. Could you re-run valgrind on the patched version, and also provide a
new gdb output if it changed?


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue1758



[issue1758] WMA Voice decoder does not support APF

2010-05-01 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Er... *shame* How about this patch?


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue1758
Index: wmavoice.c
===
--- wmavoice.c	(revision 23005)
+++ wmavoice.c	(working copy)
@@ -697,7 +697,7 @@
 ff_rdft_calc(s-rdft, coeffs);
 synth_pf[0] *= coeffs[0];
 synth_pf[1] *= coeffs[1];
-for (n = 1; n  128; n++) {
+for (n = 1; n  64; n++) {
 float v1 = synth_pf[n * 2], v2 = synth_pf[n * 2 + 1];
 synth_pf[n * 2] = v1 * coeffs[n * 2] - v2 * coeffs[n * 2 + 1];
 synth_pf[n * 2 + 1] = v2 * coeffs[n * 2] + v1 * coeffs[n * 2 + 1];


[issue488] License violation by Conceiva

2010-04-30 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

provided that you also do one of the following, as per section 3. Assuming
their about dialog/eula/website has a link to the source, that fullfills 3b, so
3a no longer applies.


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue488



[issue488] License violation by Conceiva

2010-04-30 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

The GPL is ambiguous about that, but I would obviously prefer if the source link
was available in the About dialog and the EULA as well.


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue488



[issue1902] Coby Media Manager violates GPL

2010-04-29 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Ooh, an American company. I've FW'ed this to SFLC.


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue1902



[issue488] License violation by Conceiva

2010-04-29 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

New installer released, license violation resolved, so the issue can be closed 
now.

--
status: open - closed
substatus: reproduced - fixed


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue488



[issue1899] rtp doesn't demux audio/X-QDM and video/X-SV3V-ES

2010-04-27 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

Josh will hopefully implement these two as part of GSoC.

Antique patches (by me) available at:
http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2009-July/073511.html
http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2009-August/073826.html


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue1899



[issue321] skypecap software fails to acknowledge ffmpeg

2010-04-16 Thread Ronald S. Bultje

Ronald S. Bultje rsbul...@gmail.com added the comment:

This software no longer uses FFmpeg, it uses Lame only now. Can we close this or
somehow take it off the list in the issue tracker (I don't care much about the
hall of shame itself, but this is noise in the issue tracker list).

CommonDialogs.dll   MediaLog.dllWMVConfig.dll
Converter.exe   MediaSettings.dll   sender.exe
ExportRenderers.dll MpegWriter.dll  unins000.dat
GeoVidCommon.dllSkyCapCommon.dllunins000.exe
HomePage.urlSkypeCap.exevcredist_x86_sp1.exe
Hook.dllSoundCap.dllzlib.dll
LameDshowEncoder.dllVideoConvertation.dll   zlib1.dll


FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue321



  1   2   3   >