Martin Storsjö mar...@martin.st added the comment:
I looked at the packet dump, and the patch looks quite ok to me. I touched
it up a little, here's another version of it. I'll apply it in a few days
if nobody objects.
--
nosy: +mstorsjo
Ronald S. Bultje rsbul...@gmail.com added the comment:
+/* RFC 3550 Section 5.3.1 RTP Header Extension handling */
+if (ext) {
+if (len 4)
+return -1;
+// retrieve header extension length (number of 32-bit words)
+ext = AV_RB16(buf + 2);
+
+
Martin Storsjö mar...@martin.st added the comment:
Applied in SVN rev 25372.
--
status: open - closed
substatus: needs_changes - implemented
FFmpeg issue tracker iss...@roundup.ffmpeg.org
https://roundup.ffmpeg.org/issue2270
Carl Eugen Hoyos ceho...@rainbow.studorg.tuwien.ac.at added the comment:
Please produce your patch with svn diff, use tools/patcheck to test and
attach it to this issue.
--
status: new - open
substatus: analyzed - needs_changes
FFmpeg
Robert Schlabbach rober...@gmx.net added the comment:
Here is the SVN diff patch, tested with patcheck,
which only complained about a missing changelog entry.
But since the source file had no changelog entries at
all, I suppose that's ok?
Luca Barbato lu_z...@gentoo.org added the comment:
hi, the patch looks more or less ok (just a }; that should be } as Martin
noted on irc), do you have test samples for it? what's the producer?
FFmpeg issue tracker iss...@roundup.ffmpeg.org
Robert Schlabbach rober...@gmx.net added the comment:
The RTP/UDP multicast source which exposed this
problem is Deutsche Telekom's IPTV service (T-Home
Entertain) in Germany. If you happen to have a
developer amongst you who has this service, you can
reproduces this problem e.g. with:
Robert Schlabbach rober...@gmx.net added the comment:
Ok, here is a single RTP/UDP multicast packet showing
a RTP header extension of 8 32-bit words. Plus the 4
bytes of the header extension itself yields 36 bytes
to be skipped by the RTP decoder.
Wireshark does not autodetect it as RTP, so
New submission from Robert Schlabbach rober...@gmx.net:
The RTP parser in libavformat/rtpdec.c, in the
function rtp_parse_packet_internal() does not check
the RTP header extension bit and neglects to skip
header extensions according to RFC 3550 chapter 5.3.1.
This results e.g. in MPEG-2
