Re: [FFmpeg-trac] #7030(avcodec:open): qsv in ffmpeg

[FFmpeg]

#7030: qsv in ffmpeg
-+-
 Reporter:  palich2000   |Owner:
 Type:  defect   |   Status:  open
 Priority:  important|Component:  avcodec
  Version:  git-master   |   Resolution:
 Keywords:  qsv  |   Blocked By:
  regression |
 Blocking:   |  Reproduced by developer:  0
Analyzed by developer:  0|
-+-

Comment (by lizhong1008):

 https://patchwork.ffmpeg.org/patch/14898/ try to fix it. Please help to
 verify.

--
Ticket URL: 
FFmpeg 
FFmpeg issue tracker
___
FFmpeg-trac mailing list
FFmpeg-trac@avcodec.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-trac

To unsubscribe, visit link above, or email
ffmpeg-trac-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-trac] #7030(avcodec:open): qsv in ffmpeg

[FFmpeg]

#7030: qsv in ffmpeg
-+-
 Reporter:  palich2000   |Owner:
 Type:  defect   |   Status:  open
 Priority:  important|Component:  avcodec
  Version:  git-master   |   Resolution:
 Keywords:  qsv  |   Blocked By:
  regression |
 Blocking:   |  Reproduced by developer:  0
Analyzed by developer:  0|
-+-

Comment (by fulinjie):

 Before commit
 
http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=b0cd14fb1dab4b044f7fe6b53ac635409849de77#patch3,


 {{{
 -if (ist->hwaccel_id != HWACCEL_NONE)
 -type = hw_device_match_type_by_hwaccel(ist->hwaccel_id);
 -else
 -type = hw_device_match_type_in_name(ist->dec->name);
 -if (type != AV_HWDEVICE_TYPE_NONE) {
  dev = hw_device_get_by_type(type);
 }}}
 dev could be got through dec->name and then calls
 '''ff_qsv_init_session_device''' to CreateCORE/SetHandle and make sure the
 decoder works well.

 However, after this commit, dev could not be got in
 hw_device_match_by_codec
 {{{
 dev = hw_device_match_by_codec(ist->dec);
 }}}

 because AV_CODEC_HW_CONFIG_METHOD_HW_DEVICE_CTX is not configured as a
 method in ff_qsv_hw_configs.

 {{{
 +for (i = 0;; i++) {
 +config = avcodec_get_hw_config(codec, i);
 +if (!config)
 +return NULL;
 +if (!(config->methods & AV_CODEC_HW_CONFIG_METHOD_HW_DEVICE_CTX))
 +continue;
 +dev = hw_device_get_by_type(config->device_type);
 +if (dev)
 +return dev;
  }
 }}}

 As a consequence, '''ff_qsv_init_internal_session''' was called to
 CreateCORE only without SetHandle.
 And it leads to the decode failure.

 Also as Zhong has mentioned, the removal of ff_qsv_set_display_handle() in
 ff_qsv_init_internal_session is one of the reasons as well.

--
Ticket URL: 
FFmpeg 
FFmpeg issue tracker
___
FFmpeg-trac mailing list
FFmpeg-trac@avcodec.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-trac

To unsubscribe, visit link above, or email
ffmpeg-trac-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-trac] #7030(avcodec:open): qsv in ffmpeg

[FFmpeg]

#7030: qsv in ffmpeg
-+-
 Reporter:  palich2000   |Owner:
 Type:  defect   |   Status:  open
 Priority:  important|Component:  avcodec
  Version:  git-master   |   Resolution:
 Keywords:  qsv  |   Blocked By:
  regression |
 Blocking:   |  Reproduced by developer:  0
Analyzed by developer:  0|
-+-
Changes (by fulinjie):

 * cc: linjie.fu@… (added)


Comment:

 Double confirmed that it works on windows and this issue occurs on linux
 only in ffmpeg qsv decode, and could be reproducde with any
 clips(H264/H265).

 And this issue could be split into two parts:
 1. which part introduces this regression?
 2. why it works on windows but fails on linux?

 Analysis:
 1.
 This error may be relevant with FactoryCORE::CreateCORE and
 VAAPIVideoCORE::SetHandle.
 On Linux, the created CORE is used in
 MFXVideoDECODE_Init/MFX_Utility::CheckVideoParam without calling
 SetHandle.

 However, Application shall call SetHandle on Linux, but it wasn't called
 in Linux pipeline currently after FactoryCORE::CreateCORE was called.(in
 MFXInit() inside ff_qsv_process_data)


 2.And the reason it works for windows may be:
 "On the past we intentionally didn't implement initialization of vaDisplay
 inside MSDK library on Linux because on Linux there were many back-
 ends(X11, Wayland, headless drm, etc) and that time we didn't want to
 bring this logic inside MediaSDK."

 https://github.com/Intel-Media-SDK/MediaSDK/issues/1611

--
Ticket URL: 
FFmpeg 
FFmpeg issue tracker
___
FFmpeg-trac mailing list
FFmpeg-trac@avcodec.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-trac

To unsubscribe, visit link above, or email
ffmpeg-trac-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-trac] #7030(avcodec:open): qsv in ffmpeg

[FFmpeg]

#7030: qsv in ffmpeg
-+-
 Reporter:  palich2000   |Owner:
 Type:  defect   |   Status:  open
 Priority:  important|Component:  avcodec
  Version:  git-master   |   Resolution:
 Keywords:  qsv  |   Blocked By:
  regression |  Reproduced by developer:  0
 Blocking:   |
Analyzed by developer:  0|
-+-

Comment (by lizhong1008):

 Not sure why it works well on Mark's side as comments #10 (Maybe it just
 broken on Linux but works well on Linux?  I can understand
 "-init_hw_device" is not needed on Windows since the commit
 1f26a231bb065276cd80ce02957c759f3197edfa removing
 ff_qsv_set_display_handle() has no impact on Windows).
 But on Linux, passing a decoded frame by software decoder to qsv encoder
 directly is broken on FFmpeg 4.0 (this is the problem of this ticket).
 Passing a qsv decoded frame to a software encoder is also
 broken.(Reproduce: ffmpeg -c:v h264_qsv -i
 bbb_sunflower_1080p_30fps_normal.h264 -vframes 100 -c:v libx264
 test.h264). These paths are supported on ffmpeg-3.4.
 On FFmpeg 4.0, looks like we must use "hwupload" or "hwdownload" for these
 cases.
 An example of this issue, an alternative way without palich's patch is
 using hwupload:
 ./ffmpeg -init_hw_device qsv=hw -filter_hw_device hw -i input.mp4 -vframes
 100 -vf "hwupload=extra_hw_frames=64, format=qsv" -c:v h264_qsv out.mp4

--
Ticket URL: 
FFmpeg 
FFmpeg issue tracker
___
FFmpeg-trac mailing list
FFmpeg-trac@avcodec.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-trac

Re: [FFmpeg-trac] #7030(avcodec:open): qsv in ffmpeg

[FFmpeg]

#7030: qsv in ffmpeg
-+-
 Reporter:  palich2000   |Owner:
 Type:  defect   |   Status:  open
 Priority:  important|Component:  avcodec
  Version:  git-master   |   Resolution:
 Keywords:  qsv  |   Blocked By:
  regression |  Reproduced by developer:  0
 Blocking:   |
Analyzed by developer:  0|
-+-
Changes (by lizhong1008):

 * cc: zhong.li@… (added)


--
Ticket URL: 
FFmpeg 
FFmpeg issue tracker
___
FFmpeg-trac mailing list
FFmpeg-trac@avcodec.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-trac

Re: [FFmpeg-trac] #7030(avcodec:open): qsv in ffmpeg

[FFmpeg]

#7030: qsv in ffmpeg
-+-
 Reporter:  palich2000   |Owner:
 Type:  defect   |   Status:  open
 Priority:  important|Component:  avcodec
  Version:  git-master   |   Resolution:
 Keywords:  qsv  |   Blocked By:
  regression |  Reproduced by developer:  0
 Blocking:   |
Analyzed by developer:  0|
-+-

Comment (by lizhong1008):

 More detail:
 OS info:
 lsb_release -a
 LSB Version:
 
:core-4.1-amd64:core-4.1-noarch:cxx-4.1-amd64:cxx-4.1-noarch:desktop-4.1-amd64:desktop-4.1-noarch:languages-4.1-amd64:languages-4.1-noarch:printing-4.1-amd64:printing-4.1-noarch
 Distributor ID: CentOS
 Description:CentOS Linux release 7.3.1611 (Core)
 Release:7.3.1611
 Codename:   Core

 MSDK version: MediaServerStudioEssentials2017R3 (API version 1.23)

 FFmpeg log (see the attachment)

 Check GPU usage with metrics_monitor
 {{{
 ./metrics_monitor
 RENDER usage: 0.00, VIDEO usage: 0.00,  VIDEO_E usage: 0.00
 VIDEO2 usage: 0.00  GT Freq: 300.00
 }}}

--
Ticket URL: 
FFmpeg 
FFmpeg issue tracker
___
FFmpeg-trac mailing list
FFmpeg-trac@avcodec.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-trac

Re: [FFmpeg-trac] #7030(avcodec:open): qsv in ffmpeg

[FFmpeg]

#7030: qsv in ffmpeg
-+-
 Reporter:  palich2000   |Owner:
 Type:  defect   |   Status:  open
 Priority:  important|Component:  avcodec
  Version:  git-master   |   Resolution:
 Keywords:  qsv  |   Blocked By:
  regression |  Reproduced by developer:  0
 Blocking:   |
Analyzed by developer:  0|
-+-

Comment (by lizhong1008):

 I've tried to reproduce it on ffmpeg-4.0 branch:
 ./ffmpeg -loglevel verbose -init_hw_device qsv=hw -i
 /samba/anonymous/Videos/bbb_sunflower_1080p_30fps_normal.mp4 -c:v h264_qsv
 -b:v 1000k test.mp4

 The transcoding pipeline didn't crash, but reported "Encoder will work
 with partial HW acceleration, Warning in encoder initialization: partial
 acceleration (4)". The transcoding speed was very slow (about 20 fps), and
 it shows the gpu usage is zero when use metrics_monitor to check GPU
 usage.
 It means software path was used instead of GPU accelerated.

--
Ticket URL: 
FFmpeg 
FFmpeg issue tracker
___
FFmpeg-trac mailing list
FFmpeg-trac@avcodec.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-trac

Re: [FFmpeg-trac] #7030(avcodec:open): qsv in ffmpeg

[FFmpeg]

#7030: qsv in ffmpeg
-+-
 Reporter:  palich2000   |Owner:
 Type:  defect   |   Status:  open
 Priority:  important|Component:  avcodec
  Version:  git-master   |   Resolution:
 Keywords:  qsv  |   Blocked By:
  regression |  Reproduced by developer:  0
 Blocking:   |
Analyzed by developer:  0|
-+-

Comment (by palich2000):

 {{{
 Linux 3.10.0-327.el7.x86_64 #1 SMP Thu Nov 19 22:10:57 UTC 2015 x86_64
 x86_64 x86_64 GNU/Linux
 }}}
 {{{
  [ OK ] Media SDK HW API level:1.19
  [ OK ] Media SDK SW API level:1.19
  [ OK ] OpenCL check:platform:Intel(R) OpenCL GPU OK CPU OK
 }}}

 {{{
 ffmpeg -t 30 -v verbose -i rtmp://x \
 -c:v h264_qsv -b:v 1000k\
 -strict experimental -acodec aac -ab 64k -ar 44100 \
 -f flv rtmp://127.0.0.1/vip/_77_
 }}}

 {{{
 ffmpeg version N-90198-g7056d06 Copyright (c) 2000-2018 the FFmpeg
 developers
   built with gcc 4.8.5 (GCC) 20150623 (Red Hat 4.8.5-11)
   configuration: --prefix=/home/palich/ffmpeg-test/ --extra-
 cflags='-I/home/palich/ffmpeg-test//include -Ofast -march=native' --extra-
 ldflags='-L/home/palich/ffmpeg-test//lib -ldl' --enable-avresample
 --enable-static --enable-shared --enable-nonfree --enable-gpl --enable-
 version3 --enable-libx264 --enable-libfdk-aac --enable-librtmp --enable-
 gnutls --enable-libfreetype --enable-filters --enable-postproc --disable-
 doc --enable-libmp3lame --disable-stripping --enable-debug=3 --enable-
 runtime-cpudetect --enable-libmfx
   libavutil  56.  8.100 / 56.  8.100
   libavcodec 58. 13.100 / 58. 13.100
   libavformat58. 10.100 / 58. 10.100
   libavdevice58.  2.100 / 58.  2.100
   libavfilter 7. 12.100 /  7. 12.100
   libavresample   4.  0.  0 /  4.  0.  0
   libswscale  5.  0.101 /  5.  0.101
   libswresample   3.  0.101 /  3.  0.101
   libpostproc55.  0.100 / 55.  0.100
 Routing option strict to both codec and muxer layer
 Parsing...
 Parsed protocol: 0
 Parsed host: vr0.dpl-streaming.com
 Parsed app : virtual
 RTMP_Connect1, ... connected, handshaking
 HandShake: Type Answer   : 03
 HandShake: Server Uptime : 134225664
 HandShake: FMS Version   : 0.0.0.0
 HandShake: Handshaking finished
 RTMP_Connect1, handshaked
 Invoking connect
 HandleServerBW: server BW = 500
 HandleClientBW: client BW = 500 2
 HandleChangeChunkSize, received: chunk size change to 4096
 RTMP_ClientPacket, received: invoke 190 bytes
 (object begin)
 Property: 
 Property: 
 Property: 
 (object begin)
 Property: 
 Property: 
 (object end)
 Property: 
 (object begin)
 Property: 
 Property: 
 Property: 
 Property: 
 (object end)
 (object end)
 HandleInvoke, server invoking <_result>
 HandleInvoke, received result for method call 
 sending ctrl. type: 0x0003
 Invoking createStream
 RTMP_ClientPacket, received: invoke 29 bytes
 (object begin)
 Property: 
 Property: 
 Property: NULL
 Property: 
 (object end)
 HandleInvoke, server invoking <_result>
 HandleInvoke, received result for method call 
 SendPlay, seekTime=0, stopTime=0, sending play: vrm_foot_live
 Invoking play
 sending ctrl. type: 0x0003
 HandleCtrl, received ctrl. type: 0, len: 6
 HandleCtrl, Stream Begin 1
 RTMP_ClientPacket, received: invoke 96 bytes
 (object begin)
 Property: 
 Property: 
 Property: NULL
 Property: 
 (object begin)
 Property: 
 Property: 
 Property: 
 (object end)
 (object end)
 HandleInvoke, server invoking 
 HandleInvoke, onStatus: NetStream.Play.Start
 RTMP_ClientPacket, received: notify 24 bytes
 (object begin)
 Property: 
 Property: 
 Property: 
 (object end)
 RTMP_ClientPacket, received: invoke 110 bytes
 (object begin)
 Property: 
 Property: 
 Property: NULL
 Property: 
 (object begin)
 Property: 
 Property: 
 Property: 
 (object end)
 (object end)
 HandleInvoke, server invoking 
 HandleInvoke, onStatus: NetStream.Play.PublishNotify
 RTMP_ClientPacket, received: notify 387 bytes
 (object begin)
 Property: 
 Property: 
 (object begin)
 Property: 
 Property: 
 Property: 
 Property: 
 Property: 
 Property: 
 Property: 
 Property: 
 Property: 
 Property: 
 Property: 
 Property: 
 Property: 
 Property: 
 (object end)
 (object end)
 Metadata:
   ServerNGINX RTMP (github.com/arut/nginx-rtmp-module)
   width 1280.00
   height720.00
   displayWidth  1280.00
   displayHeight 720.00
   duration  0.00
   framerate 25.00
   fps   25.00
   videodatarate 976.00
   videocodecid  7.00
   audiodatarate 62.00
   audiocodecid  10.00
 [h264 @ 0x138b040] Reinit context to 1280x720, pix_fmt: yuv420p
 Input #0, live_flv, from 'rtmp://':
   Metadata

Re: [FFmpeg-trac] #7030(avcodec:open): qsv in ffmpeg

[FFmpeg]

#7030: qsv in ffmpeg
-+-
 Reporter:  palich2000   |Owner:
 Type:  defect   |   Status:  open
 Priority:  important|Component:  avcodec
  Version:  git-master   |   Resolution:
 Keywords:  qsv  |   Blocked By:
  regression |  Reproduced by developer:  0
 Blocking:   |
Analyzed by developer:  0|
-+-

Comment (by jkqxz):

 Replying to [comment:13 palich2000]:
 > Look above, there I described everything.

 If might help if you could increase the scope of "everything" to include:
 * Operating system details, including kernel version.
 * What version of the Media SDK you are using (some specific proprietary
 version, the open-source one?).
 * A complete log of ffmpeg output for the failing case.

--
Ticket URL: 
FFmpeg 
FFmpeg issue tracker
___
FFmpeg-trac mailing list
FFmpeg-trac@avcodec.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-trac

Re: [FFmpeg-trac] #7030(avcodec:open): qsv in ffmpeg

[FFmpeg]

#7030: qsv in ffmpeg
-+-
 Reporter:  palich2000   |Owner:
 Type:  defect   |   Status:  open
 Priority:  important|Component:  avcodec
  Version:  git-master   |   Resolution:
 Keywords:  qsv  |   Blocked By:
  regression |  Reproduced by developer:  0
 Blocking:   |
Analyzed by developer:  0|
-+-

Comment (by palich2000):

 Believe me, this will not help.
 You can choose the parameters for which there will be no error. But the
 encoding will occur on the CPU and not on the GPU.

--
Ticket URL: 
FFmpeg 
FFmpeg issue tracker
___
FFmpeg-trac mailing list
FFmpeg-trac@avcodec.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-trac

Re: [FFmpeg-trac] #7030(avcodec:open): qsv in ffmpeg

[FFmpeg]

#7030: qsv in ffmpeg
-+-
 Reporter:  palich2000   |Owner:
 Type:  defect   |   Status:  open
 Priority:  important|Component:  avcodec
  Version:  git-master   |   Resolution:
 Keywords:  qsv  |   Blocked By:
  regression |  Reproduced by developer:  0
 Blocking:   |
Analyzed by developer:  0|
-+-

Comment (by heleppkes):

 The message even has a hint of what to do - try choosing a different rate
 control mode.

--
Ticket URL: 
FFmpeg 
FFmpeg issue tracker
___
FFmpeg-trac mailing list
FFmpeg-trac@avcodec.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-trac

Re: [FFmpeg-trac] #7030(avcodec:open): qsv in ffmpeg

[FFmpeg]

#7030: qsv in ffmpeg
-+-
 Reporter:  palich2000   |Owner:
 Type:  defect   |   Status:  open
 Priority:  important|Component:  avcodec
  Version:  git-master   |   Resolution:
 Keywords:  qsv  |   Blocked By:
  regression |  Reproduced by developer:  0
 Blocking:   |
Analyzed by developer:  0|
-+-

Comment (by palich2000):

 Look above, there I described everything.

--
Ticket URL: 
FFmpeg 
FFmpeg issue tracker
___
FFmpeg-trac mailing list
FFmpeg-trac@avcodec.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-trac

Re: [FFmpeg-trac] #7030(avcodec:open): qsv in ffmpeg

[FFmpeg]

#7030: qsv in ffmpeg
-+-
 Reporter:  palich2000   |Owner:
 Type:  defect   |   Status:  open
 Priority:  important|Component:  avcodec
  Version:  git-master   |   Resolution:
 Keywords:  qsv  |   Blocked By:
  regression |  Reproduced by developer:  0
 Blocking:   |
Analyzed by developer:  0|
-+-

Comment (by jkqxz):

 Then I suggest providing more information about your setup, and a complete
 log of a failing command.

--
Ticket URL: 
FFmpeg 
FFmpeg issue tracker
___
FFmpeg-trac mailing list
FFmpeg-trac@avcodec.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-trac

Re: [FFmpeg-trac] #7030(avcodec:open): qsv in ffmpeg

[FFmpeg]

#7030: qsv in ffmpeg
-+-
 Reporter:  palich2000   |Owner:
 Type:  defect   |   Status:  open
 Priority:  important|Component:  avcodec
  Version:  git-master   |   Resolution:
 Keywords:  qsv  |   Blocked By:
  regression |  Reproduced by developer:  0
 Blocking:   |
Analyzed by developer:  0|
-+-

Comment (by palich2000):

 Without this parameter, the situation is as follows.
 The codec tries to code programmatically and it does not work.

 {{{
 [h264_qsv @ 0x1e87ec0] Selected ratecontrol mode is not supported by the
 QSV runtime. Choose a different mode.
 Error initializing output stream 0:0 -- Error while opening encoder for
 output stream #0:0 - maybe incorrect parameters such as bit_rate, rate,
 width or height
 [aac @ 0x1e8a540] Qavg: 62368.684
 }}}

--
Ticket URL: 
FFmpeg 
FFmpeg issue tracker
___
FFmpeg-trac mailing list
FFmpeg-trac@avcodec.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-trac

Re: [FFmpeg-trac] #7030(avcodec:open): qsv in ffmpeg

[FFmpeg]

#7030: qsv in ffmpeg
-+-
 Reporter:  palich2000   |Owner:
 Type:  defect   |   Status:  open
 Priority:  important|Component:  avcodec
  Version:  git-master   |   Resolution:
 Keywords:  qsv  |   Blocked By:
  regression |  Reproduced by developer:  0
 Blocking:   |
Analyzed by developer:  0|
-+-

Comment (by jkqxz):

 This works fine for me.  At a guess you are somehow opening the DRM master
 device rather than a render node and therefore the unused top-level device
 has exclusive access to the GPU and stops the encoder from opening it?

 If that's the problem then not creating the unused top-level device
 (remove the `-init_hw_device` option) should make it work for you.  (That
 device did automatically get passed to an encoder in 3.4, but there was
 disagreement about that feature being useful because ffmpeg was unable to
 tell whether the device was required or not (it isn't here, the internal
 session works for isolated encoders) and offered unhelpful warnings.)

--
Ticket URL: 
FFmpeg 
FFmpeg issue tracker
___
FFmpeg-trac mailing list
FFmpeg-trac@avcodec.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-trac

Re: [FFmpeg-trac] #7030(avcodec:open): qsv in ffmpeg

[FFmpeg]

#7030: qsv in ffmpeg
-+-
 Reporter:  palich2000   |Owner:
 Type:  defect   |   Status:  open
 Priority:  important|Component:  avcodec
  Version:  git-master   |   Resolution:
 Keywords:  qsv  |   Blocked By:
  regression |  Reproduced by developer:  0
 Blocking:   |
Analyzed by developer:  0|
-+-

Comment (by palich2000):

 OK
 Sended.

--
Ticket URL: 
FFmpeg 
FFmpeg issue tracker
___
FFmpeg-trac mailing list
FFmpeg-trac@avcodec.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-trac

Re: [FFmpeg-trac] #7030(avcodec:open): qsv in ffmpeg

[FFmpeg]

#7030: qsv in ffmpeg
-+-
 Reporter:  palich2000   |Owner:
 Type:  defect   |   Status:  open
 Priority:  important|Component:  avcodec
  Version:  git-master   |   Resolution:
 Keywords:  qsv  |   Blocked By:
  regression |  Reproduced by developer:  0
 Blocking:   |
Analyzed by developer:  0|
-+-

Comment (by cehoyos):

 Please send your patch - made with {{{git format-patch}}} - to the FFmpeg
 development mailing list where it can be reviewed.

--
Ticket URL: 
FFmpeg 
FFmpeg issue tracker
___
FFmpeg-trac mailing list
FFmpeg-trac@avcodec.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-trac

Re: [FFmpeg-trac] #7030(avcodec:open): qsv in ffmpeg

[FFmpeg]

#7030: qsv in ffmpeg
-+-
 Reporter:  palich2000   |Owner:
 Type:  defect   |   Status:  open
 Priority:  important|Component:  avcodec
  Version:  git-master   |   Resolution:
 Keywords:  qsv  |   Blocked By:
  regression |  Reproduced by developer:  0
 Blocking:   |
Analyzed by developer:  0|
-+-

Comment (by palich2000):

 This patch solves the problem, but only for qsv.

 {{{
 diff --git a/libavcodec/qsvenc_h264.c b/libavcodec/qsvenc_h264.c
 index 09e4c0e..5f60675 100644
 --- a/libavcodec/qsvenc_h264.c
 +++ b/libavcodec/qsvenc_h264.c
 @@ -34,6 +34,7 @@
  #include "qsv.h"
  #include "qsv_internal.h"
  #include "qsvenc.h"
 +#include "hwaccel.h"

  typedef struct QSVH264EncContext {
  AVClass *class;
 @@ -169,6 +170,16 @@ static const AVCodecDefault qsv_enc_defaults[] = {
  { NULL },
  };

 +#define HWACCEL_QSV(codec) \
 +HW_CONFIG_HWACCEL(1, 1, 1, QSV,  QSV,  ff_ ## codec
 ## _qsv_hwaccel)
 +
 +const AVHWAccel ff_h264_qsv_hwaccel = {
 +.name = "h264_qsv",
 +.type = AVMEDIA_TYPE_VIDEO,
 +.id   = AV_CODEC_ID_H264,
 +.pix_fmt  = AV_PIX_FMT_QSV
 +};
 +
  AVCodec ff_h264_qsv_encoder = {
  .name   = "h264_qsv",
  .long_name  = NULL_IF_CONFIG_SMALL("H.264 / AVC / MPEG-4 AVC /
 MPEG-4 part 10 (Intel Quick Sync Video acceleration)"),
 @@ -186,5 +197,9 @@ AVCodec ff_h264_qsv_encoder = {
  .priv_class = &class,
  .defaults   = qsv_enc_defaults,
  .caps_internal  = FF_CODEC_CAP_INIT_CLEANUP,
 +.hw_configs= (const AVCodecHWConfigInternal*[]) {
 +   HWACCEL_QSV(h264),
 +NULL
 +},
  .wrapper_name   = "qsv",
  };

 }}}

--
Ticket URL: 
FFmpeg 
FFmpeg issue tracker
___
FFmpeg-trac mailing list
FFmpeg-trac@avcodec.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-trac

Re: [FFmpeg-trac] #7030(avcodec:open): qsv in ffmpeg

[FFmpeg]

#7030: qsv in ffmpeg
-+-
 Reporter:  palich2000   |Owner:
 Type:  defect   |   Status:  open
 Priority:  important|Component:  avcodec
  Version:  git-master   |   Resolution:
 Keywords:  qsv  |   Blocked By:
  regression |  Reproduced by developer:  0
 Blocking:   |
Analyzed by developer:  0|
-+-

Comment (by palich2000):

 The author of the commit Mark Thompson <​s...@jkqxz.net> had some grandiose
 idea but he did not realize it to the end. I do not know how the hardware
 decoders work, but the hardware coders do not work after this commit. The
 function hw_device_setup_for_encode suggests that there is a hardware
 configuration for each encoder, but they are not declared. And hardware
 encoders do not connect to the codec. This should either be removed or
 completed.

--
Ticket URL: 
FFmpeg 
FFmpeg issue tracker
___
FFmpeg-trac mailing list
FFmpeg-trac@avcodec.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-trac

Re: [FFmpeg-trac] #7030(avcodec:open): qsv in ffmpeg

[FFmpeg]

#7030: qsv in ffmpeg
-+-
 Reporter:  palich2000   |Owner:
 Type:  defect   |   Status:  open
 Priority:  important|Component:  avcodec
  Version:  git-master   |   Resolution:
 Keywords:  qsv  |   Blocked By:
  regression |  Reproduced by developer:  0
 Blocking:   |
Analyzed by developer:  0|
-+-
Changes (by cehoyos):

 * status:  new => open


--
Ticket URL: 
FFmpeg 
FFmpeg issue tracker
___
FFmpeg-trac mailing list
FFmpeg-trac@avcodec.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-trac